From: Paolo Pisati <p.pisati@gmail.com>
To: Denis Benato <denis.benato@linux.dev>
Cc: "Paolo Pisati" <p.pisati@gmail.com>,
"Jiri Kosina" <jikos@kernel.org>,
"Benjamin Tissoires" <bentiss@kernel.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
"Rebecca Mara Müller" <rebecca.mara@posteo.de>,
"Luke Jones" <luke@ljones.dev>,
"Joshua Leivenzon" <hacker1024@users.sourceforge.net>,
"Ivan Levchenko" <me@livan.pro>,
"Nathan Chancellor" <nathan@kernel.org>
Subject: Re: [PATCH v3 0/7] HID: asus: ASUS Zenbook Duo keyboard support
Date: Wed, 14 Oct 2026 15:21:54 +0200 [thread overview]
Message-ID: <20261014132242.118388-1-p.pisati@gmail.com> (raw)
In-Reply-To: <424edeef-9663-4e64-a267-66a185b3df07@linux.dev>
On Tue, Oct 13, 2026 at 04:56:39PM +0300, Denis Benato wrote:
> My greatest concern is with report size: every device needs its own and
> hardcoding it is not an option anymore because no device can be fully
> made happy (and working): xg mobile is 300, ally and new ROGs is 64,
> some have 32, some 16 and I think TP is 15.
>
> I have yet to look at the patch that changes the report size but please
> make the report size variable reading it from the descriptor.
Isn't 5/7 what you are looking for?
asus_kbd_set_report() looks up the feature report with the ID in
buf[0] and never sends more than hid_report_len() of it, that is what
the descriptor declares, report ID included. The Zenbook Duo declares
15 data bytes for report 0x5a, so the 64 byte backlight buffer goes
out as 16 bytes, like the handshake, and the keyboard answers it.
A device declaring 64 or more sees no change.
No hurry, enjoy the vacation.
--
bye,
p.
prev parent reply other threads:[~2026-10-14 13:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 10:39 Paolo Pisati
2026-10-13 10:39 ` [PATCH v3 1/7] HID: asus: Fix up Zenbook Duo report descriptors Paolo Pisati
2026-10-13 10:39 ` [PATCH v3 2/7] HID: asus: Add missing Zenbook Duo hotkeys Paolo Pisati
2026-10-13 10:40 ` [PATCH v3 3/7] HID: asus: Force hid-input to bind to the Zenbook Duo hotkey interface Paolo Pisati
2026-10-13 10:40 ` [PATCH v3 4/7] HID: asus: Cycle the platform profile from the Zenbook Duo profile key Paolo Pisati
2026-10-13 10:40 ` [PATCH v3 5/7] HID: asus: Do not send feature reports larger than declared Paolo Pisati
2026-10-13 10:40 ` [PATCH v3 6/7] HID: asus: add prod-id, quirk for Zenbook Duo keyboard Paolo Pisati
2026-10-13 10:40 ` [PATCH v3 7/7] HID: asus: Re-send the Zenbook Duo keyboard handshake after probe Paolo Pisati
2026-10-13 11:45 ` [PATCH v3 0/7] HID: asus: ASUS Zenbook Duo keyboard support Rebecca Mara Müller
2026-10-13 13:56 ` Denis Benato
2026-10-14 13:21 ` Paolo Pisati [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261014132242.118388-1-p.pisati@gmail.com \
--to=p.pisati@gmail.com \
--cc=bentiss@kernel.org \
--cc=denis.benato@linux.dev \
--cc=hacker1024@users.sourceforge.net \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=me@livan.pro \
--cc=nathan@kernel.org \
--cc=rebecca.mara@posteo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®