From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68DB851EE04 for ; Wed, 14 Oct 2026 13:23:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791984212; cv=none; b=pFjG37Vt0wMygSbGl7ZTpv8hhuBcNHyyUWPRUXxd3X8fmOWA9cm8/FGpb/Huv81ezGS2oLsMCKDGHHHNRldlYF6RbSr4BUzzS7l/YAnTs9XBvqEdk5WqiIThvLmZz85XYMB3krbb0Dd+E/rPKAwGbeCO3r1fZp1f+zPITiY4+gY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791984212; c=relaxed/simple; bh=vHlNApf1n0eU2OktVinpI4zv/MZunnjQ95s6jli1xzM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NSNCRwykLVqJDezN036VR+s3LQ35pwJwNATDI6Wa4dr2WuINIGeTnlBUsYR7hW86AOEZk9E0PicaMVYVBLqludvC6X8loF0+NcDD4nMxJjVTAQ86fQlhCasn+JehTdLhAqDaCel+KVuWyDe0OwQvYLNYu6iMws4E8BzHkZBulZ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eSAuN/BQ; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eSAuN/BQ" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-49d0da752ffso8702165e9.3 for ; Wed, 14 Oct 2026 06:23:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791984206; x=1792589006; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jdTRy1oUzdTMPfJnHsa0F48c4vY6O6GHObHAbcTX0Q8=; b=eSAuN/BQJo2nCqQLjw+pMDp7TroyRIUh+tG2RNt+y5srWj/0zFtSD++KkSyhc02vvc mCKQjPKqgWZk0vdxuoncN3EZU6PNpLHRUfXKwQ9Y2DBSqiqnaw8wVgyStiEWcmOcM3NN hh08pFqprCRzonKlZ7QEuIcU8C0opY7TWJlBU1dgCTA54/A7KXRLPEQSwKIpNnTCNSi1 NFw6wNNBHkwipQdDOWbgMd0qH93Q0tjg/9drwaY6u48xOTYlB/mgfxrSuksz6KzAbwal vsANlIkHCUO5p7SdGQ3MagGK2VyzuUBNcrVpf9amwnD6OjLxaguOfGKEfmsS7yuSIYVb 8hyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791984206; x=1792589006; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=jdTRy1oUzdTMPfJnHsa0F48c4vY6O6GHObHAbcTX0Q8=; b=gQIpHUEXn5nkOFTpqbaQL7U1I1sg4CIhv4961fzPHgJoEeysRg7Y+trerKph/x5xfw /8LSExct/ELkPTSBoUPEkmjVeAVYLMNG3599IL/JIz2EGnSJ//K6Sxbs9nBlKG8DEvcS vAsIXNfymOUiuI4wWBPthZLgpXZ8j88tq+PPdip+al19uf3NPgm7/iG8J3X/VLlHS7dF g2HIgOGreAcfvicwl+2ESCdEbv3IYgH1tXMpQSGArekog/8NAmZcJm1Q//rNQ3oCNRAP TxdFVsenBylf65GwHdYIKGZtQQ7kegNUy59KykKX9GThjs/z7ytnwpsYmhhwE3lGXGlN Z4+w== X-Forwarded-Encrypted: i=1; AKwUvBx0BtUuXlGL7T/tWpCGYpQtQvyt40hUdLKwLO5fQ0pE5j7jD4gZOR89wY7uAENdiSaYJ8yG+UZW3UHv8qE=@vger.kernel.org X-Gm-Message-State: AFq9FYKg/lVkfg3U6wExymWsMh7QmdWAMS9128SU0GmnpRU2NcSIwGCH j0vQQf/YlZZ54sLWpsGlnDfQ0uCK/QjNVqko671a3aZFJVHRnS8s4ZiP X-Gm-Gg: AYBFou1aH3k5oYOrszmbXvsu7NkJlxKGloMDbHtx+P1dfyYIQcoDoIko6M+CfPDCPVu QANll8E/BQp/DTAg2jdPo1dw30HRgtaT3jpe/wGBXIvRa1T0RhRvgd3jil20YvyXaXCZ8D7zkwX wzhiYpNgz+BuP14fzKqgQhUfs9s49Fu1QIii4VArJQrLLJTdhLExxs8KtTFBFf/+D8cO2tdf3FQ +fTS8DyatB1q9jrgf6K4ZSwH4LxPWB4jmk4r8ZDTsPJLkVz+CiOpVogsdqg2b491Mhgy1+Z9Trz LR32pkzBqIUa8Y9Z/a0stZguz2rrcvmgWa+uWZSm1tKva7grsEOKTbBkhom/x4O4MLMglwVArBb Kfj4j1FeYnbGtJGjxm1oLKNfMnam9WdvIPHYcoBcimkE43cJpQDWOT5M7aAl2+c4B9aDedT5J2s 3Jmhzdppc7yTdFWnFD7bfPw1bC3HpBwUqZ1imFog+j3BtEnCCVAkuQfxDkAS8JSqvugeZNWYp9N RN1UuRjZUOVrw== X-Received: by 2002:a05:600c:5489:b0:4a0:1c94:7042 with SMTP id 5b1f17b1804b1-4a18e4a5244mr306911845e9.8.1791984206139; Wed, 14 Oct 2026 06:23:26 -0700 (PDT) Received: from localhost.localdomain ([194.154.195.114]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-4a1bcf69402sm782515e9.14.2026.10.14.06.23.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2026 06:23:25 -0700 (PDT) From: Oleg Keri To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Bryan O'Donoghue , Guenter Roeck , Bjorn Andersson , Konrad Dybcio , Abel Vesa Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-hwmon@vger.kernel.org, Konrad Dybcio , Abel Vesa Subject: [PATCH v6 3/3] arm64: dts: qcom: glymur-lenovo-yoga-slim7x: add the embedded controller Date: Wed, 14 Oct 2026 15:23:15 +0200 Message-ID: <20261014132315.4659-4-okerixx@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20261014132315.4659-1-okerixx@gmail.com> References: <20261014132315.4659-1-okerixx@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Describe the Compal embedded controller on I2C at address 0x70. It provides the board thermistors and the CPU fan speed, and drives the keyboard backlight. Its interrupt line is TLMM gpio66, falling edge, for which the file already carries a pin state. That state leaves the pin without a bias. gpio66 has no external pull and floats when the EC is not driving it, which shows up as a steady stream of spurious edges; the vendor ACPI tables describe the same pin as GpioInt(Edge, ActiveLow, Exclusive, PullUp). Enable the pull-up. Signed-off-by: Oleg Keri Reviewed-by: Konrad Dybcio Reviewed-by: Abel Vesa --- .../boot/dts/qcom/glymur-lenovo-yoga-slim7x.dts | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/glymur-lenovo-yoga-slim7x.dts b/arch/arm64/boot/dts/qcom/glymur-lenovo-yoga-slim7x.dts index 769f195c99d9..bc840fd8e458 100644 --- a/arch/arm64/boot/dts/qcom/glymur-lenovo-yoga-slim7x.dts +++ b/arch/arm64/boot/dts/qcom/glymur-lenovo-yoga-slim7x.dts @@ -659,7 +659,15 @@ &i2c9 { status = "okay"; - /* EC @ 0x70, irq = TLMM 66 */ + embedded-controller@70 { + compatible = "lenovo,yoga-slim7x-gen11-ec"; + reg = <0x70>; + + interrupts-extended = <&tlmm 66 IRQ_TYPE_EDGE_FALLING>; + + pinctrl-0 = <&ec_int_n_default>; + pinctrl-names = "default"; + }; }; &lpass_vamacro { @@ -990,7 +998,7 @@ reset-n-pins { ec_int_n_default: ec-int-n-state { pins = "gpio66"; function = "gpio"; - bias-disable; + bias-pull-up; }; kybd_default: kybd-default-state { -- 2.55.0