mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: wyibo6109@gmail.com
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Yibo Wang <wyibo6109@gmail.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-input@vger.kernel.org, Rob Herring <robh@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: input: add OnePlus pogo-pin keyboard
Date: Wed, 14 Oct 2026 08:47:54 -0500	[thread overview]
Message-ID: <20261014134759.10946-1-wyibo6109@gmail.com> (raw)
In-Reply-To: <20261012-weightless-meaty-fennec-cdce10@quoll>

From: Yibo Wang <wyibo6109@gmail.com>

Hi Krzysztof,

On 12/10/2026 01:24, Krzysztof Kozlowski wrote:
> How is that possible? Same OnePlus Pad 3 Pro has different matrices?

No, and sorry for the wording - within one tablet project the keyboard
is fixed.  What I meant is that the matrices differ *between* the
tablet projects that ship this MCU, not within one: the vendor trees
carry per-project geometry (caihong, the sm8650 era project: 2764x1630;
erhai, the sm8750 era project: 2764x1630; iceland, the sm8850 era
project the tested OnePlus Pad 4 belongs to: 2560x1440), while the MCU
protocol has no command to query them.

Which also means your question from v1 is answered the other way
around: the geometry *is* deducible from the compatible once the
compatible names the project.  v3 therefore drops the DT geometry
entirely:

- the compatible names the tablet project
  (oneplus,caihong-/erhai-/iceland-pogo-keyboard, the codenames from
  the vendor trees) and the driver carries a per-project description
  in its match data: feature flags for the 0x3A sub-commands that grew
  over the generations, the touchpad geometry and the per-brand
  product names;

- the common touchscreen properties (touchscreen-size-x/y,
  touchscreen-x-mm/y-mm) are kept only as an optional override, in
  case a variant ever needs one, and are no longer used by the
  example.

v3 will follow as a reply to the cover letter.

Best regards,
Yibo

  reply	other threads:[~2026-10-14 13:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-09 12:20 [PATCH 0/2] Input: add support for OnePlus/OPPO Pad pogo-pin keyboards wyibo6109
2026-10-09 12:20 ` [PATCH 1/2] dt-bindings: input: add OnePlus pogo-pin keyboard binding wyibo6109
2026-10-09 13:22   ` Krzysztof Kozlowski
2026-10-09 12:20 ` [PATCH 2/2] Input: add OnePlus/OPPO Pad pogo-pin keyboard serdev driver wyibo6109
2026-10-10 14:38 ` [PATCH v2 0/2] Input: add support for OnePlus/OPPO Pad pogo-pin keyboards wyibo6109
2026-10-10 14:38   ` [PATCH v2 1/2] dt-bindings: input: add OnePlus pogo-pin keyboard wyibo6109
2026-10-12  6:24     ` Krzysztof Kozlowski
2026-10-14 13:47       ` wyibo6109 [this message]
2026-10-10 14:38   ` [PATCH v2 2/2] Input: add OnePlus/OPPO Pad pogo-pin keyboard serdev driver wyibo6109
2026-10-14 13:52   ` [PATCH v3 0/2] Input: add support for OnePlus/OPPO Pad pogo-pin keyboards wyibo6109
2026-10-14 13:52     ` [PATCH v3 1/2] dt-bindings: input: add OnePlus pogo-pin keyboard wyibo6109
2026-10-14 13:52     ` [PATCH v3 2/2] Input: add OnePlus/OPPO Pad pogo-pin keyboard serdev driver wyibo6109

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261014134759.10946-1-wyibo6109@gmail.com \
    --to=wyibo6109@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=krzk@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®