From: Bo Zhang <zhangbo0325@gmail.com>
To: senozhatsky@chromium.org
Cc: akpm@linux-foundation.org, bgeffon@google.com,
minchan@kernel.org, richardycc@google.com, baohua@kernel.org,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH v3 10/11] zram: use rw_semaphore for decompression streams
Date: Wed, 14 Oct 2026 23:36:03 +0800 [thread overview]
Message-ID: <20261014153603.1365617-1-zhangbo56@xiaomi.com> (raw)
In-Reply-To: <20261013035201.2809924-11-senozhatsky@chromium.org>
Following up on the RFC thread [1]: Sergey pointed me at this series as
the reworked version of the by-direction split I had tested, so I applied
patches 9 and 10 and re-ran the same A/B. Big improvement.
[1] https://lore.kernel.org/lkml/20261012123328.1138059-1-zhangbo56@xiaomi.com
Setup as before: real Android device (MemTotal ~7.7GB, zram ~8GB), cycle
20 apps through fg/bg to force swap-out/in, 8 rounds, reboot before each.
Same trylock instrumentation on the stream locks across all builds. For
patch 10, "read contended" = dpin_contended + dexcl_contended. Decompress
("read") is the swap-in path, which is what matters for us.
I use decompress acquire count (swapped-in pages) as the comparability anchor
instead of swap volume, which stays within ~20% across builds.
baseline preempt-disable 9 + 10
read contended 24,749 406 1,959
read wait_ns total 239.8 s 3.78 s ~12 s
read wait_ns max 757 ms 51.7 ms 72-96 ms
read acquire 3,948,150 4,305,078 3,510,610
Decompression on 9+10 splits into:
shared (stateless backend, single-page): 76.7% -> down_read never
blocked (dpin_contended = 0)
exclusive (cross-page object): 23.3% -> excl_lock, ~1,959 contended
- 9+10: read contention -92%, total wait ~-95%, worst case 757ms -> ~90ms.
The rwsem does the heavy lifting: ~77% of swap-in decompressions now run
concurrently with zero pin contention - exactly the reader-vs-reader
queuing we were hitting. Clear win over the two-mutex split.
- Residual contention is all on the exclusive path, mostly cross-page
objects (which need the ->local_copy bounce), not a specific backend -
lzo-rle single-page objects all go shared.
- preempt-disable still shows the lowest read contention (406). It covers
the other half of the root cause (holder preempted/migrated while
holding the stream), so the two are complementary rather than
competing: 9+10 removes reader-vs-reader queuing structurally, and the
~90ms tail that remains on 9+10 is the preempt/migrate effect.
Happy to share scripts and raw numbers on request.
Thanks,
Bo
next prev parent reply other threads:[~2026-10-14 15:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 3:50 [PATCH v3 00/11] zram: redesign zcomp and rework backends Sergey Senozhatsky
2026-10-13 3:50 ` [PATCH v3 01/11] zram: prefix backends printk-s Sergey Senozhatsky
2026-10-13 3:50 ` [PATCH v3 02/11] zram: remove debugfs entry on init failure Sergey Senozhatsky
2026-10-13 3:50 ` [PATCH v3 03/11] zram: zstd: do not allocate empty C/D-dictionaries Sergey Senozhatsky
2026-10-13 3:50 ` [PATCH v3 04/11] zram: lz4hc: pre-initialize dictionary stream in setup_params Sergey Senozhatsky
2026-10-13 3:50 ` [PATCH v3 05/11] zram: lz4: use LZ4_decompress_safe_usingDict() Sergey Senozhatsky
2026-10-13 3:50 ` [PATCH v3 06/11] zram: lz4hc: " Sergey Senozhatsky
2026-10-13 3:50 ` [PATCH v3 07/11] zram: zstd: do not use kvzalloc() for zstd allocations Sergey Senozhatsky
2026-10-13 3:50 ` [PATCH v3 08/11] zram: reset writeback state in zram_reset_device() Sergey Senozhatsky
2026-10-13 3:50 ` [PATCH v3 09/11] zram: split zcomp into separate R/W streams Sergey Senozhatsky
2026-10-13 3:50 ` [PATCH v3 10/11] zram: use rw_semaphore for decompression streams Sergey Senozhatsky
2026-10-14 15:36 ` Bo Zhang [this message]
2026-10-14 20:46 ` Barry Song
2026-10-15 2:04 ` Sergey Senozhatsky
2026-10-15 3:19 ` Bo Zhang
2026-10-15 3:24 ` Sergey Senozhatsky
2026-10-15 1:41 ` Sergey Senozhatsky
2026-10-15 2:11 ` Sergey Senozhatsky
2026-10-15 3:19 ` Sergey Senozhatsky
2026-10-15 5:18 ` Sergey Senozhatsky
2026-10-15 11:24 ` Bo Zhang
2026-10-13 3:50 ` [PATCH v3 11/11] zram: use a singleton compression context for recompression Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261014153603.1365617-1-zhangbo56@xiaomi.com \
--to=zhangbo0325@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=bgeffon@google.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=richardycc@google.com \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®