mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Chuyi Zhou <zhouchuyi@bytedance.com>
Cc: tglx@kernel.org, mingo@redhat.com, luto@kernel.org,
	peterz@infradead.org, paulmck@kernel.org, muchun.song@linux.dev,
	bp@alien8.de, dave.hansen@linux.intel.com, pbonzini@redhat.com,
	clrkwllms@kernel.org, rostedt@goodmis.org, nadav.amit@gmail.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/5] x86/mm: Allow preemption while waiting for kernel TLB flushes
Date: Wed, 14 Oct 2026 17:38:21 +0200	[thread overview]
Message-ID: <20261014153821.JZpgWYQ7@linutronix.de> (raw)
In-Reply-To: <cover.1791443164.git.zhouchuyi@bytedance.com>

On 2026-10-12 11:41:20 [+0800], Chuyi Zhou wrote:
> Changes in v3:
>   - Patch 4: Retain struct flush_tlb_info in the kernel range helpers and
>     initialize start/end directly, keeping the shared descriptor for
>     future consolidation of the kernel and user paths (Nadav).
> 
> v2: https://lore.kernel.org/cover.1791179421.git.zhouchuyi@bytedance.com/

I did prefer the v2 simply because now only ->start and ->end of struct
flush_tlb_info is initialized and the other fields are not. This is not
used by kernel_tlb_flush_range() (and lower) as of today but who knows…

Anyway, I am not calling the shots here. From the clean up point of view
it looks good to me, so

Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

Sebastian

      parent reply	other threads:[~2026-10-14 15:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-12  3:41 Chuyi Zhou
2026-10-12  3:41 ` [PATCH v3 1/5] x86/mm: Account for remote kernel TLB flush requests Chuyi Zhou
2026-10-12  3:41 ` [PATCH v3 2/5] x86/mm: Share the full TLB flush dispatch Chuyi Zhou
2026-10-12  3:41 ` [PATCH v3 3/5] x86/mm: Extract the TLB range flush threshold check Chuyi Zhou
2026-10-12  3:41 ` [PATCH v3 4/5] x86/mm: Initialize kernel TLB flush requests directly Chuyi Zhou
2026-10-12  3:41 ` [PATCH v3 5/5] x86/mm: Re-enable preemption before waiting for kernel TLB flushes Chuyi Zhou
2026-10-14 15:38 ` Sebastian Andrzej Siewior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261014153821.JZpgWYQ7@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=bp@alien8.de \
    --cc=clrkwllms@kernel.org \
    --cc=dave.hansen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=muchun.song@linux.dev \
    --cc=nadav.amit@gmail.com \
    --cc=paulmck@kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@kernel.org \
    --cc=zhouchuyi@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®