From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2745541E5F for ; Wed, 14 Oct 2026 15:44:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791992669; cv=none; b=ashKkftV6QGDFNmF3BYiuAna623q6iz2hqcwto9NDA8Tb7jlpazC1XOS3vsTTA9/7tQ4cX07MQIHkPhAKNlZdzzWISVpI3KBj7CM0efs0MWpXJKErBlag0ZoiQX/3xkm+FCqvyMuoLmF17mMUO//WOHbznlLrHOaUUWSZ0J/0bY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791992669; c=relaxed/simple; bh=XBqmpRnePSKi6pL7Pxm4mvK8Q86lgvyAFwGvk8EQJMc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WZZWNy7QQX2sWnZz1/CgJfia6Pr21scz1Aaz7w7fW0k3OcP0HoB8y4OFLRKLR+jULD0qWRlb+FBtTlniDR9v2F6GggPLfm76qK2dR43hI7LysrVl/cEEJs+aXdzk0ybF37umF//V9k8UKuxnwox65iJrMpgyuVrcUrHPxHjsG1g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=M2b5N9s8; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="M2b5N9s8" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 487771A1230; Wed, 14 Oct 2026 15:44:23 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 1D95060368; Wed, 14 Oct 2026 15:44:23 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id C326410328540; Wed, 14 Oct 2026 17:44:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1791992658; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding:in-reply-to:references; bh=zgfztfOJ6l8wxkOS8Fa5/mop0OdmxA0oYDEDAChq13Q=; b=M2b5N9s8Qvfcv7PqrIOgEFUvM+FfX7QmRjwehcxPoYt/yhtlxRLvHkawbjQIJTg4zFf10m qXurF++mQXdpTgNWwEEVC7wWwxhvnbztbls49jMC+BvJV0knJLmZzHMndiaJ0TlO0gdqAb JMHJMrFn3fFNztSkN8JQWp27JyxTvMO7oXIgavraMPrH1KRmG4+bvwJSb3ZkTR5ScFkCJq 1etSsz+YFs21hP2/pQ3c+ztiu2yfsjY4zKpeJSRAt3eAiHrWq9E9+gsN0Yg4y81qtDpn01 ISdGItkbRtqmaysjWEK/dxm/VcihGRgfDNf5EUC620VBKCWD0Qt2licGnJVQ7Q== From: Paul Cercueil To: Pratyush Yadav , Michael Walle , Takahiro Kuwano , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Mark Brown , Thomas Petazzoni Cc: Kees Cook , Tony Luck , "Guilherme G . Piccoli" , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Bharat Bhushan , Sunil Kovvuri Goutham , Tanmay Jagdale , stable@vger.kernel.org, Paul Cercueil Subject: [PATCH v3 4/7] spi: cadence-xspi: Clear "SDMA ready" IRQ flag after polling Date: Wed, 14 Oct 2026 17:42:58 +0200 Message-ID: <20261014154301.157755-5-paul.cercueil@bootlin.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261014154301.157755-1-paul.cercueil@bootlin.com> References: <20261014154301.157755-1-paul.cercueil@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 From: Tanmay Jagdale When polling for the "SDMA ready" event, once the corresponding bit is set in the CDNS_XSPI_SDMA_TRIGGER we should reset it to zero. Otherwise, any subsequent call to cdns_xspi_is_sdma_ready() will just return early. Fixes: 931e389ded0f ("spi: cadence: Add Marvell xfer operation support") Cc: stable@vger.kernel.org Signed-off-by: Tanmay Jagdale Co-developed-by: Paul Cercueil Signed-off-by: Paul Cercueil --- Notes: v2: New patch v3: No change drivers/spi/spi-cadence-xspi.c | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers/spi/spi-cadence-xspi.c b/drivers/spi/spi-cadence-xspi.c index 39c868a5b171..095bf640b379 100644 --- a/drivers/spi/spi-cadence-xspi.c +++ b/drivers/spi/spi-cadence-xspi.c @@ -1068,12 +1068,20 @@ static bool cdns_xspi_is_sdma_ready(struct cdns_xspi_dev *cdns_xspi, bool sleep) { u32 ctrl_stat; - return !readl_relaxed_poll_timeout - (cdns_xspi->iobase + CDNS_XSPI_INTR_STATUS_REG, - ctrl_stat, - (ctrl_stat & CDNS_XSPI_SDMA_TRIGGER), - sleep ? MRVL_XSPI_POLL_DELAY_US : 0, - sleep ? MRVL_XSPI_POLL_TIMEOUT_US : 0); + if (readl_relaxed_poll_timeout + (cdns_xspi->iobase + CDNS_XSPI_INTR_STATUS_REG, + ctrl_stat, + (ctrl_stat & CDNS_XSPI_SDMA_TRIGGER), + sleep ? MRVL_XSPI_POLL_DELAY_US : 0, + sleep ? MRVL_XSPI_POLL_TIMEOUT_US : 0)) { + return false; + } + + /* Clear the flag */ + writel(CDNS_XSPI_SDMA_TRIGGER, + cdns_xspi->iobase + CDNS_XSPI_INTR_STATUS_REG); + + return true; } static int cdns_xspi_transfer_one_message_b0(struct spi_controller *controller, -- 2.47.3