From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Vincent Donnefort <vdonnefort@google.com>
Cc: rostedt@goodmis.org, linux-trace-kernel@vger.kernel.org,
mathieu.desnoyers@efficios.com, kernel-team@android.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] ring-buffer: Use subbuf_order in available memory estimation
Date: Thu, 15 Oct 2026 08:22:12 +0900 [thread overview]
Message-ID: <20261014232214.756651F000C4@smtp.kernel.org> (raw)
In-Reply-To: <20261013102047.1488347-3-vdonnefort@google.com>
On Tue, 13 Oct 2026 11:20:47 +0100, Vincent Donnefort <vdonnefort@google.com> wrote:
> To avoid failing in the middle of an allocation of a ring-buffer,
> __rb_allocate_pages() looks at the available memory estimation with
> si_mem_available(). Use the subbuffer order with this estimation to fail
> early if necessary for ring-buffers with an order > 0.
>
> Fixes: f9b94daa542a ("ring-buffer: Set new size of the ring buffer sub page")
> Signed-off-by: Vincent Donnefort <vdonnefort@google.com>
Looks good to me.
Reviewed-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Thanks,
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
prev parent reply other threads:[~2026-10-14 23:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 10:20 [PATCH v2 0/2] ring-buffer: Fixes for " Vincent Donnefort
2026-10-13 10:20 ` [PATCH v2 1/2] ring-buffer: Skip si_mem_available() for persistent and remote buffers Vincent Donnefort
2026-10-14 21:51 ` Steven Rostedt
2026-10-15 8:39 ` Vincent Donnefort
2026-10-13 10:20 ` [PATCH v2 2/2] ring-buffer: Use subbuf_order in available memory estimation Vincent Donnefort
2026-10-14 23:22 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261014232214.756651F000C4@smtp.kernel.org \
--to=mhiramat@kernel.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=rostedt@goodmis.org \
--cc=vdonnefort@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®