From: Luke Macken <luke@phorex.org>
To: andersson@kernel.org, konradybcio@kernel.org
Cc: abelvesa@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, srinivas.kandagatla@oss.qualcomm.com,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Luke Macken <luke@phorex.org>
Subject: [PATCH] arm64: dts: qcom: mahua-lenovo-thinkpad-t14s-gen7: Add Elan touchpad at 0x15
Date: Wed, 14 Oct 2026 17:49:49 -0600 [thread overview]
Message-ID: <20261014234949.1730808-1-luke@phorex.org> (raw)
Like the T14s Gen 6, the Gen 7 ships with either a Synaptics touchpad at
I2C address 0x2c or an Elan one at 0x15. The dts only describes the
Synaptics part, so on Elan units (e.g. 22A7000VUS) the touchpad@2c probe
fails silently (nothing answers at that address) and there is no
touchpad, while an I2C scan finds the device at 0x15.
Describe both, as x1e78100-lenovo-thinkpad-t14s.dtsi does; the absent one
fails probe harmlessly. Both share the interrupt GPIO, so move the
tpad_default pinctrl state from the Synaptics node to the i2c0 bus node
rather than have two nodes claim the same pin.
Assisted-by: LLM
Signed-off-by: Luke Macken <luke@phorex.org>
---
.../mahua-lenovo-thinkpad-t14s-gen7-lcd.dts | 21 ++++++++++++++++---
1 file changed, 18 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/mahua-lenovo-thinkpad-t14s-gen7-lcd.dts b/arch/arm64/boot/dts/qcom/mahua-lenovo-thinkpad-t14s-gen7-lcd.dts
index 26d6d8285..4c805e486 100644
--- a/arch/arm64/boot/dts/qcom/mahua-lenovo-thinkpad-t14s-gen7-lcd.dts
+++ b/arch/arm64/boot/dts/qcom/mahua-lenovo-thinkpad-t14s-gen7-lcd.dts
@@ -646,8 +646,26 @@ &gpu {
&i2c0 {
clock-frequency = <400000>;
+ pinctrl-0 = <&qup_i2c0_data_clk>, <&tpad_default>;
+ pinctrl-names = "default";
+
status = "okay";
+ /* ELAN06B4 */
+ touchpad@15 {
+ compatible = "hid-over-i2c";
+ reg = <0x15>;
+
+ hid-descr-addr = <0x1>;
+ interrupts-extended = <&tlmm 3 IRQ_TYPE_LEVEL_LOW>;
+
+ vdd-supply = <&vreg_misc_3p3>;
+ vddl-supply = <&vreg_l15b_e0_1p8>;
+
+ wakeup-source;
+ };
+
+ /* Synaptics */
touchpad@2c {
compatible = "hid-over-i2c";
reg = <0x2c>;
@@ -658,9 +676,6 @@ touchpad@2c {
vdd-supply = <&vreg_misc_3p3>;
vddl-supply = <&vreg_l15b_e0_1p8>;
- pinctrl-0 = <&tpad_default>;
- pinctrl-names = "default";
-
wakeup-source;
};
--
2.43.0
next reply other threads:[~2026-10-14 23:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 23:49 Luke Macken [this message]
2026-10-15 9:07 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261014234949.1730808-1-luke@phorex.org \
--to=luke@phorex.org \
--cc=abelvesa@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®