mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Timo Joannin <timo.joannin@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	error27@gmail.com, guojy.bj@gmail.com
Subject: Re: [PATCH v5 2/2] staging: rtl8723bs: unwind cast mess and remove phy_stat struct
Date: Wed, 14 Oct 2026 06:56:47 +0200	[thread overview]
Message-ID: <2026101434-deplored-unfocused-1be0@gregkh> (raw)
In-Reply-To: <20261013191503.152056-3-timo.joannin@gmail.com>

On Tue, Oct 13, 2026 at 09:15:03PM +0200, Timo Joannin wrote:
> Propagate the real struct type all the way through
> the call chain to remove redundant casts to and from u8 *.
> 
> Remove redundant phy_stat struct, along with the dead function
> prototype rtl8723b_query_rx_phy_status() which referenced it.
> 
> Signed-off-by: Timo Joannin <timo.joannin@gmail.com>
> ---
>  drivers/staging/rtl8723bs/hal/odm_HWConfig.c   |  5 +++++
>  .../staging/rtl8723bs/include/rtl8192c_recv.h  | 18 ------------------
>  .../staging/rtl8723bs/include/rtl8723b_recv.h  |  1 -
>  3 files changed, 5 insertions(+), 19 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/odm_HWConfig.c b/drivers/staging/rtl8723bs/hal/odm_HWConfig.c
> index fb3a19da5de3..c0a079003e73 100644
> --- a/drivers/staging/rtl8723bs/hal/odm_HWConfig.c
> +++ b/drivers/staging/rtl8723bs/hal/odm_HWConfig.c
> @@ -432,8 +432,13 @@ static void odm_Process_RSSIForDM(struct dm_odm_t *pDM_Odm,
>  }
>  
>  /*  Endianness before calling this API */
> +<<<<<<< HEAD
>  void odm_phy_status_query(struct dm_odm_t *dm_odm,
>  			  struct odm_phy_info *phy_info,
> +=======
> +void odm_phy_status_query(struct dm_odm_t *dm_odm,
> +			  struct odm_phy_info *phy_info,
> +>>>>>>> f52adf8 (staging: rtl8723bs: unwind cast mess and remove phy_stat struct)
>  			  struct rtl8723bs_phy_status_rpt *phy_status,
>  			  struct odm_packet_info *pkt_info)
>  {

I do not think you compiled this submission :(


      reply	other threads:[~2026-10-14  4:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-13 19:15 [PATCH v5 0/2] staging: rtl8723bs: clean up phy status structs and casts Timo Joannin
2026-10-13 19:15 ` [PATCH v5 1/2] staging: rtl8723bs: rename struct phy_status_rpt_8192cd_t to rtl8723bs_phy_status_rpt Timo Joannin
2026-10-13 19:15 ` [PATCH v5 2/2] staging: rtl8723bs: unwind cast mess and remove phy_stat struct Timo Joannin
2026-10-14  4:56   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026101434-deplored-unfocused-1be0@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=error27@gmail.com \
    --cc=guojy.bj@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=timo.joannin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®