From: Marcus Folkesson <marcus.folkesson@gmail.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Michael Hennerich <michael.hennerich@analog.com>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Andi Shyti <andi.shyti@kernel.org>,
Andy Shevchenko <andriy.shevchenko@intel.com>,
Bartosz Golaszewski <brgl@kernel.org>,
Peter Rosin <peda@lysator.liu.se>,
Peter Rosin <peda@lysator.liu.se>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Marcus Folkesson <marcus.folkesson@gmail.com>
Subject: [PATCH v13 2/8] i2c: mux: add idle_state property to i2c_mux_core
Date: Thu, 15 Oct 2026 13:01:49 +0200 [thread overview]
Message-ID: <20261015-i2c-mux-v13-2-778a12cfe93b@gmail.com> (raw)
In-Reply-To: <20261015-i2c-mux-v13-0-778a12cfe93b@gmail.com>
Muxes treat their channels differently when idle.
Let the mux core have this information to make it available for
internal use.
Possible idle states are:
- I2C_MUX_IDLE_AS_IS: Leave channels as is when idle
- I2C_MUX_IDLE_DISCONNECT: Disconnect channel (set HiZ when idle)
- I2C_MUX_IDLE_UNKNOWN: Unknown idle state
- <n>: Enable channel n (starting from 0) when idle"
Default value is set to I2C_MUX_IDLE_UNKNOWN.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
---
drivers/i2c/i2c-mux.c | 1 +
include/linux/i2c-mux.h | 57 +++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 58 insertions(+)
diff --git a/drivers/i2c/i2c-mux.c b/drivers/i2c/i2c-mux.c
index 53428098ddc7..94cc019b222f 100644
--- a/drivers/i2c/i2c-mux.c
+++ b/drivers/i2c/i2c-mux.c
@@ -248,6 +248,7 @@ struct i2c_mux_core *i2c_mux_alloc(struct i2c_adapter *parent,
muxc->select = select;
muxc->deselect = deselect;
muxc->max_adapters = max_adapters;
+ muxc->idle_state = I2C_MUX_IDLE_UNKNOWN;
return muxc;
}
diff --git a/include/linux/i2c-mux.h b/include/linux/i2c-mux.h
index 1784ac7afb11..17690f4f0dbe 100644
--- a/include/linux/i2c-mux.h
+++ b/include/linux/i2c-mux.h
@@ -14,6 +14,11 @@
#ifdef __KERNEL__
#include <linux/bitops.h>
+#include <linux/i2c.h>
+
+#define I2C_MUX_IDLE_AS_IS (-1)
+#define I2C_MUX_IDLE_DISCONNECT (-2)
+#define I2C_MUX_IDLE_UNKNOWN (-3)
struct i2c_mux_core {
struct i2c_adapter *parent;
@@ -22,6 +27,18 @@ struct i2c_mux_core {
unsigned int arbitrator:1;
unsigned int gate:1;
+ /*
+ * The mux state used by the driver when idle.
+ * Possible idle states are:
+ * - I2C_MUX_IDLE_AS_IS: Leave channels as is when idle
+ * - I2C_MUX_IDLE_DISCONNECT: Disconnect channel (set HiZ when idle)
+ * - I2C_MUX_IDLE_UNKNOWN: Unknown idle state
+ * - <n>: Enable channel n (starting from 0) when idle"
+ *
+ * Default value is set to I2C_MUX_IDLE_UNKNOWN.
+ */
+ int idle_state;
+
void *priv;
int (*select)(struct i2c_mux_core *, u32 chan_id);
@@ -38,6 +55,46 @@ struct i2c_mux_core *i2c_mux_alloc(struct i2c_adapter *parent,
int (*select)(struct i2c_mux_core *, u32),
int (*deselect)(struct i2c_mux_core *, u32));
+static inline int i2c_mux_set_idle_state(struct i2c_mux_core *muxc, int state)
+{
+ switch (state) {
+ case I2C_MUX_IDLE_AS_IS:
+ case I2C_MUX_IDLE_UNKNOWN:
+ for (int i = 0; i < muxc->num_adapters; i++) {
+ /*
+ * idle_state is incompatible with channels that have a
+ * different clock frequency than the parent adapter.
+ */
+ if (muxc->adapter[i]->clock_Hz != muxc->parent->clock_Hz)
+ return -EINVAL;
+ }
+ break;
+
+ case I2C_MUX_IDLE_DISCONNECT:
+ break;
+
+ default:
+ if (state < 0 || state >= muxc->num_adapters)
+ return -EINVAL;
+
+ /*
+ * idle_state cannot select a channel with a different clock
+ * frequency than the parent adapter.
+ */
+ if (muxc->adapter[state]->clock_Hz != muxc->parent->clock_Hz)
+ return -EINVAL;
+ break;
+ }
+
+ muxc->idle_state = state;
+ return 0;
+}
+
+static inline int i2c_mux_idle_state(struct i2c_mux_core *muxc)
+{
+ return muxc->idle_state;
+}
+
/* flags for i2c_mux_alloc */
#define I2C_MUX_LOCKED BIT(0)
#define I2C_MUX_ARBITRATOR BIT(1)
--
2.55.0
next prev parent reply other threads:[~2026-10-15 11:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 11:01 [PATCH v13 0/8] I2C Mux per channel bus speed Marcus Folkesson
2026-10-15 11:01 ` [PATCH v13 1/8] i2c: core: add callback to change bus frequency Marcus Folkesson
2026-10-15 11:01 ` Marcus Folkesson [this message]
2026-10-15 11:01 ` [PATCH v13 3/8] i2c: mux: add support for per channel " Marcus Folkesson
2026-10-15 11:01 ` [PATCH v13 4/8] i2c: davinci: calculate bus freq from Hz instead of kHz Marcus Folkesson
2026-10-15 11:01 ` [PATCH v13 5/8] i2c: davinci: add support for setting bus frequency Marcus Folkesson
2026-10-15 11:01 ` [PATCH v13 6/8] i2c: mux: ltc4306: set correct idle_state in i2c_mux_core Marcus Folkesson
2026-10-15 11:01 ` [PATCH v13 7/8] docs: i2c: i2c-topology: add section about bus speed Marcus Folkesson
2026-10-15 11:01 ` [PATCH v13 8/8] i2c: mux: pca954x: use idle state from i2c_mux_core Marcus Folkesson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261015-i2c-mux-v13-2-778a12cfe93b@gmail.com \
--to=marcus.folkesson@gmail.com \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=brgl@bgdev.pl \
--cc=brgl@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=peda@lysator.liu.se \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®