mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: George Neacsu via B4 Relay <devnull+geocausa.gmail.com@kernel.org>
To: Sergey Lebedev <lsa.uz@pm.me>,
	 Andre Gilerson <andre.gilerson@gmail.com>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
	 Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	Bryan O'Donoghue <bod@kernel.org>,
	 German Pablo Lindo <germanpapulindez@gmail.com>,
	 linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	 linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	 George Neacsu <geocausa@gmail.com>
Subject: [PATCH RFC 1/2] dt-bindings: media: sony,imx681: Allow a C-PHY bus
Date: Thu, 15 Oct 2026 22:25:09 +0100	[thread overview]
Message-ID: <20261015-imx681-x1e-v1-1-fd22f5f3b0c5@gmail.com> (raw)
In-Reply-To: <20261015-imx681-x1e-v1-0-fd22f5f3b0c5@gmail.com>

From: George Neacsu <geocausa@gmail.com>

On the Surface Pro 11 with a Snapdragon X Elite, the IMX681 reaches the
CAMSS CSIPHY over one MIPI C-PHY trio rather than over the two D-PHY
lanes of the Intel model. Let bus-type select C-PHY, and with it a single
data lane, keeping two D-PHY lanes as the default.

Assisted-by: Claude:claude-opus-5-5
Signed-off-by: George Neacsu <geocausa@gmail.com>
---
 .../devicetree/bindings/media/i2c/sony,imx681.yaml | 26 ++++++++++++++++++++--
 1 file changed, 24 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx681.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx681.yaml
index 62e7eae..51256a7 100644
--- a/Documentation/devicetree/bindings/media/i2c/sony,imx681.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/sony,imx681.yaml
@@ -14,8 +14,8 @@ description:
   The Sony IMX681 is a CMOS active pixel image sensor with a square pixel
   array, used as the user-facing camera on several Microsoft Surface devices.
   It operates from analog 2.8 V, digital 1.05 V and interface 1.8 V supplies,
-  is programmable over I2C, and outputs 10-bit Bayer data over a two-lane
-  MIPI CSI-2 D-PHY interface.
+  is programmable over I2C, and outputs 10-bit Bayer data over MIPI CSI-2,
+  either on two D-PHY lanes or on one C-PHY trio.
 
 allOf:
   - $ref: /schemas/media/video-interface-devices.yaml#
@@ -54,7 +54,14 @@ properties:
         unevaluatedProperties: false
 
         properties:
+          bus-type:
+            enum:
+              - 1 # MEDIA_BUS_TYPE_CSI2_CPHY
+              - 4 # MEDIA_BUS_TYPE_CSI2_DPHY
+            default: 4
+
           data-lanes:
+            minItems: 1
             items:
               - const: 1
               - const: 2
@@ -63,6 +70,21 @@ properties:
           - data-lanes
           - link-frequencies
 
+        if:
+          properties:
+            bus-type:
+              const: 1
+          required:
+            - bus-type
+        then:
+          properties:
+            data-lanes:
+              maxItems: 1
+        else:
+          properties:
+            data-lanes:
+              minItems: 2
+
     required:
       - endpoint
 

-- 
2.53.0



  reply	other threads:[~2026-10-15 21:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-15 21:25 [PATCH RFC 0/2] media: imx681: C-PHY for the Surface Pro 11 (Snapdragon) George Neacsu via B4 Relay
2026-10-15 21:25 ` George Neacsu via B4 Relay [this message]
2026-10-16 15:59   ` [PATCH RFC 1/2] dt-bindings: media: sony,imx681: Allow a C-PHY bus Bryan O'Donoghue
2026-10-16 16:08     ` George Neacsu
2026-10-15 21:25 ` [PATCH RFC 2/2] media: i2c: imx681: Add C-PHY support George Neacsu via B4 Relay
2026-10-16 15:54   ` Bryan O'Donoghue
2026-10-16 16:08     ` George Neacsu
2026-10-16 21:14       ` Sergey Lebedev
2026-10-16 22:25         ` George Neacsu
2026-10-16  7:00 ` [PATCH RFC 0/2] media: imx681: C-PHY for the Surface Pro 11 (Snapdragon) Sergey Lebedev
2026-10-16 14:55   ` George Neacsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261015-imx681-x1e-v1-1-fd22f5f3b0c5@gmail.com \
    --to=devnull+geocausa.gmail.com@kernel.org \
    --cc=andre.gilerson@gmail.com \
    --cc=bod@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geocausa@gmail.com \
    --cc=germanpapulindez@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=lsa.uz@pm.me \
    --cc=mchehab@kernel.org \
    --cc=robh@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®