From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85509542EEA for ; Thu, 15 Oct 2026 15:57:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792079874; cv=none; b=ZnKjq8s0rtr1q1Ko1LOCylr42yf5rvLJIHn4kMy35VNPSNRjm368VH+AUPh+4B7iIlSyMRsmbRJs7rRTIuTIKWCfhc4hFhto9MxJgw7Ko2BwLxqnxv9Wax5bqVWbMR/zjNAoEigaa/rwJVsAeta+JCCzJ6iuP8RUuqVbmGpF2S0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792079874; c=relaxed/simple; bh=zKSuXRI8aMna5pQ3QoL4QnTlDfII69cLtILjo3bnSvs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cu06TQ1YHAXW3UQChW3jXWdXBuYH41voHjlyROp1UDxE2wbUnFg1ZsQtZq5ZBIeIANZJE6iwIwO05CK8O6d304hMsCcMIolxfkNXx+EpUBbC5IX+dPSsJnwN3kMolp8IFH8Z8gnCUrZPIvG6r1JEFrTw/w4B6bQqe3HAk5oNDWE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=raspberrypi.com; spf=pass smtp.mailfrom=raspberrypi.com; dkim=pass (2048-bit key) header.d=raspberrypi.com header.i=@raspberrypi.com header.b=bdVv/nnT; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=raspberrypi.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=raspberrypi.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="bdVv/nnT" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-48b0584ad71so3276748f8f.0 for ; Thu, 15 Oct 2026 08:57:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1792079858; x=1792684658; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=w4qkq2Ot5KdEpoUe+1OGX5HpRdoidJ8DEnSvKe5Kbn0=; b=bdVv/nnT0TWRYBsu8qMDYMEMbhkUHp4+4SENDSp1jSD6BScBr4+OuOqbdwBz8eQmgp lW0Jn0vJZcFFMQQ9VhsA+Vwc9st6oFknMCDduXt+sZvs4FYSqPaGS5e5rypTdlR2cCG5 hlQtMn8cMlFGtA+LNmftZiwCzL8mk1xrAGbBIZwoF8Rg2A/ZEDnkUARfvJ5uU7wMTGoF uK5QcGIEgsccf9/VebidNitFzjNemMV/ZSYGXm/X+H1fSihMivWIoN12re9AGpOMDQcA AMLdrTybGfTWgOl7DqD9FOwumwGcFwnSZIwbKxKlzH6xzQ18nIMOBLpT915ixG8Qag6g UMpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792079858; x=1792684658; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=w4qkq2Ot5KdEpoUe+1OGX5HpRdoidJ8DEnSvKe5Kbn0=; b=EhI/++iMwkgS2C0uNaRp7wEJ5vn1/8/CLVegBY/UufpTwNYMqPO9ctG1yUdOntO3qx z9s0cAZgLXXBu2psVMaL4FMIFtLFbN9EoUscggh5MmABAvjgLf/wuh5XM37JRo03A8q9 M3LUOFM9sR7++Qliee5+3rPKL1/umdaScox4Nisl0nRCx4uWQjzDE0MhjEGPPFTDeevZ FgW3XM1D4H8LcWNbujbrlyv7OByyxrwA/L4eicTBTxUtON6MJkJCJaH5llnUz2PeztNE PyG8caGfSn6FqPskAMpBXtoSdlqKMeEN5D8SJUuQ8oUC2QepiC9ITrJNzrb/GK1c/Sf5 meTw== X-Forwarded-Encrypted: i=1; AKwUvByGB/p3yAgE1tYl9EgONlb/eAErxmWdpsYOn1ydZXeRdv9tpDSW1bYaw8xWFquMdH7cgqyuJeSsEsMNgIs=@vger.kernel.org X-Gm-Message-State: AFq9FYKxDIl0z0lEQJUqzsyUWud53Yur1aDrXbLl0TQZxXryL0+MIEtJ REleNjq+HwYKnTkTxlw1nu5b9trb2gfhNRrlu6qgMa7F093NZaoT+L3Xef5yZ4h58GRcAJnyQjX tPGsZgMs= X-Gm-Gg: AYBFou2NGah1+Jdj4YtCfOke+PzOM0R8/EIfqILHlfTEVaPDAEOyHYdg3vjioHcLsJj DExLGytrYhoUoWvfmOG4yIGzZOfiThxPFi7Y4nZqgjl1zorHX8nlMGrGpX+H7h9c09wkYn1yOxu eVK8XrMr9/7PlS5/t3oKVyX9IUt3u7sLxv+bOc+4CLI0e5sGwco2cJsDLjf/5KoGGR91uqjWW7E YS3kM6B0d9W20JhxsIsONv+rEQwnv94mpeG1C5ZIlnCGoQj+e1BKRylp2qM08CneRKqBAZzL5Ql PSoU752yLKaZKXt39Q+CCBjVmIefGHT5qS1mJ+VBoXre1uX3wa1EDYLjhGAhGJ3aeCYPppxVgPz x4JwLh+oS8ZhvPMZOfN2vGpkmvH0QWvGZf0q8ezaipVTW8HycpeP9Z+ux+FfD3oIFSmtw40kqjV NOfjkNWpNpyuJCLrdh6rsMpdZIY8u39l9NPH4SVMSN4zAPSZWuCseWOU6dDYKbLFmPamsCm31jB x8Il4Qv7Cxr0bIiJZ7NnEjN0eHCqcgnbykKm23GmBtTFqe6kw== X-Received: by 2002:a05:600c:c113:b0:4a1:985b:83a9 with SMTP id 5b1f17b1804b1-4a1985b87f5mr234591235e9.4.1792079858432; Thu, 15 Oct 2026 08:57:38 -0700 (PDT) Received: from [127.0.1.1] ([2a00:1098:3142:e::8]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-48de0aaaaebsm19877251f8f.14.2026.10.15.08.57.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Oct 2026 08:57:38 -0700 (PDT) From: Dave Stevenson Date: Thu, 15 Oct 2026 16:57:28 +0100 Subject: [PATCH v4 02/16] media: sony-starvis2: Reorder link frequencies to remove lookup Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261015-media-starvis2-v4-2-75fcdb4163f3@raspberrypi.com> References: <20261015-media-starvis2-v4-0-75fcdb4163f3@raspberrypi.com> In-Reply-To: <20261015-media-starvis2-v4-0-75fcdb4163f3@raspberrypi.com> To: Sakari Ailus , Jai Luthra , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Laurent Pinchart , Alexander Shiyan , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Dave Stevenson X-Mailer: b4 0.14.1 link_freqs_reg_value is table that just reverses the order of the link frequency enum. Reverse the order of the link frequencies so that the table is redundant, and remove it. Signed-off-by: Dave Stevenson --- drivers/media/i2c/sony-starvis2.c | 31 ++++++++++--------------------- 1 file changed, 10 insertions(+), 21 deletions(-) diff --git a/drivers/media/i2c/sony-starvis2.c b/drivers/media/i2c/sony-starvis2.c index b4733990d03a..3656658e18a4 100644 --- a/drivers/media/i2c/sony-starvis2.c +++ b/drivers/media/i2c/sony-starvis2.c @@ -186,25 +186,14 @@ enum starvis2_lanemode { /* Link frequency setup (DDR: lane rate = 2 x link freq) */ enum { - STARVIS2_LINK_FREQ_297MHZ, - STARVIS2_LINK_FREQ_360MHZ, - STARVIS2_LINK_FREQ_445MHZ, - STARVIS2_LINK_FREQ_594MHZ, - STARVIS2_LINK_FREQ_720MHZ, - STARVIS2_LINK_FREQ_891MHZ, - STARVIS2_LINK_FREQ_1039MHZ, - STARVIS2_LINK_FREQ_1188MHZ, -}; - -static const u8 link_freqs_reg_value[] = { - [STARVIS2_LINK_FREQ_297MHZ] = 0x07, - [STARVIS2_LINK_FREQ_360MHZ] = 0x06, - [STARVIS2_LINK_FREQ_445MHZ] = 0x05, - [STARVIS2_LINK_FREQ_594MHZ] = 0x04, - [STARVIS2_LINK_FREQ_720MHZ] = 0x03, - [STARVIS2_LINK_FREQ_891MHZ] = 0x02, - [STARVIS2_LINK_FREQ_1039MHZ] = 0x01, - [STARVIS2_LINK_FREQ_1188MHZ] = 0x00, + STARVIS2_LINK_FREQ_1188MHZ = 0x00, + STARVIS2_LINK_FREQ_1039MHZ = 0x01, + STARVIS2_LINK_FREQ_891MHZ = 0x02, + STARVIS2_LINK_FREQ_720MHZ = 0x03, + STARVIS2_LINK_FREQ_594MHZ = 0x04, + STARVIS2_LINK_FREQ_445MHZ = 0x05, + STARVIS2_LINK_FREQ_360MHZ = 0x06, + STARVIS2_LINK_FREQ_297MHZ = 0x07, }; static const u64 link_freqs[] = { @@ -913,7 +902,7 @@ static int starvis2_write_common(struct starvis2 *starvis2) cci_write(starvis2->cci, STARVIS2_REG_INCK_SEL, starvis2->inck_sel_val, &ret); cci_write(starvis2->cci, STARVIS2_REG_DATARATE_SEL, - link_freqs_reg_value[__ffs(starvis2->link_freq_bitmap)], + __fls(starvis2->link_freq_bitmap), &ret); cci_write(starvis2->cci, STARVIS2_REG_LANEMODE, starvis2->lane_mode, &ret); @@ -1175,7 +1164,7 @@ static int starvis2_init_controls(struct starvis2 *starvis2) { struct v4l2_ctrl_handler *ctrl_hdlr; const u32 hmax_4lane = - min_hmax_4lane[__ffs(starvis2->link_freq_bitmap)]; + min_hmax_4lane[__fls(starvis2->link_freq_bitmap)]; const u32 lane_scale = starvis2->lane_mode == STARVIS2_LANEMODE_2L ? 2 : 1; struct i2c_client *client = v4l2_get_subdevdata(&starvis2->sd); -- 2.34.1