From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8B2352FE49 for ; Thu, 15 Oct 2026 14:14:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792073644; cv=none; b=UF0OoBQP1b42YADLFQPqCCfgjsF6GUSvMBpDiaC6N82su7Hk7xavffLNwb4xh4sIYBYhNBPxx5kU0Z4YZVmQenG3ZvqX67lyq1zzNFBfcvb5pQQDIBuPX+TDBfse3QJQweST+LG5jqbg7V5GFAb6VoqPGuUxPU+IxZhzoKZBqjk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792073644; c=relaxed/simple; bh=GvoTZER1l4Zd2vB2uFIZBlq92s3/uzySsYs0js4SWZ4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pmUEB8y0vsTnh7UPIbImgthV6sdM2RP8PSLG37W5pvEsSqJcospogtOHgE4HEiLvBzshNMZ9uqYuqPNBUcGUu5M8G/OTrkTHBBIgbzLTcZtxXx0ebjXptu4Mcds46xtktnyck/2qtsoh7nOhK46WOnn/kVVJqJQewbkNalTdAQc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jQhAQMDP; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RBxSzIPO; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jQhAQMDP"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RBxSzIPO" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69F9kGUM2999177 for ; Thu, 15 Oct 2026 14:14:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= YCejaq5TguSpjsNlo6mtc06Dw7iUiiBR5d6oZHI/vU4=; b=jQhAQMDPnIc9U232 M8hZ+xRzGueVgsRIsWFb1V1JblW7GCesUJvW//+79dXi6L3Wi6XkVS28kFUbqj5Z vm81SwXU7zdNdk/uSr0ZEjowkoAOaKPDykMKWMgfCm3TNCoFCB0SWh3yr4XMpQ+C Oivy3Sk/R9KjJA5uYm+1pGh8dEPkMmPfO53+6Xr4ZGI/rTpwzXlqK/2P8+S9IlMT bm9pVMF1DmC0huN7f7N7yT9IvLXs+2eTQmPK2ceiYHFYHtnMC2NkrzjDMoMNuBEO Kyx9zF4kQL58MrrZYDjk0ea04IcSvini0mdPnNhXwFKK2bHu2rNCXVZCAbNHCKG6 gtAHxA== Received: from mail-oa1-f72.google.com (mail-oa1-f72.google.com [209.85.160.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hausm1bgk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 15 Oct 2026 14:14:01 +0000 (GMT) Received: by mail-oa1-f72.google.com with SMTP id 586e51a60fabf-482966c4f4fso7650fac.1 for ; Thu, 15 Oct 2026 07:14:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1792073641; x=1792678441; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=YCejaq5TguSpjsNlo6mtc06Dw7iUiiBR5d6oZHI/vU4=; b=RBxSzIPO7NpzskvDAYrvZ9aQv2orKQHPseKwjoe3VsmJaEh+cyc6ROMpHiKcyn7uGY C5nwoUsojZkBNmoKQtiOhY+1OhO3cnhprfBLm1j9z+cHzzzT7Tf5w0g3DQlcAGL7P/ob zKPLAV3BhZkz1bQ6vwhXvX3X3fkurc2yVhxrvBeraMWUXFV1PIgHghf6HCgKwxivNnWR W1bM3LHpvuAH3KNyZkOLvBkWFxVWcGpqTpl6rLbU7aPjIBGoGfmZHchZhfFhlAOQIMUk CT9gdbicTW9q0xtBGkWx3phCdvylvvie0gpDLp9WqZblueM7Evq9HcqOpTOErvc61LDU +ARw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792073641; x=1792678441; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=YCejaq5TguSpjsNlo6mtc06Dw7iUiiBR5d6oZHI/vU4=; b=d7vovrjZ46papOzQa8N4yO/8AGVOPSs3EXRKdOVBKtEffSTGm5OUCz2znzUq1wS4i3 6ixkW2MqahMOJ+tintDObYPfaOCdpIrECSUfBd3bAU4daXgKvtrG/xor1HOaRplDVEkF IzodRRZofXhwgIEHanHaBDfVKfDR0hTzLoJ/XwT4o0UxTgmkqMypSiRrxD7W2GGC4W9a NdksbVcQKNBU0PCon8a32wmXnImCHhErtva05vYohLIUXts2ET32q2o716wK7UUEp2rc s5tsQE1weHnX3wmQtnDbc3Ag17lBexWQuh7KO4vU7gULa8EddOOHVB6dE325vdNQ7A7v S62g== X-Forwarded-Encrypted: i=1; AKwUvBzNiQX5L3d0pvy5DPRLbyK00RTj3cQHOlBXLfSwM6Cn8yBw3UEebUkJCVsYTKUY/6KmhDVJUXIpDi9oHaU=@vger.kernel.org X-Gm-Message-State: AFq9FYIOqAH+h085Q8bC5pjPu2TvUYg3RXGLcFSTDwZAxtN1qo9yrWRC Y5Zbu+d55v30RUmk/PbPqL8lr4lVzoxeWE/6kOGsAjAJJDMEG29vJBV/QHIXBFdvtcb6HgxggrT 3gStpMm5L/3Xr3KSM/BYKCJ7EDMFfFaaQ1t6d8t/ILcMT8L5CiZsnDRB4j5QPvJAm31M= X-Gm-Gg: AYBFou0PFdDAHrvtFdlO5eFWwBHRBFNuGavmYwIG/Gfwp/LuN2aUgvnCV1Q5tSfIvbp JV04Ge/rHFy/Wp/77Y0WoaZS0VyuGuHkILTU2YFcL9MqQfS1A2hrzhH09y5FP2mxi8xVLk4IBPm negLcYzrCkh0MIIwMI6YvYtC72YCOwZDqyRAp1TJm4evRM2XhbT+idCg+3YEYRwl0wdrFIMeoZB aJOyG7DxyghE8tAuheCUx5I2pWhLEYVNaTaEUrG9x3Aq2XIq9EnJxx7+rfVkj4XGhQ/ycL86lR5 lbM4XKqAYA3FwY8biPNlLRPmvEg63qTSgA7D+O6gkaOBLQzrkehuVNoXFFxpaIxQCx3Ok03k0ca mnK5pBqQ3Y8JgzWo5jBB9Tn0qW7x1v5HI6h0= X-Received: by 2002:a05:6820:200b:b0:6e1:d8af:6e85 with SMTP id 006d021491bc7-7010e6e74d0mr91916eaf.24.1792073641037; Thu, 15 Oct 2026 07:14:01 -0700 (PDT) X-Received: by 2002:a05:6820:200b:b0:6e1:d8af:6e85 with SMTP id 006d021491bc7-7010e6e74d0mr91882eaf.24.1792073640553; Thu, 15 Oct 2026 07:14:00 -0700 (PDT) Received: from hu-mohs-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-6f47500ae30sm11366719eaf.1.2026.10.15.07.13.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Oct 2026 07:13:59 -0700 (PDT) From: Mohammad Rafi Shaik Date: Thu, 15 Oct 2026 19:43:10 +0530 Subject: [PATCH v1 2/4] ASoC: codecs: pm4125: Fix MBHC button threshold programming Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261015-pm4125_mbhc_support-v1-2-8bc1212db6f7@oss.qualcomm.com> References: <20261015-pm4125_mbhc_support-v1-0-8bc1212db6f7@oss.qualcomm.com> In-Reply-To: <20261015-pm4125_mbhc_support-v1-0-8bc1212db6f7@oss.qualcomm.com> To: Srinivas Kandagatla , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alexey Klimov , Jaroslav Kysela , Takashi Iwai Cc: linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mohammad Rafi Shaik X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1792073622; l=1480; i=mohammad.rafi.shaik@oss.qualcomm.com; s=20260424; h=from:subject:message-id; bh=GvoTZER1l4Zd2vB2uFIZBlq92s3/uzySsYs0js4SWZ4=; b=SuwLyy31Tf4fhGFsknvrz5rr5JXNsmK/T6njdP3TaN5oZd7+GYaZz82n+A2sih9Xk43S7RJjx EEh4lSHhH58BfhxRVaOhVdb5KeS18ZgbphBvqrltWtyl5qaXVQcIE1/ X-Developer-Key: i=mohammad.rafi.shaik@oss.qualcomm.com; a=ed25519; pk=KZedmYgMGYOzuTpLGv56tdrL+pTLDP8pdmfQ91xemiA= X-Proofpoint-GUID: 7wB7MJ43uYUF6dyjt8TEKsTgNi-hMbHx X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE1MDA1NiBTYWx0ZWRfXwu3nH1Pz6d8U Of1lcvQFqd+29STZZWPohQz92wX3EPsFHyVQSW7zta4EOvWrOKnQH1ODdt9bDUz6DSx/A4psLCR 5dZuM3mUf+o5liROOKNZ8RTkkPkO+UM0NOIJl4ajqZPcQDiPHZ5m8R2YRxDhft21cxXBs2AaelI HGkxK0BsFU1Jd9dFibzq3ZQ4VQjG/RNKqkaEgr0usCDysS6drOUky3RsoRN+LvQwKrAP3NNQaL6 1EJcypJLC6YAAeYZtYzRR+ZUCRjJhvRXrEt/Dg2yOrBPVxdQLX3wol7kOUskTsPxdgHlaY06p9X rs5Y3TRUCz8J8GaK9vH8V3vO/R77aG9BoyfAdqN57/n9/VywEuzLSO9RADxqZ4nmkNqX+ftliqG ryHAfVfxhHsGqFFY0YL9rLN/ooDcEoj/57eulwrpDj3CirONVRSiGs4GATrEOwt+Hz52TtDfEfp L4oxfVxvxku6Mv8dM6g== X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE1MDA1NiBTYWx0ZWRfXwX3Uc0YF0fPO hLg/55e3vpWA3GJNRtAPDsbv2D8Bo95g+efOvfPBXzMu4/mMjxiME2TToDbLEwWqVvv1lAYSNZD zhNYiOLa94US/oJGnPoiaXDepeWd9qY= X-Authority-Analysis: v=2.4 cv=Eb5d0/mC c=1 sm=1 tr=0 ts=6ad0dfaa cx=c_pps a=Z3eh007fzM5o9awBa1HkYQ==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=d5X6TG9WFUAVuZc9_kYA:9 a=QEXdDO2ut3YA:10 a=eBU8X_Hb5SQ8N-bgNfv4:22 X-Proofpoint-ORIG-GUID: 7wB7MJ43uYUF6dyjt8TEKsTgNi-hMbHx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-14_01,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 phishscore=0 bulkscore=0 priorityscore=1501 clxscore=1015 lowpriorityscore=0 adultscore=0 malwarescore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610080000 definitions=main-2610150056 pm4125_mbhc_program_btn_thr() pre-shifts the computed threshold by two bits before handing it to snd_soc_component_write_field(). That helper already shifts the value by the number of trailing zeroes of the mask, so with PM4125_ANA_MBHC_BTN0_THRESHOLD_MASK being GENMASK(7, 2) the value gets shifted twice. The two most significant bits of the threshold are shifted out past the mask and the remaining bits land four times too high, so every button voltage is programmed wrong and button presses on a headset are either missed or reported as the wrong button. Pass the unshifted value and let the helper place it in the field. Fixes: 8ad529484937 ("ASoC: codecs: add new pm4125 audio codec driver") Assisted-by: Claude Opus 5 Signed-off-by: Mohammad Rafi Shaik --- sound/soc/codecs/pm4125.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/pm4125.c b/sound/soc/codecs/pm4125.c index 674a2fbc4..923318c78 100644 --- a/sound/soc/codecs/pm4125.c +++ b/sound/soc/codecs/pm4125.c @@ -981,7 +981,7 @@ static void pm4125_mbhc_program_btn_thr(struct snd_soc_component *component, for (i = 0; i < num_btn; i++) { vth = ((btn_high[i] * 2) / 25) & 0x3F; snd_soc_component_write_field(component, PM4125_ANA_MBHC_BTN0_ZDET_VREF1 + i, - PM4125_ANA_MBHC_BTN0_THRESHOLD_MASK, vth << 2); + PM4125_ANA_MBHC_BTN0_THRESHOLD_MASK, vth); } } -- 2.34.1