From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9ACEE379960 for ; Thu, 15 Oct 2026 14:46:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792075607; cv=none; b=McCsnGekNtYzYrWRoKmRRKd/dHYgikAkWDjyTGC2l6fHS2kOUJOxcVrTReaMGIcs12Zlz/YfxupqoBCs8NUt0NLqYnmZu5xR2ca8jr8hPrgv9C50p8x0RE/xB8j7wFnY+dWCfqhjEb/0xrrAOj8GoKnoDWqMSrtYobzhupuE1g8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792075607; c=relaxed/simple; bh=NHgIRIYeSxxBM4Z2O/FYMoXHETZQ8rwvjZE3GOfWUQc=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=OlbjhPc1Fczb4haYgoOjUFSCCoY5prKN3VmqeHyQ9Lf2ySIuO8JfAFnTDQysxK0C2f80Stw7jCnINVYuLQaR7z4HTbifB4vpxKE8rwjSjAFnn43WMg5bOXKWnhgrFzrie8KOxCkyysFWl52Ee265TN+oTu2HGA1CNng8FiLU5iM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=EqmVQKLG; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FfzU72e1; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="EqmVQKLG"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FfzU72e1" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69F9jfR21955737 for ; Thu, 15 Oct 2026 14:46:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=u/nlLAyrIY971jI97tgUiI dOKUIdrmUXPoG94AIgOqI=; b=EqmVQKLG6kmBa3f0f+xOOJQCVN3EpYtnoes67G oiup/ZJJhnXDxfxd4OqlkzX0k79nVGrC1Fr7F7VvtfBbyhbS5HtKHq/7xgMnDejk P2k9Ya9ao0hl+z8xOwR+panrEL5/tMh6D5GgczradBvJAJPD8Q8Z7AOBkI9sd2sR XOcDFj54Mi0WTI4PU0MDRqpJZ6wwvJeej5itid90GhT0njk3qEp+sJJD/JPncXQH 5saLnS22rO7/WbrtyHSwFVXqNeoFENL1dJSyA59/4fPzzYkJ5ceAwo28FQqcM3OA jv2O+8ut3eORaJWLFAzhgS6KPX88+ani+Me7Z+mlR3P++J3Q== Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hakdeuesy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 15 Oct 2026 14:46:45 +0000 (GMT) Received: by mail-vk1-f200.google.com with SMTP id 71dfb90a1353d-5e3ef255ffeso966691e0c.0 for ; Thu, 15 Oct 2026 07:46:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1792075605; x=1792680405; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:content-type:mime-version :message-id:date:subject:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=u/nlLAyrIY971jI97tgUiIdOKUIdrmUXPoG94AIgOqI=; b=FfzU72e1K+60r9rkq9PYarah3lDNB7z1ymuxU5DQzsaWsr7/pgncPQ5Gv0s+rmk1n1 DtxuHHi5NvBFQcrRTSmdavN3Mi5rQ0+29DDE+OYIVigeyglUXXOt+yk/oHWClsbpzgMF I52ft4U06TOC4nDZ1A53BKb4rtmZv2d2VpchhBZfTjx5yz0gTkASpXEzowwrrNFV31BU o/LpbAE28w4wnwX/uJWZ+kfz9Y1VoaEVXmjhB17VnqUboJjY7f/895tSr3VuVyutyTOi 6gdi7pX03yLqW7SwKo6LUKyuJid4TMN+lf+9yl1aH8xgtlQWVRxYGMpLBQtW0sdlLNiV Lrfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792075605; x=1792680405; h=cc:to:content-transfer-encoding:content-type:mime-version :message-id:date:subject:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=u/nlLAyrIY971jI97tgUiIdOKUIdrmUXPoG94AIgOqI=; b=L/itpnblDQi8Xt3CKzwu50hrYD7wM3WtN5Ky0Nueu0Ixx5bO98lPOjEW2MKuky+ReU ai1aM96qk0eyR8+mP5Q238UWseDwLu5cps0unhXBwelRafmhEtvUegxl9xZ4RIoqrlBE 72negnAh+EndqN+/QwPfXF/FrWs4XZdljlzr8bgJDtMFTNqkymn1wwUecJc92mMDxreK Tf+fFBHCtrVdvwps3eTWYW/5oZCemmnOZoxAAtiiv5QUy5lND+nobrGiXaJhQ4oNB+gr nDfY6mTX3epLJ5NmCbwH0YBvJaahJ1U9LCnLmugIh1p1CJMxvyEpRYovRcbipthl2ium vt0Q== X-Forwarded-Encrypted: i=1; AKwUvBy8X1szTFjMhr8kFy8h5piNLmmSMyt0Q/jpuhXh9hTqpyzreL8dBh5z9KTOA7BAyR3Z1wMhbPSnwtRAo3Y=@vger.kernel.org X-Gm-Message-State: AFq9FYI2I3JEzDZjxeEXnG6xaJ3HoNeEmFvKy9To/5AjEMzc13zoQvJW Aemh3Hgf0UwIwFyG5e36cLUDsNCsLH/Xc5qQw4vFvBGmeHCG0jNRldG8Ns4uTbNost6vThmLlhO waAw+Xc3J0lmaLxMWYr+vT6ssypDGUTsk3SQC6w04WOhu/MMaA/CHp5/nwuAJAIV/tJ0= X-Gm-Gg: AYBFou2tFb22P/r7g6/dqoPu9iC64CPd4SQ92qL7tifxjTNtHAP4Uhi22iYB/C/y73M MgH/sVMP4ZFoLGSAhpEcTynRuh+m8vRXJbaMyMeKyVeMOIBvXDDoq8psl7LNS+yC9wirs7oKmHB 8D3+y4ip3Ae5/4BgfjjG1RSzGPhY7ljuE/DNe4383OjGuVjMSNI56MzdF5g3Cdk59Bg2GfdqbIw WoZLvwvyD2+Ayy2s3jvQ2NG9zBr6ZKo8bHYdiTOesInGKiTIY7AaCeYLmeZuWiQjT+/+RtyBIa4 489LhtI87a9V9gUg+Vw7xCht+dwOrvycFWyRE3TxL2wg4c8nB96iCX83QAXYxrIB8tuD7ZHrI45 w45+wTVG7W1AYWLDUTiRrWGeO14Gr X-Received: by 2002:a05:6122:1828:b0:5c7:a9ee:dcfb with SMTP id 71dfb90a1353d-5e91f46ca9amr6094210e0c.5.1792075604389; Thu, 15 Oct 2026 07:46:44 -0700 (PDT) X-Received: by 2002:a05:6122:1828:b0:5c7:a9ee:dcfb with SMTP id 71dfb90a1353d-5e91f46ca9amr6094164e0c.5.1792075603775; Thu, 15 Oct 2026 07:46:43 -0700 (PDT) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:8916:7b9b:97a2:6c96]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a1bd9b8ebdsm86840625e9.10.2026.10.15.07.46.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Oct 2026 07:46:41 -0700 (PDT) From: Bartosz Golaszewski Subject: [PATCH 0/3] driver core: fix unbalanced reference counting for software nodes Date: Thu, 15 Oct 2026 16:46:21 +0200 Message-Id: <20261015-swnode-dev-notify-balance-v1-0-9e7537bd2869@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAD3n0GoC/x3MQQqDMBBG4avIrB0wogF7ldJFNH90QCYlEW0R7 25w+S3eOykjCTK9qpMSdskStcDUFU2L0xksvpjaprWmMT3nQ6MHe+yscZPw59GtTicwbOhtGAf X2YFK/00I8nve78913cqYpxFrAAAA X-Change-ID: 20261015-swnode-dev-notify-balance-e6f56fb9a469 To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Johan Hovold , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Eduardo Ruiz Duarte , Bartosz Golaszewski Cc: driver-core@lists.linux.dev, linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , linux-acpi@vger.kernel.org, Bartosz Golaszewski , stable@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1334; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=NHgIRIYeSxxBM4Z2O/FYMoXHETZQ8rwvjZE3GOfWUQc=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBq0OdGNQea/ZaQSE8NoGK5ssTDV3i6Yf8dWQp6K pyopKVXJwiJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCatDnRgAKCRAFnS7L/zaE w6x3D/4uzSSogfkEUqLZ2YYdjMOaAL7tIC5eATXPw7a/Wemsnjuwdv5Su5A9tLJXIKi5WY74Xeg 95BMcLZR8h0F3aLL31c103khzaSKRvRqUo5EZHjjxVNiOwwu32B0khfs4gnD+ikiV3Tw5m0k2KW pzktdOuPz00z8akz6CAhuU5DwkFPIZXFeGEekgGZ2jJaF2oTnTUWQ7kod3JMbDCCsWScirMNWx8 a9mCXPuZlgqAPvYZxS1rrBPkbjiXW5qbxbwz0k3JfmSIMi9dtunW4Aye5RDFDeXMVOAiCN4BQzT ciTcVp8j33yP6bT7XQpNvheuBYSiXtK2TDepKwXktsZxGa5e6rVNUnanFRogVpG1e1p7TqWle3P KhA6YfLPiLqRDSBnpAJeMeYMf8QjyBXSpLCawPbyHXBxxKgu55IEy7dlgGLqhtmCrb2DIDH9DhO vYyBtg1sHWDFvDxR+5nNYCFf2g3WepcqVybJAyl3mXwBlV3zmIyMjF6yAeYC8Uc0x9yXBK+XbAu /qf6NDR40SfsL4mJY51ylo1f7g6s+RHpGHY/CMa9ssAxYFeDKsv4rIZTw72LLXeRsICx/65Durt /pX6f/rfQxFr7614teLoIrqaSRA6FcCgjpAP3OAkBgAHsEL2hb+luTtDxCwItitOzMpZeTKC65Y zxwsOX1iKlAMNNw== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Authority-Analysis: v=2.4 cv=OdENnRTY c=1 sm=1 tr=0 ts=6ad0e755 cx=c_pps a=wuOIiItHwq1biOnFUQQHKA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=kTkK-H-Q3wn9DOHkRvoA:9 a=QEXdDO2ut3YA:10 a=XD7yVLdPMpWraOa8Un9W:22 X-Proofpoint-ORIG-GUID: 474j8yuU8S0lVdAl1CCZMFQkT7KnHUsE X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE1MDA1OCBTYWx0ZWRfX2YO6MFVATRwB 4Kg3mfndKwlXvv6tbcVlOMWN952iwki9BhWvl7F4TjpttDd+iMk16yKrZtfWZJAA4E8jr/QZA4j 0yOUZYJezv45xMP9FBK1ipxo0287o+pZalnfcT28HCkCpS05ziS2V7SVaX4D5ByvOmRILdxlZ35 Gvqg4++mutH6kTQohFWHtrKAGTtSTP4ndNH7PwH8Q336zFluyWtlerwiwczhiO2+fDHCmwQmjUW RepDeP2uWEUJTbWtNjIuAEuts2A/Q91X72Z2IMV/OJtNyHXTWcEplwUSRmTxiWbjVi/E3idryMW Jr8mmjIKPHqL8EdpsEPeRHfb0i3UqWgEsEOZJpRe0g87oIznGuuMj5cCWHvULQaLrRlsxZ2emhK YVzvgjiIpBx7V9iZaENwnUJJU4nQRJnX3tHUSknB1BJ10wRuZ8PmaR0ocyoJbXYpvw+edQaXJOp Ujsj88umw0WzSj5YOaA== X-Proofpoint-GUID: 474j8yuU8S0lVdAl1CCZMFQkT7KnHUsE X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE1MDA1OCBTYWx0ZWRfXwT2Zf3Dm98QV AubMM3C8p/E9eKM5yrLPwQvwVScK6WmJNGSdGqakiLetKWhAvjec4vM7W1wIO2mr2CNlRWRwnpQ +HqCu8AqObZxarxUTEyKHikIrTxvlXI= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-14_01,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 spamscore=0 impostorscore=0 phishscore=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 malwarescore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610080000 definitions=main-2610150058 Eduardo reported an issue with reference underflow when setting a software node with set_secondary_fwnode() and then repeatedly destroying and re-creating a device. This is caused by the fact that software_node_notify() takes a reference to the software node which is unconditionally dropped in software_node_notify_remove(). However the software node can be assigned after device_add() so the latter should only do it if it was bumped by the former. This series proposes a fix in driver core. The first two patches extend the device flag API with a new accessor and value. The third is the actual fix in swnode.c and should be backported to stable (along the first two as dependencies). Signed-off-by: Bartosz Golaszewski --- Bartosz Golaszewski (3): driver core: provide a test-and-clear device flag accessor driver core: provide new device flag - DEV_FLAG_SWNODE_NOTIFIER software node: fix unbalanced reference counting drivers/base/swnode.c | 5 ++++- include/linux/device.h | 10 ++++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) --- base-commit: d419d682257d813f6cb7a28e42b35d0edf4ad038 change-id: 20261015-swnode-dev-notify-balance-e6f56fb9a469 Best regards, -- Bartosz Golaszewski