mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: wangqk1 <wangqk1@xiaopeng.com>
To: peterz@infradead.org
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com,
	juri.lelli@redhat.com, vincent.guittot@linaro.org,
	bigeasy@linutronix.de, clrkwllms@kernel.org, rostedt@goodmis.org,
	linux-rt-devel@lists.linux.dev, xiedl3@xiaopeng.com
Subject: Re: [RFC 1/1] sched/rt: Avoid RTO push to stopped CPUs during shutdown
Date: Thu, 15 Oct 2026 09:40:05 +0800	[thread overview]
Message-ID: <20261015014005.8885-1-wangqk1@xiaopeng.com> (raw)
In-Reply-To: <20261013120302.GJ2009045@noisy.programming.kicks-ass.net>

On Tue, Oct 13, 2026 at 02:03:02PM +0200, Peter Zijlstra wrote:
> This is horrific; lets not do this. The bug really is at the place where
> you randomly and without warning take CPUs down. We're not adding random
> hacks for things like that.

Understood, thanks for the quick feedback. I am dropping this patch.

One note on the trigger: this was seen on the normal poweroff path, not
on panic or crash. On arm64, machine_power_off() calls smp_send_stop()
before do_kernel_power_off(), so every orderly shutdown stops secondary
CPUs without hotplug teardown, and a CPU still running the rto push
irq_work can then pick a stale rto_mask bit.

I agree the fix belongs in the path that takes the CPUs down, and that
path will need to account for the rto overload state. If I find a viable
way to do that, I will bring it up again. Happy to test or review
anything in that area.

Thanks,
wangqk1

      reply	other threads:[~2026-10-15  1:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-13  3:01 [RFC 0/1] " wangqk1
2026-10-13  3:01 ` [RFC 1/1] " wangqk1
2026-10-13 12:03   ` Peter Zijlstra
2026-10-15  1:40     ` wangqk1 [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261015014005.8885-1-wangqk1@xiaopeng.com \
    --to=wangqk1@xiaopeng.com \
    --cc=bigeasy@linutronix.de \
    --cc=clrkwllms@kernel.org \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-devel@lists.linux.dev \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=vincent.guittot@linaro.org \
    --cc=xiedl3@xiaopeng.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®