From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3A10279DC3 for ; Thu, 15 Oct 2026 01:49:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792028995; cv=none; b=iGF60j5HjnW9A+3BNzxpa8GE6KT+hJUtfcKHHTdtdxokXEeJbhJ9i4qfxLZsmBuTBCj26SqQ+hrPj9B1etJ9o1I9l63yK9evFk/tn2v43t+Zi+z9iSC5YG1QXAgHazuPFxc6+U9hGI5CVD9e6rl6zaJTz/iIl7TX5CTpVFYcjMM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792028995; c=relaxed/simple; bh=AsRVQlxF+563JjvP+sFHOx3JXC5esmyVVxsSsw++eA0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jhZf5jaOOyONNMjIu0jUN1DMzuyhDWehf62jQr7h6N0ahGbO/CgeuIpL6YUjGkNzOWAO6RV63sN6DBiRMF04Eh1catxDRo2a7jST9Yfs0cWmyzAJzFlWqDuNjtnwe0PHvwkhGPmp1qwGdZi1hQAPq0x8Zo7NNr372+tyLb0so5Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DkryIyzC; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DkryIyzC" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2e812e2b31bso26937275ad.3 for ; Wed, 14 Oct 2026 18:49:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792028993; x=1792633793; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=X8N5wvVyB4OZfrBnjP1FYFZJGH9J4CpZz0KjhM2upoM=; b=DkryIyzC+tv082WDmMQVrsewKeXzE+KPZ/8Rtaq55xHkoolmBLF6D8VQkhpDkg0yaX 9urOZ0d86+xDQyQF/bsvafRWucB57vuCF+QHRewLl4IP8cLnLRERa+kOXa9DSDQ08K/g 0CpIVlIGoGgbAx+ewQGE+reu+FSmknkzmwtzyzB7IfbRDhNg+7krNbddFWa/xyuGONXO E6LmGZrVUH4+BF9TSKjblghioSp0R0qxut2ay0ZEZJxf6rnYmLBlCMBkemVrgyxLeKZc vNQQPYkuuwhBZKo/kOP5Vlr+qV95A/Sku2JGzWTN720DL0We0k8+JiIvEkWbgg++3lkw uHZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792028993; x=1792633793; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=X8N5wvVyB4OZfrBnjP1FYFZJGH9J4CpZz0KjhM2upoM=; b=FPD853z8X7k8Deb+hCYDLxXq2RooRaK5FGVbOMS7YBALeOlVDDHkBhyKCJToSeXKpI U8K9lXj+0HH66h8drWPTdp1TCiqTCNWs3yU+Ym6u5ym0VdJcaKbJJaN7WvSqtj/fT9Cw svvaMcvOR0Y8J8bV0z4YZXP6LMh2Z/cot0fa4hpe+a8lwQLSyhzH+vIRIVSJowfx6g0Y dueWlA2jnA6RkdVBq/9nQEgesT47j5VXdndXY5bn6ENfMN1IfxL+lCk+76C7KgaRi4x4 4mSCoOs/iGBiZYMHUgW6vBZ9WOzZxPxieARzP8d4rfQD8s/hYaHMvz9GNyc+VZy4j0+6 CNCQ== X-Forwarded-Encrypted: i=1; AKwUvBwAX3g4FGIceJoGM6HQfGAIBIHk4fHNKStUR3jZ+CbsMSa18CGzsw6oDUd02F7ElvT7JZUq7xDPm9BKzpE=@vger.kernel.org X-Gm-Message-State: AFq9FYJpxk4HLpkPYZqPXzkYBYWLiCRZCzKILCbBrcIe05M9Vm8v3MM4 R2Fhz2oXZspvGcb2KnYSDb6Fezj58LcEv35z18/4nQXVf5hE3Pl8DQI3 X-Gm-Gg: AYBFou3ot4kl5jEN/lhr4tEdv78OAWdz8Lr8mrw9o/vnzerccuPcfHgkJCCS/M72qm/ 3j2FVN+XqeSMv5HHGAIYP4sih+t49NRV6ajnbN2li5XkIvjtS/eHX2rsX/W0zCJN5ImlIMFqVyy KyifiMF2V0q6KEiplXjwo7ivxiIRrnjCCPB+MNVd5bxMgXiSpCidLrhogxhoWnFfYkvkRmtWGA+ dl9FsAHhucRn4r1A8R/ns9SQ2IioPl4TwqMeksknVl7SgQ3PCWwMyq5RAJkqBS1RX8CRqJyXfIf Ts9n51kZjubckVt/b+OTjOS2yi3zEavXCvII3CX8FT+ttwxLr0eDUJIps3lrFDKTVFZseSjnLLq QCIQgnOyAOraIrVvf9lyqXSRA8mDk8pSkUiQVjdxu4xWUbohd0QWc6niwLMFaGaj1XTaQC5G08b HPmj30hHQ2JrdHIJowWXTOvTCWK1ab1fRtXKUSt79M43S670MGYVcnQaIHaYFThJob2jReswfOC koHUYsYnE8KJLCUyYg5KzWGyOGxiWnLWDmBzYMJpPflUD8KOrP5NpsuyCQvJba0UT9IlWpaNzYk GfHIgsQKacWr7A== X-Received: by 2002:a17:902:ef4f:b0:2e5:c563:c0dc with SMTP id d9443c01a7336-2e842cdb0f8mr158108285ad.42.1792028993312; Wed, 14 Oct 2026 18:49:53 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2e8422b8cc1sm73202995ad.54.2026.10.14.18.49.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2026 18:49:52 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Cc: Kees Cook , Syed Saba Kareem , wangdicheng , Chris Bainbridge , Linus Walleij , Charles Keepax , Neo Chang , Krzysztof Kozlowski , u.kleine-koenig@baylibre.com, Pengpeng Hou , Cristian Ciocaltea , Hemanth Selam , Md Shofiqul Islam , Bjorn Helgaas , Zain Aboobacker , Sang-Heon Jeon , Bo Shen , Vinod Koul , linux-sound@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com, linuxppc-dev@lists.ozlabs.org, imx@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 21/25] ASoC: renesas: msiof: Remove redundant period constraint Date: Thu, 15 Oct 2026 08:43:20 +0700 Message-ID: <20261015014324.5569-22-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261015014324.5569-1-phucduc.bui@gmail.com> References: <20261015014324.5569-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc snd_pcm_hw_constraint_integer() is already called by snd_dmaengine_pcm_open(). Calling it again in msiof_open() is unnecessary, as the constraint is already applied and the second call returns 0. Remove the redundant constraint call. Signed-off-by: bui duc phuc --- Changes in v2: - Remove redundant integer constraints already applied by snd_dmaengine_pcm_open(). sound/soc/renesas/rcar/msiof.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/sound/soc/renesas/rcar/msiof.c b/sound/soc/renesas/rcar/msiof.c index 128543fc4fc9..11a6f22ec0ad 100644 --- a/sound/soc/renesas/rcar/msiof.c +++ b/sound/soc/renesas/rcar/msiof.c @@ -419,18 +419,14 @@ static int msiof_open(struct snd_soc_component *component, return PTR_ERR(chan); ret = snd_dmaengine_pcm_open(substream, chan); - if (ret < 0) - goto open_err_dma; - - snd_soc_set_runtime_hwparams(substream, &msiof_pcm_hardware); - - ret = snd_pcm_hw_constraint_integer(substream->runtime, SNDRV_PCM_HW_PARAM_PERIODS); - -open_err_dma: - if (ret < 0) + if (ret < 0) { dma_release_channel(chan); + return ret; + } - return ret; + snd_soc_set_runtime_hwparams(substream, &msiof_pcm_hardware); + + return 0; } static int msiof_close(struct snd_soc_component *component, -- 2.43.0