From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 403B32C0298 for ; Thu, 15 Oct 2026 01:45:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792028747; cv=none; b=ivG17rMJw8ZHFwzHxXKe9kIkdKZkgQERnuBFZ172SpoKnlEyppX9rQ2YWrhhO58uIfrMNi24U2ZhruLOEaWNe/FgX1WiPniWOuk8DVCaJsnVF+CeJQ9tdJgB1/t/AnD1bE5sJVBgTil08SZ6MXv7AuTuuP3mXCcJyg6ClOXBp24= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792028747; c=relaxed/simple; bh=Qod46+lJKzs2otcbuUwfMMYT23zkjG47R07TZKGmCbM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tcbKcNN8EvK8jnJxaqy8NbW7DAfdUmCE0t4TveX0O4I8vXFAuJ5mC0QmB3VDEO+DAPNLiZG+N2qdoRWPLbRklnGHnde+vN0Y/ehJYZxm8+cmLBmW35Fgix6MgmXeA+wggjvjpno6xdSGAV6pQWTRLIcolECc8oOGryz/tDCfQUI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=X1Olehx5; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="X1Olehx5" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2e7e742a2c7so32165945ad.0 for ; Wed, 14 Oct 2026 18:45:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792028745; x=1792633545; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/n4smlFZhMXZJQElrsN5vEKX5hOiO4PseO+WVYrBqMc=; b=X1Olehx5rFnJlLHc38CfGpk5Eyk6Bcf0neVNP4ZA7BumYKwUEHsERkFiMZAaUyHJTf VNt1xzNrdiNxI5ffsbsw1Uc8nEU6BbYyKqUIA2jIdh6cNuZpWLIGbmhh42IEB1F51Gx3 iAp8if6ZM4sf5kX8s1njowabmCEVByw1aqpeBpQLZXevBxz6aN3dPTcToz26KhN5KbwY 2CdGN87l7pczkwglO3ZEzBfU2Lqiou8B+BOu/frUdBmrSrrupEPHhGydVG1eZIQLxnzn 93BHirP5W2C4fb7WKjuglEYEj6OwtnJPHFqDu3wVmNjbsoE3zp7rizuwXbwPa3xihqeC 4oQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792028746; x=1792633546; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=/n4smlFZhMXZJQElrsN5vEKX5hOiO4PseO+WVYrBqMc=; b=Ok6BB2yZzweSnIuQpMlF3tGa7ZG7DGyKuAQhyCi23mztw4rGSVBwOUJHuIMYx7x3Hw qUFL+CXdi8cPVFRkR3YrWorAnAluLwK3xDWjSW5zR4ea8hYkERp9lwSI/cCJFsMHUo0e Ve+0vawTzUVhddKt4/qhIqDPIIiNaCtWEqKSMSbYNVPkzltfv2Otcdnj9hQfBIC/1bhl 9fXVJU45Qq19Ctkm2s3a7Abw4aKPvNAiaBOwmGfWgaLnXJ/7mej4IbMdJ4p5A2CUg/IZ GUvfPmjaq9+iYEAZS2/fKXlqxknjGGf4sMhDd2r+4qYSyfZI6okHuPfXU4Zed/NacHbN MBAA== X-Forwarded-Encrypted: i=1; AKwUvBxrkyHuZesPuvwZ/z9F/g9k8fkzn0KbtIUWxYyRmBr8mnzMRy9ss8yEgrokZOpHWOk6oOQ6/lCxWgziydc=@vger.kernel.org X-Gm-Message-State: AFq9FYK45aBvTjQU05KQ5aHjG6Q/lVM8KqrYWnjcHnMqdEK6ePySmDth 6HvyCjdY+lhIBXmB6iXrHDKZhFvDa8Lwqyj9T3xBZdYhuujXKiDZSRIB X-Gm-Gg: AYBFou1cA67CaBNlqw3/SKACidHQngCtmiyBQuZY91CejochmMef9SLNY/oPIUjTczA SxTmMMipmUZWb9WBteaQMFPKjrPPiN5YgFXNbyeHDqdcFeKkgg6z4NXOmfIc+V8IRJII72X+mJo KaNCpKLslhbz4UsysIdJJvKcLNZZM/ASXtCugnm81/tOWKXuz54FraP3ZV7G9DgA5F/bbQgpyZG s4jCLkpozbogVIcaltkragkopbcvSjEr8BN9aQy7QDK9mCf36dD8FunC4H1guPr+k0w4Lu7loe3 yiN9EK7j715K+zS4IYId2kvZ91e1q0PHVR5M8mXRP6HzS1MVxGxzka6WLKXjEeizuzHDkbzT+jm TN62Hcel40wuED+J98byZW40dSPGYAs08n3FWgNsCTKEFR9OeNTP2JYPcusNM5RXwEYyc4ffp9K fnp0oRWFA62wctvkJSJqkklU7sCgiI3F3mL4Yid9MXo+77FQwnwcjdZsA4aKebBDZWMxus7rm58 5PufPuvTwb5ikN2nwJwEWnTQ3bGw3uJzV3Ob0H7Mm+tMQ2CHKu51wsnFT7hCy+cWfSqM9v5ZRdD 1JN1OsxPIgZBIw== X-Received: by 2002:a17:903:1b70:b0:2e6:e9a:eb48 with SMTP id d9443c01a7336-2e842f2d257mr110492185ad.41.1792028745495; Wed, 14 Oct 2026 18:45:45 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2e8422b8cc1sm73202995ad.54.2026.10.14.18.45.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2026 18:45:45 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Cc: Kees Cook , Syed Saba Kareem , wangdicheng , Chris Bainbridge , Linus Walleij , Charles Keepax , Neo Chang , Krzysztof Kozlowski , u.kleine-koenig@baylibre.com, Pengpeng Hou , Cristian Ciocaltea , Hemanth Selam , Md Shofiqul Islam , Bjorn Helgaas , Zain Aboobacker , Sang-Heon Jeon , Bo Shen , Vinod Koul , linux-sound@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com, linuxppc-dev@lists.ozlabs.org, imx@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 06/25] ASoC: amd: vangogh: Fix acp5x_dma_close() being skipped on rollback Date: Thu, 15 Oct 2026 08:43:05 +0700 Message-ID: <20261015014324.5569-7-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261015014324.5569-1-phucduc.bui@gmail.com> References: <20261015014324.5569-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc snd_pcm_hw_constraint_integer() may return 1, which is then returned from acp5x_dma_open(). ASoC only marks the component as opened when .open() returns 0, so .close() can be skipped on rollback. Return 0 explicitly on success. Fixes: cab396d8b22c ("ASoC: amd: add ACP5x pcm dma driver ops") Reviewed-by: Vijendar Mukunda Signed-off-by: bui duc phuc --- sound/soc/amd/vangogh/acp5x-pcm-dma.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/sound/soc/amd/vangogh/acp5x-pcm-dma.c b/sound/soc/amd/vangogh/acp5x-pcm-dma.c index 831e30e9b042..72050fa2de80 100644 --- a/sound/soc/amd/vangogh/acp5x-pcm-dma.c +++ b/sound/soc/amd/vangogh/acp5x-pcm-dma.c @@ -231,7 +231,13 @@ static int acp5x_dma_open(struct snd_soc_component *component, } i2s_data->acp5x_base = adata->acp5x_base; runtime->private_data = i2s_data; - return ret; + + /* + * ASoC only marks the component as opened when .open() returns 0. + * Since snd_pcm_hw_constraint_integer() may return 1, explicitly + * return 0 to ensure .close() is not skipped on rollback. + */ + return 0; } static int acp5x_dma_hw_params(struct snd_soc_component *component, -- 2.43.0