From: Peter Zijlstra <peterz@infradead.org>
To: Hui Su <sh_def@163.com>
Cc: mingo@redhat.com, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
vschneid@redhat.com, kprateek.nayak@amd.com,
linux-kernel@vger.kernel.org, Thomas Gleixner <tglx@kernel.org>
Subject: Re: [PATCH] sched/idle: Destroy on-stack hrtimer in play_idle_precise()
Date: Thu, 15 Oct 2026 09:02:33 +0200 [thread overview]
Message-ID: <20261015070233.GG4121339@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20261015025029.3356060-1-sh_def@163.com>
On Thu, Oct 15, 2026 at 11:50:28AM +0900, Hui Su wrote:
> play_idle_precise() initializes it.timer with hrtimer_setup_on_stack(),
> but does not call destroy_hrtimer_on_stack() before the stack object
> goes out of scope.
>
> With CONFIG_DEBUG_OBJECTS_TIMERS, hrtimer_setup_on_stack() registers the
> timer as an on-stack debug object. Such objects must be removed before
> leaving the function which allocated them.
>
> Call destroy_hrtimer_on_stack() after the expiry loop to balance the
> on-stack timer lifetime.
Maybe, but I'm hating on this.
For one, the hrtimer_setup_on_stack() comment doesn't mention
destroy_hrtimer_on_stack(), so how are we to know.
Secondly, we have __cleanup(), which gives us the opportunity to
actually do the right thing and create a better interface.
next prev parent reply other threads:[~2026-10-15 7:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 2:50 Hui Su
2026-10-15 7:02 ` Peter Zijlstra [this message]
2026-10-15 7:19 ` K Prateek Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261015070233.GG4121339@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=sh_def@163.com \
--cc=tglx@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®