From: Manuel Ebner <manuelebnerli@mailbox.org>
To: SJ Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@kernel.org>,
Lorenzo Stoakes <ljs@kernel.org>,
"Liam R. Howlett" <liam@infradead.org>,
Vlastimil Babka <vbabka@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>, Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>
Cc: Manuel Ebner <manuelebnerli@mailbox.org>,
damon@lists.linux.dev, linux-mm@kvack.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] mm/damon/reclaim: improve grammar and style
Date: Thu, 15 Oct 2026 10:06:23 +0200 [thread overview]
Message-ID: <20261015080623.808458-2-manuelebnerli@mailbox.org> (raw)
Fix tenses. Replace 'set as' with 'set to'.
Rewrite complex sentences.
Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>
---
@@ -113,8 +113,8 and
@@ -125,19 +125,19
This sentence was difficult to read for me. I don't know if I
improved it. Please advice.
---
.../admin-guide/mm/damon/reclaim.rst | 40 +++++++++----------
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/Documentation/admin-guide/mm/damon/reclaim.rst b/Documentation/admin-guide/mm/damon/reclaim.rst
index e4e2ffa52e..d521563633 100644
--- a/Documentation/admin-guide/mm/damon/reclaim.rst
+++ b/Documentation/admin-guide/mm/damon/reclaim.rst
@@ -4,7 +4,7 @@
DAMON-based Reclamation
=======================
-DAMON-based Reclamation (DAMON_RECLAIM) is a static kernel module that aimed to
+DAMON-based Reclamation (DAMON_RECLAIM) is a static kernel module that aims to
be used for proactive and lightweight reclamation under light memory pressure.
It doesn't aim to replace the LRU-list based page_granularity reclamation, but
to be selectively used for different level of memory pressure and requirements.
@@ -30,12 +30,12 @@ guests could mitigate this problem.
How It Works?
=============
-DAMON_RECLAIM finds memory regions that didn't accessed for specific time
+DAMON_RECLAIM finds memory regions that weren't accessed for specific time
duration and page out. To avoid it consuming too much CPU for the paging out
operation, a speed limit can be configured. Under the speed limit, it pages
-out memory regions that didn't accessed longer time first. System
+out memory regions that weren't accessed longer time first. System
administrators can also configure under what situation this scheme should
-automatically activated and deactivated with three memory pressure watermarks.
+automatically be activated and deactivated with three memory pressure watermarks.
Interface: Module Parameters
============================
@@ -55,10 +55,10 @@ enabled
Enable or disable DAMON_RECLAIM.
-You can enable DAMON_RECLAIM by setting the value of this parameter as ``Y``.
-Setting it as ``N`` disables DAMON_RECLAIM. Note that DAMON_RECLAIM could do
+You can enable DAMON_RECLAIM by setting the value of this parameter to ``Y``.
+Setting it to ``N`` disables DAMON_RECLAIM. Note that DAMON_RECLAIM could do
no real monitoring and reclamation due to the watermarks-based activation
-condition. Refer to below descriptions for the watermarks parameter for this.
+condition. Refer to below descriptions of the watermarks parameter for this.
commit_inputs
-------------
@@ -66,9 +66,9 @@ commit_inputs
Make DAMON_RECLAIM reads the input parameters again, except ``enabled``.
Input parameters that updated while DAMON_RECLAIM is running are not applied
-by default. Once this parameter is set as ``Y``, DAMON_RECLAIM reads values
+by default. Once this parameter is set to ``Y``, DAMON_RECLAIM reads values
of parameters except ``enabled`` again. Once the re-reading is done, this
-parameter is set as ``N``. If invalid parameters are found while the
+parameter is set to ``N``. If invalid parameters are found while the
re-reading, DAMON_RECLAIM will be disabled.
Once ``Y`` is written to this parameter, the user must not write to any
@@ -88,11 +88,11 @@ identifies the region as cold, and reclaims it.
autotune_monitoring_intervals
-----------------------------
-If this parameter is set as ``Y``, DAMON_RECLAIM automatically tunes DAMON's
+If this parameter is set to ``Y``, DAMON_RECLAIM automatically tunes DAMON's
sampling and aggregation intervals. The auto-tuning aims to capture meaningful
amount of access events in each DAMON-snapshot, while keeping the sampling
-interval 5 milliseconds in minimum, and 10 seconds in maximum. Setting this as
-``N`` disables the auto-tuning.
+interval to 5 milliseconds in minimum, and to 10 seconds in maximum. Setting this
+to ``N`` disables the auto-tuning.
Disabled by default.
@@ -113,8 +113,8 @@ quota_sz
Limit of size of memory for the reclamation in bytes.
-DAMON_RECLAIM charges amount of memory which it tried to reclaim within a time
-window (quota_reset_interval_ms) and makes no more than this limit is tried.
+DAMON_RECLAIM recordes the amount of memory which it tried to reclaim within a time
+window (quota_reset_interval_ms) and stops when this memory limit is reached.
This can be used for limiting consumption of CPU and IO. If this value is
zero, the limit is disabled.
@@ -125,19 +125,19 @@ quota_reset_interval_ms
The time/size quota charge reset interval in milliseconds.
-The charge reset interval for the quota of time (quota_ms) and size
-(quota_sz). That is, DAMON_RECLAIM does not try reclamation for more than
+The quota reset interval of time is quota_ms and of size is
+quota_sz. That is, DAMON_RECLAIM does not try reclamation for more than
quota_ms milliseconds or quota_sz bytes within quota_reset_interval_ms
milliseconds.
-1 second by default.
+1000 (1 second) by default.
quota_mem_pressure_us
---------------------
Desired level of memory pressure-stall time in microseconds.
-While keeping the caps that set by other quotas, DAMON_RECLAIM automatically
+While keeping the caps set by other quotas, DAMON_RECLAIM automatically
increases and decreases the effective level of the quota aiming this level of
memory pressure is incurred. System-wide ``some`` memory PSI in microseconds
per quota reset interval (``quota_reset_interval_ms``) is collected and
@@ -263,7 +263,7 @@ This parameter is for setting and getting the :ref:`address unit
``monitor_region_start`` and ``monitor_region_end`` should be provided in this
unit. For example, let's suppose ``addr_unit``, ``monitor_region_start`` and
-``monitor_region_end`` are set as ``1024``, ``0`` and ``10``, respectively.
+``monitor_region_end`` are set to ``1024``, ``0`` and ``10``, respectively.
Then DAMON_RECLAIM will work for 10 KiB length of physical address range that
starts from address zero (``[0 * 1024, 10 * 1024)`` in bytes).
@@ -280,7 +280,7 @@ skip_anon
Skip anonymous pages reclamation.
-If this parameter is set as ``Y``, DAMON_RECLAIM does not reclaim anonymous
+If this parameter is set to ``Y``, DAMON_RECLAIM does not reclaim anonymous
pages. By default, ``N``.
--
2.55.0
next reply other threads:[~2026-10-15 8:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 8:06 Manuel Ebner [this message]
2026-10-15 14:01 ` SJ Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261015080623.808458-2-manuelebnerli@mailbox.org \
--to=manuelebnerli@mailbox.org \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=damon@lists.linux.dev \
--cc=david@kernel.org \
--cc=liam@infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=rdunlap@infradead.org \
--cc=rppt@kernel.org \
--cc=sj@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®