From: Avi Weiss <thnkslprpt@gmail.com>
To: Conor Dooley <conor@kernel.org>, Jonathan Cameron <jic23@kernel.org>
Cc: Paul Walmsley <pjw@kernel.org>,
Samuel Holland <samuel.holland@sifive.com>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
Avi Weiss <thnkslprpt@gmail.com>
Subject: [PATCH v2] cache: sifive_ccache: propagate IRQ count errors
Date: Thu, 15 Oct 2026 11:45:02 +0300 [thread overview]
Message-ID: <20261015084502.3061706-1-thnkslprpt@gmail.com> (raw)
platform_irq_count() returns -EPROBE_DEFER when the
interrupt provider is not ready, but
sifive_ccache_probe() only checks for a zero count.
-EPROBE_DEFER seems to be the only negative return
code possible here (currently).
A negative count skips the IRQ registration loop and
allows the probe to return success without requesting
a deferred retry.
Return negative IRQ counts so the driver is reprobed
when the interrupt provider becomes available.
Fixes: c90847bcbfb6 ("cache: sifive_ccache: Partially convert to a platform driver")
Signed-off-by: Avi Weiss <thnkslprpt@gmail.com>
---
Changes in v2:
- Combine the negative and zero IRQ count checks as suggested by Conor Dooley.
v1: https://lore.kernel.org/r/20261013095756.1084568-1-thnkslprpt@gmail.com/
drivers/cache/sifive_ccache.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/cache/sifive_ccache.c b/drivers/cache/sifive_ccache.c
index 2acb8bdf06d52..f2428f7ea373e 100644
--- a/drivers/cache/sifive_ccache.c
+++ b/drivers/cache/sifive_ccache.c
@@ -262,8 +262,9 @@ static int sifive_ccache_probe(struct platform_device *pdev)
quirks = (unsigned long)device_get_match_data(dev);
intr_num = platform_irq_count(pdev);
- if (!intr_num)
- return dev_err_probe(dev, -ENODEV, "No interrupts property\n");
+ if (intr_num <= 0)
+ return dev_err_probe(dev, intr_num ?: -ENODEV,
+ "No interrupts property\n");
for (int i = 0; i < intr_num; i++) {
if (i == DATA_UNCORR && (quirks & QUIRK_BROKEN_DATA_UNCORR))
base-commit: 0fcb05b72344f40806cbe810de8872f1698bf053
--
2.43.0
reply other threads:[~2026-10-15 8:45 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261015084502.3061706-1-thnkslprpt@gmail.com \
--to=thnkslprpt@gmail.com \
--cc=conor@kernel.org \
--cc=jic23@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=pjw@kernel.org \
--cc=samuel.holland@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®