From: Joshua Crofts <joshua.crofts1@gmail.com>
To: Nikhil Gautam <nikhilgtr@gmail.com>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org
Subject: Re: [PATCH] iio: ccs811: Deassert WAKE GPIO on error paths
Date: Thu, 15 Oct 2026 11:11:45 +0200 [thread overview]
Message-ID: <20261015111145.000065b3@gmail.com> (raw)
In-Reply-To: <20261014152250.8324-1-nikhilgtr@gmail.com>
On Wed, 14 Oct 2026 20:52:50 +0530
Nikhil Gautam <nikhilgtr@gmail.com> wrote:
> Ensure the WAKE GPIO is deasserted when status polling fails or
> the data-ready timeout expires. Early returns could leave WAKE asserted,
> preventing the sensor from returning to its low-power state and
> potentially disrupting subsequent I2C transactions.
>
> Route error paths through a common cleanup label to ensure WAKE is
> deasserted before returning.
>
> Signed-off-by: Nikhil Gautam <nikhilgtr@gmail.com>
Please add a Fixes tag.
...
> ret = i2c_smbus_read_i2c_block_data(data->client,
> CCS811_ALG_RESULT_DATA, 8,
> (char *)&data->buffer);
> +out:
> ccs811_set_wakeup(data, false);
> -
Keep the blank line.
> return ret;
> }
>
Otherwise,
Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>
--
Kind regards,
Joshua Crofts
next prev parent reply other threads:[~2026-10-15 9:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 15:22 Nikhil Gautam
2026-10-15 9:11 ` Joshua Crofts [this message]
2026-10-15 12:06 ` Nikhil Gautam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261015111145.000065b3@gmail.com \
--to=joshua.crofts1@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikhilgtr@gmail.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®