mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sahaj Chaudhari <sahaj123.sc@gmail.com>
To: Tejun Heo <tj@kernel.org>
Cc: "Johannes Weiner" <hannes@cmpxchg.org>,
	"Michal Koutný" <mkoutny@suse.com>,
	"Shuah Khan" <shuah@kernel.org>,
	cgroups@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Sahaj Chaudhari" <sahaj123.sc@gmail.com>
Subject: Re: [PATCH v3] selftests/cgroup: test pids.events notification
Date: Thu, 15 Oct 2026 16:42:56 +0530	[thread overview]
Message-ID: <20261015111256.1551933-1-sahaj123.sc@gmail.com> (raw)
In-Reply-To: <81a8a0d64d269851ce4b48a240aa673c@kernel.org>

Hello Tejun,

Thanks for the review. All five points are addressed in v4:
https://lore.kernel.org/r/20261015111243.1551387-1-sahaj123.sc@gmail.com

The test is now test_pids_events_notify() in test_pids.c, runs on both
mount types, drops the skip and the duplicate counter check, and cites
1765a153d985. The v1 to v2 note moved to the changelog.

I tested it in QEMU on the cgroup for-7.4 branch. It passes on a default
mount and on a pids_localevents mount, and it fails on a
pids_localevents mount with 1765a153d985 reverted.

Separately, the existing test_pids_events fails on a pids_localevents
mount, with and without this patch. I have not looked into it further.

      reply	other threads:[~2026-10-15 11:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-13  6:48 Sahaj Chaudhari
2026-10-14 18:54 ` Tejun Heo
2026-10-15 11:12   ` Sahaj Chaudhari [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261015111256.1551933-1-sahaj123.sc@gmail.com \
    --to=sahaj123.sc@gmail.com \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mkoutny@suse.com \
    --cc=shuah@kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®