mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Wang Haoran <haoranwangsec@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	mhiramat@kernel.org, linux-kernel@vger.kernel.org,
	linux-trace-kernel@vger.kernel.org,
	mathieu.desnoyers@efficios.com, security@kernel.org
Subject: Re: [BUG] tracing: __copy_from_user without access_ok leaks kernel memory in syscall fault tracing
Date: Thu, 15 Oct 2026 18:11:56 -0400	[thread overview]
Message-ID: <20261015181156.5da3446c@gandalf.local.home> (raw)
In-Reply-To: <20261015094209.7177cf03@gandalf.local.home>

On Thu, 15 Oct 2026 09:42:09 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Thu, 15 Oct 2026 20:05:57 +0800
> Wang Haoran <haoranwangsec@gmail.com> wrote:
> 
> Please send this to linux-trace-kernel@vger.kernel.org.
> 
> >  From ca4e2a6928bbd9010ebec967440517b08909b992 Mon Sep 17 00:00:00 2001
> > From: Haoran Wang <haoranwangsec@gmail.com>
> > Date: Thu, 15 Oct 2026 19:12:21 +0800
> > Subject: [PATCH] tracing/syscalls: use copy_from_user for the faultable
> >   syscall buffer
> > 
> > Here is a working fix for the report. The leak is not strictly root
> > only, so there is a security concern on systems that relax
> > perf_event_paranoid.  
> 
> Leave out any security details.
> 
> Simply state that the current check is missing the access_ok.
> 
> That is, this is a very trivial bug with a simple fix and a simple change
> log. It could be a security concern for machines that trust perf a bit too
> much.
> 
> But to go upstream, it still needs to follow the process.
> 

Heh, I just noticed that you *did* Cc upstream (in this email!). But
because you didn't have "[PATCH]" in the topic, it still didn't make it to
patchwork.

Can you please send a proper patch.

Thanks,

-- Steve

      reply	other threads:[~2026-10-15 22:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-15  7:01 Haoran Wang
2026-10-15  8:44 ` Greg KH
2026-10-15 12:05   ` Wang Haoran
2026-10-15 13:42     ` Steven Rostedt
2026-10-15 22:11       ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261015181156.5da3446c@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=haoranwangsec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=security@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®