From: Andrei-Alexandru Bleortu <me@andrei-z.com>
To: Chuck Lever <cel@kernel.org>
Cc: Trond Myklebust <trondmy@kernel.org>,
Anna Schumaker <anna@kernel.org>,
Jeff Layton <jlayton@kernel.org>, NeilBrown <neil@brown.name>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
<linux-kernel@vger.kernel.org>, <linux-nfs@vger.kernel.org>,
<linux-rdma@vger.kernel.org>
Subject: Re: [PATCH 1/1] xprtrdma: Post small RPC Calls inline
Date: Thu, 15 Oct 2026 22:00:19 +0300 [thread overview]
Message-ID: <20261015220019.3412840-1-me@andrei-z.com> (raw)
In-Reply-To: <ddd5a532-bdb2-4976-9b1b-6470414473ec@app.fastmail.com>
On Thu, Oct 15, 2026, Chuck Lever wrote:
> These mean completion latency gains are noise compared to the client's
> own RPC tasking machinery. Perhaps the additional code complexity is
> not worth it yet.
Thanks for looking. The gain is real but small. Over 40 paired runs
its interval excludes zero, and a comment-only patch moved the result
by -0.0139 us. But the 4 KiB write took 48.4 us on average, so the Call
saves 0.4 % of it, and 0.8 % of the 35.7 us read.
> General policy is not to put device-specific details like this
> in ULP code. So, NACK on holding these numbers in a table in
> the rpcrdma.ko module.
Understood. Bart asked for the same on the SRP patch, and I proposed
the create flag you describe on linux-rdma:
https://lore.kernel.org/all/20261015212227.3338582-1-me@andrei-z.com/
I will drop this patch and the svcrdma one for now. If the flag goes
in, the client change shrinks to setting the flag and the check in the
send path, with your lower bound. You can judge then whether it is
worth it.
prev parent reply other threads:[~2026-10-15 19:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 12:48 [PATCH 0/1] " Andrei-Alexandru Bleortu
2026-10-15 12:48 ` [PATCH 1/1] " Andrei-Alexandru Bleortu
2026-10-15 18:30 ` Chuck Lever
2026-10-15 19:00 ` Andrei-Alexandru Bleortu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261015220019.3412840-1-me@andrei-z.com \
--to=me@andrei-z.com \
--cc=Dai.Ngo@oracle.com \
--cc=anna@kernel.org \
--cc=cel@kernel.org \
--cc=jlayton@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=tom@talpey.com \
--cc=trondmy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®