From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE9FE44B69C for ; Fri, 16 Oct 2026 08:00:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792137623; cv=none; b=D4Mi13oF526AaHbP8h0PIF2numbteZs/ntT7Ce/fMOzpS7UL/zajO0HKJa2wEM0ZcHX8tHz2atMHFAcmJflpycrOW3OStWmzSUM2n5d/3sHrlfqpogXMWClCYJNl8LcG/+uYuI7bM71c/QJ20BSwHakmH6j+zeGw+3vySnhMj1c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792137623; c=relaxed/simple; bh=Omh/r/EkzbxDwK4u3Jsf7Qm/OF6SY/r+dH/xbsZP8xA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=tEHTLFB+H90J7XGaE0bpMJV+c19g3mfyGfL/ILnYGmbUtanLhIjly18sS3m2oxTF9K+CBIl39GpMET82rhWpL+eVcA2WCiRJYUc2lf8EDtxksq4CZDtzabmMexTgxdoCePnpoetw3LXMWJEzhBL1voDj6uKxVSerjmxH4XzIQSI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=caal9e1B; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hP9hUHie; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="caal9e1B"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hP9hUHie" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69G6nku73492964 for ; Fri, 16 Oct 2026 08:00:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= tFotLrkKB0thxNBZAni68bXXHHliGXu4ceaayS8YZzk=; b=caal9e1B9XQg3K7F oXeIJMMnfIeIEIelUGSMhQdDgiR/bmtVSI3+8ZZhaiRbllVCC/obZAyuQABrqL4n voE/hA54yDcthsjZ++3Ox2Jds5vLgywvM7gOTEQE3/M1zBlezGD9uDh4VEp4FSfK dNwSTsKuQlzrBxb0GS7yzZAj3PLINtiQVQ2JdKUZTE7NyKjX/p/T14xxHzl5opiN e545JtXU5jAeMyfBGHacAzjz++YF17GlrcZt/VIe2paKpFhMep/H124xigqR+cI3 1nCnr2GPDpzONKDX1vgWpNzPxlkGb+r3csMGM6bw88Acd5DZ4d8mYfT8Q2aEq8xu 7cd3Ug== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hb21wu7rs-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 16 Oct 2026 08:00:19 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-93f20addba1so26901385a.1 for ; Fri, 16 Oct 2026 01:00:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1792137619; x=1792742419; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=tFotLrkKB0thxNBZAni68bXXHHliGXu4ceaayS8YZzk=; b=hP9hUHieeJJ+mezUo5GxrKAcSO52nl3lf6dYnFpZEcyNcgJaOsLXvcfliWb4xIPRh/ nLPPXWyNUjpaS/7VvUiIGah1EvZkiX0gjel9YYoS946/81gjBHPR+uJEw7sBgTcz7wM8 Lo/hphFHk8JrG+KZGVgPR7F9JEcHtVgxoHIoznjjdcKs4smdi17Ycn9Xa6GRrlxfg7S0 kkm1HnZ9bnwULSkcoXvDYWVEhTN/BjrhJG3uLpapdXqExOmhfE5IIzd+0rgj7ey3OvqI a06LpmX2N8gzQt6Ix4yPRM9RCuhlHe2pt72ya9jUeMwCVRZ1OVpTWWs9iLOOPMOcBIov A2KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792137619; x=1792742419; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=tFotLrkKB0thxNBZAni68bXXHHliGXu4ceaayS8YZzk=; b=CVDSph4PI8J2EopYOIPEkPcWxBUdun2yZj/HfmP0twhUlE+rxV/HN5oJkjIrEgh65i 4I+0pG2YxFfup6L6ZdaIZm6e7xVsWcPatHnGw0VZr0m4uuUDmhyGVBC4lyjmroBMLJWE aDgLKw4xxNehFyZvZm/0+mr5PWD1Odc22r5ghmP5TCWaJnJnF4Sh2ONMR5po+QmpwAwH i1bwxtbQiqachfc7sAE1o63DmrqLjoMbHPyBMlOe3jlqzJYhKr1nPXNvmZ2I0pjcYGvP Rm8NSSlVB2Q2xreXqwmHt3xkYefS+OEwThK4btAog3UGbuGcB1Qojt/VojZPFfa9KwSd fRsA== X-Forwarded-Encrypted: i=1; AKwUvBwQYUqisow5z/jZWPAm7rWWu+aAX8sNfh8hh8pDKe4dkD1ppRS45D2tmE3m/wzT77/Jtge0tFmVO2UIGpQ=@vger.kernel.org X-Gm-Message-State: AFq9FYIQIZ+DTC/LS6CGv6T430uKB9ajFZ50D9PqGwHzYnN8usp5DiXK HEIzcKyRhSTtFUmw1XY86TrzNrxE4+WnFDVXR5fbJU4WjR9OhtqT23tvcZIi6RWgIueHMsbO22B 1Q3VCzLAWP5l6TzqhGGw1ilNhcrLM3aQpHTsrvn+AFN51yQojzGdw6xqCPmXkLVwN8k8= X-Gm-Gg: AYBFou1IedazaRwhsyfu5jWyLWk29zuEbjfc2QHnvlcUQrFkyBdGHLR9l0iiq8PZYej sW88H4g+bba+WBUoKGveepHCd5gN9zlCVFS7w5dmu2vFr55144Gj4A36SM5rlwBY7xIVsbmeZJE 5caIE9UgygAXMlLpIj+syRxahmSGERX1553KRR1SFA0LYqSknIlIlxG2rn1LdLIAmIUaKrbki64 +RppUjzvSPTMMHRYdBn9EyFz5cGcCkVeyHI84HpsqRKvh3RV+Y+kEf0CPp2HVOufACqeEE6IroX Ge4P1oMDlzlihz1bJL35kEXBiv0bOElo2En43B937HEBrQCiV68E2sS0fdJ1Coea6I3y2V3CE1i M7+iWF63I+b1XGMRDFMbLnW/y1C0OjxiX+CdISQTu4frJ1gnFM5+lf6YYj3ZSgv/nSJRlY/uDR+ RT7dzk4CObMI+pN2LWVv5jjuyt8Mki5zq6JaokRs5JRWP2Dp6VK1Q= X-Received: by 2002:a05:620a:1720:b0:93b:d7a3:45cf with SMTP id af79cd13be357-93ebd29005cmr3366276885a.56.1792137618921; Fri, 16 Oct 2026 01:00:18 -0700 (PDT) X-Received: by 2002:a05:620a:1720:b0:93b:d7a3:45cf with SMTP id af79cd13be357-93ebd29005cmr3366272285a.56.1792137618284; Fri, 16 Oct 2026 01:00:18 -0700 (PDT) Received: from QCOM-eG0v1AUPpu.na.qualcomm.com ([2a01:e0a:830:450:5402:5e0b:9ef0:9b5b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48dfd4c5942sm5471446f8f.16.2026.10.16.01.00.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Oct 2026 01:00:17 -0700 (PDT) From: Loic Poulain Date: Fri, 16 Oct 2026 10:00:12 +0200 Subject: [PATCH v3 4/7] i2c: qcom-cci: Add burst write support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261016-cci-imp-v3-4-5ee7ec1ea1a1@oss.qualcomm.com> References: <20261016-cci-imp-v3-0-5ee7ec1ea1a1@oss.qualcomm.com> In-Reply-To: <20261016-cci-imp-v3-0-5ee7ec1ea1a1@oss.qualcomm.com> To: Robert Foss , Andi Shyti , Konrad Dybcio Cc: linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Loic Poulain X-Mailer: b4 0.14.2 X-Proofpoint-ORIG-GUID: z18tdau2S6GBe3tuZoyv9jmjtlnzP_4E X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE2MDAzMSBTYWx0ZWRfX0moVy8a/i3mz /VcbqOJVmQADeb6LuizmLrabuf8zCBDYPXPomzKzS3aIFLAMd7M6DDcAs0TIpBPLzZsR2kn8MNW C6o8srCeMjGohIMHZirgMp6NuuHMNdcN7NeQLnHT7EyT23sfAwRnB0JVU3I0uITkaxBhGskIOX0 U1oUi7YvT3/jjGmOx3ohdUehtQzFTOF0SPk1mLaZ/DF/z8gQZrGzqy78mJBuOQ3eyoTDrBWeVBM mbVtsiZaFb0Mh50UuIfVS1w8Dq4w824RK/VjCqjjd1nYMeFWCi04gYfL49HJRYdf5khPa22UoGQ fYc5dXdx9ncYmwozzhHHLO0IedszM5Uc9jF6n9r50GEbJWrHv6gtBRQrrROl5GMw2SXDKDVlg/k 0+rE+TAyv54WC9M37gU0rNakuc1rScL5H4VjVk6v5ZDArhOVGsBUpdcA2wpojDq6E+WPtu82xFc Uqq5EmXNAuuEFazDVwQ== X-Proofpoint-GUID: z18tdau2S6GBe3tuZoyv9jmjtlnzP_4E X-Authority-Analysis: v=2.4 cv=R5qWitRX c=1 sm=1 tr=0 ts=6ad1d993 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=Yp3SuMTfTe4RQKdpiVsA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE2MDAzMSBTYWx0ZWRfX8jUP1EGJmoSu eocvCqcgcaEoXKJzVoDlgFJvl4W6TAIeyeFrZO7B9YPJB4FYzCHQynJR8cgGiQwnbgnFSlAMk14 ZBW0+msYTkQ9szzQQomloZQDOHe6wUE= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-14_01,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 suspectscore=0 phishscore=0 adultscore=0 malwarescore=0 clxscore=1015 bulkscore=0 priorityscore=1501 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610080000 definitions=main-2610160031 A single CCI_I2C_WRITE command can only carry up to 11 bytes, so every i2c write was capped at that size via i2c max_write quirk. CCI v1.2 introduces burst mode support, where consecutive write commands (marked as burst) run back-to-back as a single transfer. Use this in cci_i2c_write() to allow longer writes across the whole queue instead of a single command's payload, and raise max_write_len accordingly for every CCI revision that supports burst mode. unlock/lock commands are required to ensure the commands for a given transfer are executed atomically. Signed-off-by: Loic Poulain --- drivers/i2c/busses/i2c-qcom-cci.c | 39 +++++++++++++++++++++++++++++++-------- 1 file changed, 31 insertions(+), 8 deletions(-) diff --git a/drivers/i2c/busses/i2c-qcom-cci.c b/drivers/i2c/busses/i2c-qcom-cci.c index 7d2e214ac62c652ada122791c69306724425d0f6..bc4aa3c6431f385e07a74c67323674c183a31f97 100644 --- a/drivers/i2c/busses/i2c-qcom-cci.c +++ b/drivers/i2c/busses/i2c-qcom-cci.c @@ -86,14 +86,24 @@ #define NUM_QUEUES 2 #define CCI_I2C_SET_PARAM 1 +#define CCI_I2C_LOCK 6 +#define CCI_I2C_UNLOCK 7 #define CCI_I2C_REPORT 8 #define CCI_I2C_WRITE 9 #define CCI_I2C_READ 10 +#define CCI_I2C_REPORT_IRQ_EN BIT(8) + #define CCI_I2C_WRITE_WC 3 +#define CCI_I2C_WRITE_MAX_LEN (CCI_I2C_WRITE_WC * sizeof(u32) - 1) #define CCI_I2C_WRITE_NWORDS(len) DIV_ROUND_UP((len) + 1, sizeof(u32)) +#define CCI_I2C_WRITE_BURST 0xf +#define CCI_I2C_BURST_OVERHEAD 4 /* LOCK + SET_PARAM + UNLOCK + REPORT */ -#define CCI_I2C_REPORT_IRQ_EN BIT(8) +/* Largest write that can be bursted through a queue of @qsize words */ +#define CCI_I2C_BURST_MAX_LEN(qsize) \ + (((qsize) - CCI_I2C_BURST_OVERHEAD) / CCI_I2C_WRITE_WC * \ + CCI_I2C_WRITE_MAX_LEN) enum { I2C_MODE_STANDARD, @@ -521,11 +531,11 @@ static int cci_i2c_read(struct cci *cci, u16 master, return 0; } -static void cci_i2c_load_write(u8 *buf, u16 len, void __iomem *loadq) +static void cci_i2c_load_write(void __iomem *loadq, u8 *buf, u16 len, bool burst) { u32 cmd[CCI_I2C_WRITE_WC] = { }; - cmd[0] = CCI_I2C_WRITE | len << 4; + cmd[0] = CCI_I2C_WRITE | (burst ? CCI_I2C_WRITE_BURST : len) << 4; memcpy((u8 *)cmd + 1, buf, len); iowrite32_rep(loadq, cmd, CCI_I2C_WRITE_NWORDS(len)); } @@ -534,6 +544,7 @@ static int cci_i2c_write(struct cci *cci, u16 master, u16 addr, u8 *buf, u16 len) { void __iomem *loadq = cci->base + CCI_I2C_Mm_Qn_LOAD_DATA(master, QUEUE_0); + bool burst = len > CCI_I2C_WRITE_MAX_LEN; int ret; u32 val; @@ -551,10 +562,22 @@ static int cci_i2c_write(struct cci *cci, u16 master, if (ret < 0) return ret; + if (burst) + writel(CCI_I2C_LOCK, loadq); + val = CCI_I2C_SET_PARAM | (addr & 0x7f) << 4; writel(val, loadq); - cci_i2c_load_write(buf, len, loadq); + do { + u16 to_write = min_t(u16, len, CCI_I2C_WRITE_MAX_LEN); + + len -= to_write; + cci_i2c_load_write(loadq, buf, to_write, len > 0); + buf += to_write; + } while (len); + + if (burst) + writel(CCI_I2C_UNLOCK, loadq); val = CCI_I2C_REPORT | CCI_I2C_REPORT_IRQ_EN; writel(val, loadq); @@ -716,7 +739,7 @@ static const struct cci_data cci_hw_catalog[] = { .max_mode = I2C_MODE_FAST_PLUS, .queue_size = { 64, 16 }, .quirks = { - .max_write_len = 11, + .max_write_len = CCI_I2C_BURST_MAX_LEN(64), .max_read_len = 12, }, }, @@ -725,7 +748,7 @@ static const struct cci_data cci_hw_catalog[] = { .max_mode = I2C_MODE_FAST_PLUS, .queue_size = { 128, 32 }, .quirks = { - .max_write_len = 11, + .max_write_len = CCI_I2C_BURST_MAX_LEN(128), .max_read_len = 12, }, }, @@ -734,7 +757,7 @@ static const struct cci_data cci_hw_catalog[] = { .max_mode = I2C_MODE_FAST_PLUS, .queue_size = { 128, 32 }, .quirks = { - .max_write_len = 11, + .max_write_len = CCI_I2C_BURST_MAX_LEN(128), .max_read_len = 12, }, }, @@ -743,7 +766,7 @@ static const struct cci_data cci_hw_catalog[] = { .max_mode = I2C_MODE_FAST_PLUS, .queue_size = { 1024, 32 }, .quirks = { - .max_write_len = 11, + .max_write_len = CCI_I2C_BURST_MAX_LEN(1024), .max_read_len = 12, }, }, -- 2.34.1