From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6181A2264DB for ; Fri, 16 Oct 2026 07:32:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792135925; cv=none; b=RoR7cVyle4PC8bBWENJXU/J3009585HgYByj4N5gt54jxgGy0kDGGEyZQfWNxVXaIcI98dy3wyRHuAJ1w1rce/AebOkX46XrQfLc4u2TGqGZvIcEbi4vWDC8DQNdueJ6MNfseEqFqsYIS8pUbpiOs0KTiZ/ia3c3AEy4kuTD24o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792135925; c=relaxed/simple; bh=FTE86iQvTETds/XcGqxzC8vAP9DO32rh/CHAGcJQbNE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=UOtjtPcNJmv/4cE2TkbuBpWbD00ikRDbGv41XpkLBysl7ipHLXb3QF9WVVWo6TWVTSRUVNkVVhafynfyi04IYuJdh/qYio9xLYDZVbH9bYOpTwj4DeBdYlepAnDdE8yu5y/jzpmDxpPUfjYYcVvrI3uetdnqyF7RbxXKY9I4RG8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=m3lRrLju; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="m3lRrLju" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7AEE91F000C4; Fri, 16 Oct 2026 07:32:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792135924; bh=Ns6ZJQzbDshNBdFlSS2u0N4NujihXsEz3HScP8pK1MU=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=m3lRrLjuL1wiFLFIFdqsZQmRTBIpghUQ/RxSSU6abGmaWIATD/AuXvFz9iSQcQLA+ 8LYCM09fTTeVv5uoe/TBsP2JwR0sUeFekkLQbMo/LpDjZinDZFaRHoVZcuX7VeFVv/ bOtOOmHx4FUDynFMe/JlK08LDdklswoiXMJezzygUiTMZlzMi1wi4RiOzz7ahWiYmH uixnlZU/too/1A7MtSixCXDw/gZHYyuD9l4QrjfJQcrDf816xtHqBsmyuIFVCZFqY3 c1N21Yswzqx2kyT2cwJBxJVXdtyyb9MXPgk+e1SJ27DzdekUWfUteBoSZ7zyb0d4Rd jv4oayxsBHfNw== From: Maxime Ripard Date: Fri, 16 Oct 2026 09:31:34 +0200 Subject: [PATCH v5 02/14] drm/atomic: Use __GFP_ZERO instead of explicit memset in drm_atomic_get_private_obj_state() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261016-drm-reset-state-flag-v5-2-dad2d64b693b@kernel.org> References: <20261016-drm-reset-state-flag-v5-0-dad2d64b693b@kernel.org> In-Reply-To: <20261016-drm-reset-state-flag-v5-0-dad2d64b693b@kernel.org> To: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Louis Chauvet , Haneen Mohammed , Melissa Wen Cc: Daniel Stone , Harry Wentland , Jocelyn Falempe , =?utf-8?q?Jonas_=C3=85dahl?= , =?utf-8?q?Michel_D=C3=A4nzer?= , Pekka Paalanen , Sebastian Wick , Simon Ser , Victoria Brekenfeld , Xaver Hugl , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1488; i=mripard@kernel.org; h=from:subject:message-id; bh=FTE86iQvTETds/XcGqxzC8vAP9DO32rh/CHAGcJQbNE=; b=owGbwMvMwCmsHn9OcpHtvjLG02pJDFkXLz2MU/seYOTI9O3qvoOuDz8U3E9q3Hnhm/zV8hde6 e0528XCO6ayMAhzMsiKKbI8kQk7vbx9cZWD/cofMHNYmUCGMHBxCsBEpv5nrM87Ysaz7M35jdqP Ihxydk51/dqpUKr/PW+qVOoVOUGTdpFvyvOeyu9Ov619se1ujd0aA8aG75J5RRdev+8NrZ+gJps g9/X/8lBG0QNXtNYum3NQ633F+h8qnkrV+ydnpB0zEFq78P1mAA== X-Developer-Key: i=mripard@kernel.org; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D The drm_atomic_get_private_obj_state() function allocates a new entry in the private_objs array using krealloc_array(), then zeroes the new entry with a separate memset() call. However, since krealloc_array() already supports the __GFP_ZERO flag to zero newly allocated memory, the explicit memset() is redundant. Pass __GFP_ZERO to krealloc_array() and drop the manual memset(). Suggested-by: Thomas Zimmermann Reviewed-by: Daniel Stone Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_atomic.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c index aa47c647df31..43b58e9b25e4 100644 --- a/drivers/gpu/drm/drm_atomic.c +++ b/drivers/gpu/drm/drm_atomic.c @@ -1093,17 +1093,16 @@ drm_atomic_get_private_obj_state(struct drm_atomic_commit *state, if (ret) return ERR_PTR(ret); num_objs = state->num_private_objs + 1; arr = krealloc_array(state->private_objs, num_objs, - sizeof(*state->private_objs), GFP_KERNEL); + sizeof(*state->private_objs), GFP_KERNEL | __GFP_ZERO); if (!arr) return ERR_PTR(-ENOMEM); state->private_objs = arr; index = state->num_private_objs; - memset(&state->private_objs[index], 0, sizeof(*state->private_objs)); obj_state = obj->funcs->atomic_duplicate_state(obj); if (!obj_state) return ERR_PTR(-ENOMEM); -- 2.55.0