From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DAEF553F6BC for ; Fri, 16 Oct 2026 16:58:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792169922; cv=none; b=gcQrNH2gSeMElPl41TckvEEWrAkvyaxX6Q7LXhFysY4glKuDaWE1BQKWlShAAlJw16aF04HXHxxpZcG6Pufx3ybQipZlt6BhibH/QU+8/iO5QYJwIn2wwSm5o/CRs10qP8wnaHzTMiUlhbQtrXei+9ku894IgtYxmFTcxv5bZg0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792169922; c=relaxed/simple; bh=TcewcdlfgPShkiU59a5lrsVAfbnME1/z13BUy+2XrJc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hGo25ayh/9d39Y8OqtumvyJZe/4/RKqtj39YloKeO1MVJgPTzttoKkl7Os5Mm91L9i3UeMUMG5WdWTHaCsTAFRY83igY/So0aCFgnxRfr547djxdOp1dv34k81mlkf6SE7vdivfdbJGwGePe3rDepuyuJKquJqkqgUIl7NJVT6M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=A1FOPS8q; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="A1FOPS8q" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 43E504E41267; Fri, 16 Oct 2026 16:58:33 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 17BB46075D; Fri, 16 Oct 2026 16:58:33 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 571A910328720; Fri, 16 Oct 2026 18:58:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1792169907; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=pW73Ulzl/GTKczuDx8qsDiu98xxU89BMQuPeNAG8o40=; b=A1FOPS8qX8lVTAR8lOHXTloh999sKkuC/FCXg7qxj6A/LMOxMNJU0bvS1ntwSZMb/Tg7be 1/ZrZdsVlgb7S2AC9xenDgiCjrJRYeXOVeKYm4SVYmQD2EjU6vaMIQ96jQYQFUWKaRJ0gU NqP3OEHEd2JFhYNZUE8CsmZ/ApipHAEnTnsugBD0ZH/3GXnYH7FA6kyMywo04uEvOSXa6R C0H8G7zWrIRzW6CDv9AmQwlTqXpHXDKQrP+/RglWiGkWWFLqrtPvTGBeARLQXqroOpoQ3Y nIBBUAUXEprrAmts1PlCtakkLqNbFz2AHjrOopfi0Y2EBVkK3nwvFcgVaQ8QnA== From: =?utf-8?q?Th=C3=A9o_Lebrun?= Date: Fri, 16 Oct 2026 18:58:15 +0200 Subject: [PATCH net-next v5 1/3] net: macb: add QUEUE_DISABLE capability to 3 compatibles Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20261016-macb-set-channels-v5-1-90ce0c0b8e75@bootlin.com> References: <20261016-macb-set-channels-v5-0-90ce0c0b8e75@bootlin.com> In-Reply-To: <20261016-macb-set-channels-v5-0-90ce0c0b8e75@bootlin.com> To: Conor Dooley , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Nicolai Buchwitz , Paolo Valerio , Vladimir Kondratiev , Gregory CLEMENT , =?utf-8?q?Beno=C3=AEt_Monin?= , Tawfik Bayouk , Thomas Petazzoni , =?utf-8?q?Th=C3=A9o_Lebrun?= X-Mailer: b4 0.15-dev X-Last-TLS-Session-Version: TLSv1.3 >From datasheets, we know those 3 IP versions support Tx and Rx queue disabling, ie bit 0 in RBQP and TBQP registers. All revisions I've seen either support it on both Tx & Rx or don't support it at all. Sources: Compatible | Match data | Datasheet ----------------------|--------------------|------------------------- atmel,sama5d29-gem | sama5d29_config | DS60001764 [0] microchip,mpfs-macb | mpfs_config | header files [1] microchip,sama7g5-gem | sama7g5_gem_config | DS60001765 [2] To contrast, check out the SAM9X60 DS60001579C datasheet [3] that does not document bit 0 as anything special on page 1041 and page 1042. [0]: https://ww1.microchip.com/downloads/aemDocuments/documents/MPU32/ProductDocuments/DataSheets/SAMA5D29-Data-Sheet-ds60001764.pdf [1]: https://github.com/polarfire-soc/polarfire-soc-bare-metal-library/blob/614a67ab/src/platform/drivers/mss/mss_ethernet_mac/mss_ethernet_mac_regs.h#L200-L207 [2]: https://ww1.microchip.com/downloads/aemDocuments/documents/MPU32/ProductDocuments/DataSheets/SAMA7G5-Series-Data-Sheet-DS60001765.pdf [3]: https://ww1.microchip.com/downloads/en/DeviceDoc/SAM9X60-Data-Sheet-DS60001579C.pdf Signed-off-by: Théo Lebrun --- drivers/net/ethernet/cadence/macb_main.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index 020a47353d01..625171fd3f9b 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -5743,7 +5743,7 @@ static const struct macb_config sama5d2_config = { static const struct macb_config sama5d29_config = { .caps = MACB_CAPS_USRIO_DEFAULT_IS_MII_GMII | MACB_CAPS_GEM_HAS_PTP | - MACB_CAPS_USRIO_HAS_MII, + MACB_CAPS_USRIO_HAS_MII | MACB_CAPS_QUEUE_DISABLE, .dma_burst_length = 16, .usrio = &at91_default_usrio, }; @@ -5799,7 +5799,8 @@ static const struct macb_config mpfs_config = { .caps = MACB_CAPS_GIGABIT_MODE_AVAILABLE | MACB_CAPS_JUMBO | MACB_CAPS_GEM_HAS_PTP | - MACB_CAPS_USRIO_HAS_TSUCLK_SOURCE, + MACB_CAPS_USRIO_HAS_TSUCLK_SOURCE | + MACB_CAPS_QUEUE_DISABLE, .dma_burst_length = 16, .init = init_reset_optional, .usrio = &mpfs_usrio, @@ -5812,7 +5813,7 @@ static const struct macb_config sama7g5_gem_config = { MACB_CAPS_USRIO_DEFAULT_IS_MII_GMII | MACB_CAPS_USRIO_HAS_REFCLK_SOURCE | MACB_CAPS_MIIONRGMII | MACB_CAPS_GEM_HAS_PTP | - MACB_CAPS_USRIO_HAS_MII, + MACB_CAPS_USRIO_HAS_MII | MACB_CAPS_QUEUE_DISABLE, .dma_burst_length = 16, .usrio = &sama7g5_gem_usrio, }; -- 2.56.0