From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FD76521207; Thu, 15 Oct 2026 18:15:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792088156; cv=none; b=JbosNwTh33CTXO2DNf7gu3CWDQZueddt4GjRdfmhSrfuOdXJqXZzt1KqzTthORUz+2IkaxozSy5DlUeTKMs+5cZ5QbEWC7MNJgatOudp3N9rq3TCN364+/DRPXJIZ2lPGKyFuxREOR53UlewHhtDb2PSzANquCMxALU3HmieGJk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792088156; c=relaxed/simple; bh=bRT9KZu8UqdKr2cNHa1Z0K3O61FAuTcx+Pq/huomZeM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fUZFB5iQUsFYNT184uZmNfUHKOYPkxXirVW9GuPn9v9a5x1+FkhaDbWB8fKeygO/NdN9oEKJKAl6OINlqm1WOGlCrYFjeRqMUD7ta9MpmmcjM4Ik8qXw3R/D1QXJIGw5q0/cOJmWT7H8t1Z8pJmkBBuUVUvHwEPUqmxYipLrY0c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tJzwFHOT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tJzwFHOT" Received: by smtp.kernel.org (Postfix) with ESMTPS id 3A1F9C2BCF5; Thu, 15 Oct 2026 18:15:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1792088156; bh=bRT9KZu8UqdKr2cNHa1Z0K3O61FAuTcx+Pq/huomZeM=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=tJzwFHOT8zBTg8zoFzjOk6Du5AKu/DQQxp4Xq+H0Z9puNGp3isAAG1RYSWsxSZ1Ka /dzmlU8W6x0kQrq5VkrdB/5ZOzEJTPU8LrKOpLVDZ80ZQI+UeYvFDxtswRKxF3SuX6 0d0E8ljHQrZvSZPs+dvXnPDjpoEgm+c1x4R43Tb1ayi/6CDnEf2ZGRKRIJ+wXj0eAt D5JvB38Epn6iRspp61XpShT8/Fh1DpOiMDD5+I0kHXi3t+wwuginwYrsGAW6sFOR8b YrejTtStE6doR81Nln2DNTr5WRlqzO8kgl4I7+75inzfeg5/etYlvNlqfawOk6GUqg MD6brIBrPFJqA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28BB7CCA467; Thu, 15 Oct 2026 18:15:56 +0000 (UTC) From: Kairui Song via B4 Relay Date: Fri, 16 Oct 2026 02:16:03 +0800 Subject: [PATCH v4 14/17] mm/mglru: reparent folios from all generations Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261016-mglru-fg-v4-14-2106750c0bfa@tencent.com> References: <20261016-mglru-fg-v4-0-2106750c0bfa@tencent.com> In-Reply-To: <20261016-mglru-fg-v4-0-2106750c0bfa@tencent.com> To: linux-mm@kvack.org, "Liam R. Howlett" , SJ Park Cc: Andrew Morton , Johannes Weiner , Muchun Song , Qi Zheng , Ying Huang , Chris Li , Baoquan He , Nico Pache , Usama Arif , Michal Hocko , Roman Gushchin , Shakeel Butt , David Hildenbrand , Lorenzo Stoakes , Barry Song , Axel Rasmussen , Yuanchu Xie , Wei Xu , Vlastimil Babka , Suren Baghdasaryan , Kemeng Shi , Nhat Pham , Youngjun Park , Zi Yan , Gregory Price , "Matthew Wilcox (Oracle)" , Baolin Wang , Ryan Roberts , Dev Jain , Lance Yang , Hugh Dickins , David Rientjes , Yu Zhao , Vernon Yang , Zicheng Wang , Chen Ridong , Tal Zussman , Kairui Song , Xiang Liu , Ehab Ababneh , zhaozhengzhuo , Lian Wang , Kunwu Chan , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, damon@lists.linux.dev, Kairui Song X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1792088152; l=1313; i=kasong@tencent.com; s=kasong-sign-tencent; h=from:subject:message-id; bh=pdKvbjCwV47KGicri13lBUDrCkRk2q0xdMVXETA4zbM=; b=k/ubaRAqYgu0d5sqic7HAzaAbUulfQUwwP8R/2btRLVmVV9Nfb3namLyzH80c0wrc7heLL/QW ogSO2eylyVUAj7poqU5bzgEc3/spqODjrIxSkgSteeV3MFWumHGgPBC X-Developer-Key: i=kasong@tencent.com; a=ed25519; pk=kCdoBuwrYph+KrkJnrr7Sm1pwwhGDdZKcKrqiK8Y1mI= X-Endpoint-Received: by B4 Relay for kasong@tencent.com/kasong-sign-tencent with auth_id=562 X-Original-From: Kairui Song Reply-To: kasong@tencent.com From: Kairui Song A lockless promotion racing with aging can reuse a generation index, see folio_inc_lru_refs(). The retry repairs the folio flags, but sort_folio() may have already moved the folio to the list of a generation outside the [min_seq, max_seq] window. __lru_gen_reparent_memcg() only splices the lists inside the child's window, so such a folio would be left on a list of the dying memcg. Splice the lists and move the counters of all MAX_NR_GENS generations instead. Those outside the window are empty in the common case. Assisted-by: LLM Signed-off-by: Kairui Song --- mm/vmscan.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 617f69c1d9f9..a9c224377234 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -4936,7 +4936,8 @@ static void __lru_gen_reparent_memcg(struct lruvec *child_lruvec, struct lruvec child_lrugen = &child_lruvec->lrugen; parent_lrugen = &parent_lruvec->lrugen; - for (i = 0; i < get_nr_gens(child_lruvec, type); i++) { + /* Lockless promotion may leave folios outside the child's window */ + for (i = 0; i < MAX_NR_GENS; i++) { int gen = lru_gen_from_seq(child_lrugen->max_seq - i); long nr_pages = atomic_long_read(&child_lrugen->nr_pages[gen][type][zone]); -- 2.56.0