From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7E254973AE; Fri, 16 Oct 2026 12:33:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792154030; cv=none; b=SfXDxFhrOmFI5D41bcwWAAmhIkXzNK/0ft4YPOAksc48rYVHSdrWpI7DJ5v4v3vfoe+qjS1FCCi3AjXsDDq1NbgCc8mY61h85JktK6NoP3LRWC658EPioR0KjF3OxyKzUyt9dj3TiHTVpvP3MlGgTjnOFs42uq9JGo05jaK/VJM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792154030; c=relaxed/simple; bh=mUx/eqhBbS3ZWeGbki32wgj3Da1ja1JDeEvy1gkVPRQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hnYkq/b+FfHX3r1jE17P2inkE9fNsI+Z3jOGP5ZnMF7qQeMU+QdKybjNX7UP/v6auH594kbf6xrmygRlnAAOWTzp1R5xqDjq2DNgn//xtzF0fOxI9psv8Wx9GeJs7mzP8zZbawJ7MoDOA7hMXKkCULsVuJwrrIi9FCSSeLLG0YY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=Jfh3FjeM; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="Jfh3FjeM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1792154027; bh=mUx/eqhBbS3ZWeGbki32wgj3Da1ja1JDeEvy1gkVPRQ=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=Jfh3FjeMiw++OPa5JDbMIoswR8AqHEN8TxIz77hdXGHXFnltDhdwvDFomrGo3Wzzk OyYkMU2rbpfv1UhA5wgrDVDfCWVQLrCiCIqz4WT1iIDlpfPFSEA6fSNGRZO30tq93l ThR9QTvFooKelSpPMEEAEFwy2i9RmZuOHy9nVzEXG7tlwf9cz0c8jcjD1/Lans3c8C 0vGSTApsch8JnlECSkSNfmyo7C7Q3u043KWd+VwSXz1WhskDgsWpXJjTml8UpT3UPL Rhgo2w/iofg9BLKw85UkRzfTpWjjmTh/zpuiI9rIaJkR2F9BrFMNtAJLasWLIDbaj0 VaUaaIP/DSHMg== Received: from yukiji.home (unknown [100.64.0.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: laeyraud) by bali.collaboradmins.com (Postfix) with ESMTPSA id 5814217E377E; Fri, 16 Oct 2026 14:33:46 +0200 (CEST) From: Louis-Alexis Eyraud Date: Fri, 16 Oct 2026 14:33:07 +0200 Subject: [PATCH v14 15/23] scsi: ufs: mediatek: Remove mediatek,ufs-broken-rtc property Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261016-mt8196-ufs-v14-15-e8d565e0cd45@collabora.com> References: <20261016-mt8196-ufs-v14-0-e8d565e0cd45@collabora.com> In-Reply-To: <20261016-mt8196-ufs-v14-0-e8d565e0cd45@collabora.com> To: Chunfeng Yun , Vinod Koul , Neil Armstrong , Manivannan Sadhasivam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Peter Wang , Chaotian Jing , Alim Akhtar , Bart Van Assche , Bean Huo , Stanley Jhu , Stanley Jhu , "James E.J. Bottomley" , "Martin K. Petersen" , Philipp Zabel , Liam Girdwood , Mark Brown Cc: kernel@collabora.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Nicolas Frattaroli , Louis-Alexis Eyraud X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1792154009; l=2134; i=louisalexis.eyraud@collabora.com; s=20250113; h=from:subject:message-id; bh=scxCpVLtfp4Tto+BcuHpIAru+gsvEa5xQ+joNcVj0xg=; b=snsL0RSQTjAJZ/3TQaexjZJsyofCJCysiLGLUQqMMORzEjHaGMmJjDATqq5D8qiuQHZCe6auR 56sooG/Co//DDSeCgd89YM1eCGlsSoSEYDWTczGWIacSVQJlhI7Ue1A X-Developer-Key: i=louisalexis.eyraud@collabora.com; a=ed25519; pk=CHFBDB2Kqh4EHc6JIqFn69GhxJJAzc0Zr4e8QxtumuM= From: Nicolas Frattaroli This flag property was never described in the binding, and its capability wrapper seems pointless. If one of the MediaTek SoCs needs the ufshcd quirk applied, then this can be done per-compatible, without needing to give the device tree author the option to forget to set it. Remove it and the associated capability flag wrapping code. Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Peter Wang Signed-off-by: Nicolas Frattaroli Signed-off-by: Louis-Alexis Eyraud --- drivers/ufs/host/ufs-mediatek.c | 5 ----- drivers/ufs/host/ufs-mediatek.h | 2 -- 2 files changed, 7 deletions(-) diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-mediatek.c index 808365b880fd..b8812005b6c4 100644 --- a/drivers/ufs/host/ufs-mediatek.c +++ b/drivers/ufs/host/ufs-mediatek.c @@ -704,9 +704,6 @@ static void ufs_mtk_init_host_caps(struct ufs_hba *hba) if (of_property_read_bool(np, "mediatek,ufs-rtff-mtcmos")) host->caps |= UFS_MTK_CAP_RTFF_MTCMOS; - if (of_property_read_bool(np, "mediatek,ufs-broken-rtc")) - host->caps |= UFS_MTK_CAP_MCQ_BROKEN_RTC; - dev_info(hba->dev, "caps: 0x%x", host->caps); } @@ -1247,8 +1244,6 @@ static int ufs_mtk_init(struct ufs_hba *hba) hba->quirks |= UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL; hba->quirks |= UFSHCD_QUIRK_MCQ_BROKEN_INTR; - if (host->caps & UFS_MTK_CAP_MCQ_BROKEN_RTC) - hba->quirks |= UFSHCD_QUIRK_MCQ_BROKEN_RTC; hba->vps->wb_flush_threshold = UFS_WB_BUF_REMAIN_PERCENT(80); diff --git a/drivers/ufs/host/ufs-mediatek.h b/drivers/ufs/host/ufs-mediatek.h index bde2b53f5798..d97951ee1f4e 100644 --- a/drivers/ufs/host/ufs-mediatek.h +++ b/drivers/ufs/host/ufs-mediatek.h @@ -138,8 +138,6 @@ enum ufs_mtk_host_caps { UFS_MTK_CAP_DISABLE_MCQ = 1 << 8, /* Control MTCMOS with RTFF */ UFS_MTK_CAP_RTFF_MTCMOS = 1 << 9, - - UFS_MTK_CAP_MCQ_BROKEN_RTC = 1 << 10, }; struct ufs_mtk_crypt_cfg { -- 2.56.0