mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: George Neacsu via B4 Relay <devnull+geocausa.gmail.com@kernel.org>
To: Sylvain Petinot <sylvain.petinot@foss.st.com>,
	 Benjamin Mugnier <benjamin.mugnier@foss.st.com>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
	 Mauro Carvalho Chehab <mchehab@kernel.org>,
	 Peter Marshall <pm@petermarshall.ca>,
	linux-media@vger.kernel.org,  linux-kernel@vger.kernel.org,
	George Neacsu <geocausa@gmail.com>
Subject: [PATCH] media: i2c: vd55g1: Register as a sensor sub-device
Date: Fri, 16 Oct 2026 07:37:45 +0100	[thread overview]
Message-ID: <20261016-vd55g1-async-sensor-v1-1-cd72f6d68ea4@gmail.com> (raw)

From: George Neacsu <geocausa@gmail.com>

The binding references video-interface-devices.yaml, so a board can
link the sensor to its illuminator with flash-leds. The driver
registers with v4l2_async_register_subdev(), which does not parse that
property, so the flash sub-device is never bound and never appears in
the media graph.

Use v4l2_async_register_subdev_sensor(), which also handles flash-leds
and lens-focus. v4l2_async_unregister_subdev() already cleans up the
sub-notifier it creates.

Tested on a Surface Pro 11 (X1E80100), whose VD55G0 IR sensor (with
Peter Marshall's VD55G0 support applied) drives the PM8550 flash LED
in hardware strobe mode: with this change the leds-qcom-flash V4L2
flash sub-device binds and the IR LED can be armed from userspace.

Assisted-by: Claude:claude-opus-5-5
Signed-off-by: George Neacsu <geocausa@gmail.com>
---
 drivers/media/i2c/vd55g1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/i2c/vd55g1.c b/drivers/media/i2c/vd55g1.c
index 6f458f6..8e050b4 100644
--- a/drivers/media/i2c/vd55g1.c
+++ b/drivers/media/i2c/vd55g1.c
@@ -2043,7 +2043,7 @@ static int vd55g1_probe(struct i2c_client *client)
 		goto err_power_off;
 	}
 
-	ret = v4l2_async_register_subdev(&sensor->sd);
+	ret = v4l2_async_register_subdev_sensor(&sensor->sd);
 	if (ret) {
 		dev_err(dev, "async subdev register failed %d\n", ret);
 		goto err_subdev;

---
base-commit: 62f482ff73bf3ae88b0c899115527752cf9cbf13
change-id: 20261016-vd55g1-async-sensor-5be09860b38a

Best regards,
-- 
George Neacsu <geocausa@gmail.com>



             reply	other threads:[~2026-10-16  6:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-16  6:37 George Neacsu via B4 Relay [this message]
2026-10-16 11:04 ` Benjamin Mugnier
2026-10-16 14:55   ` George Neacsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261016-vd55g1-async-sensor-v1-1-cd72f6d68ea4@gmail.com \
    --to=devnull+geocausa.gmail.com@kernel.org \
    --cc=benjamin.mugnier@foss.st.com \
    --cc=geocausa@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=pm@petermarshall.ca \
    --cc=sakari.ailus@linux.intel.com \
    --cc=sylvain.petinot@foss.st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®