From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E83943B71C6 for ; Fri, 16 Oct 2026 09:43:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792143797; cv=none; b=HOYSA+BeNoeMuWt0qJcZ0dfXqNv4m4xMrv8Qci3f+cS5UurODkwJdUox1GXQw0GfShMRI0l3dedpxWtEWvICLs6t+pG72UQZbUKZAlAkWGMVkLdrHbrVvoPasAbxeDxjwEZIIdlKCQAqUe2M66emwzTUN7phajCxZY3hdTu6CeE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792143797; c=relaxed/simple; bh=wNZ412Ae3m8jBXHfRGmC8hQuWMi22RyrCtR8KESTa9k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uWy1MeJewx4mhwTRDLs8FoRNAzeBztuMxmWLupM2zzhCTfHkBNLYK9Ctjli8NqNY8k9VYcP37nD0mIRBI0i9wEo3BdrHrSNELVgfqlzOZrE814y11BcCczqNDr1ti03XRjlgHxZJ3deG/Ev63o+JnoZcMIvEDQYtGlNiR2kp9x4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=TZ9yghOn; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=rK1a8Mgg; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="TZ9yghOn"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="rK1a8Mgg" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1792143794; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GSsULpZ3pzORBRFAex1hz9lIvJDrQuTo9GJjL73TxMQ=; b=TZ9yghOnovYFUIzVIxlFqz1FyuAZ7BML14hjiLZzSBqCQZPVlsEhOeJVyb7URobTYN++Pl hoi4Pt1xaO3h3h850fUQB/0d3O+4kV+dScxdw70H1LqQIVQHqRqJzdzvrJ7Nyr2FEt5Fp3 2t0JbGXjT9B/LQqEnyHGNFCsK+6aSlg= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-385-vlQLunzaPty4iiHSvZX0EA-1; Fri, 16 Oct 2026 09:43:12 +0000 X-MC-Unique: vlQLunzaPty4iiHSvZX0EA-1 X-Mimecast-MFC-AGG-ID: vlQLunzaPty4iiHSvZX0EA_1792143791 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-495689bfcc8so52221365e9.1 for ; Fri, 16 Oct 2026 02:43:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1792143791; x=1792748591; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=GSsULpZ3pzORBRFAex1hz9lIvJDrQuTo9GJjL73TxMQ=; b=rK1a8MgghtNewRlm0NAHOdDFaA/miMIXIX0n4Z/YQyWJ3zv3b2/AJbqT+u67rPDXlG LyT1nCYZ+9XbjtgRGaZNXfi15Jp+m8BFYFsp2mobDQb9XIO248ja+X35XvIZCm3af4Bt F5XwYf6XnuCRoV3YFlosxIKeqxzE+cm6Mf06S1UBN6FW4gGwSc06K56x1wczhbNkZAgb nIXndl3wufQoN795A88IbkaX+VKPctOCSZF82Jb/+ZkUt3mYNyAesR+aNQJ0sHjyQ9Ku /+0k+OFFaWFGsb9DJ3UhWDZ87AozK2WQanPPHpu0WZ8H6CLP5Gw8HKMl4E+Zt0UhVjnX jZlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792143791; x=1792748591; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=GSsULpZ3pzORBRFAex1hz9lIvJDrQuTo9GJjL73TxMQ=; b=mePVi1aIDQRr/adpqR/jtDs8cyHlMnOwavM8j2JlboMRiLB2IDObZ7WtHNqzwudCWx f1Y+s2bShEESNgp5ucUm4cEcFM8GsXDy3Bz/LfiNW7nVBbfs4Nae0KR82TbgP7ow5/WU 4zuD2Ip2HJf+8Ht/pEzXlnZ0wofdWKOnR61XtOqmgkRiZWSpLFXpQttNCB0yQkb0cZws QhiHY1BeR+PhufKoIx6l5cA8uIm0+bctmZZNrOsPmFStmQKjVlxP/atl15DeEy3lksLD oS6W9+bigxt3unXRzqVmJkQNy3yfr5uUvLT9HR0inIviQOZPQ+OglsCdCJt/rvOEXdzZ DLVg== X-Gm-Message-State: AFq9FYKb/NqoDlmEUF1rscHhl5Dp25dsnPzavDi6NbnGr5xtTGS3XPN+ P+edy0jy6Z84KBjz8F63vzaJLyPgW03fMFEgUrzzuY2Gw8tOhGbKDR3cQlbogtI1yZLYEmGocgx +ZsoXDBE7X0qUCmOKp2zb0tr/46qy1IAY1vvtFNnjyWKcRm/C1JUjH+vF/G/3fGTtN+QDlfvnag == X-Gm-Gg: AYBFou0HL8O9SZwC2fBYtVkm/hX9FIyhKd/WVZI0sGpfRSyOixIIZ4tqZwwy72hZfFA lkwwLeAPLUVA+ZhFymhoojZHGcSlbg1lnTpP7HeS0tUc5pacZ7ot23xIPtys1bgWijpopxXjTO7 ipw4CKxJ6hcsDXp13Mnow0FIEZbQUB4mfEzEj2OEClX02b8GyYbMqCRKmwJMdGs600nn3GmzL5v QcJqz1pk8asPDEd78oQ9cjMHyfparzeZq+F5T8AHmNZgirqAhEo5M5AuRtfxtBrq3+LlnDs2MtK aHR2XP4Yx69gYcKef6IGhP9RMOGOfo1SF1Xo1zjMCl1zKnDpua0wsC71VFGpTfRT8JjY2A== X-Received: by 2002:a05:600c:6388:b0:4a1:6f78:8419 with SMTP id 5b1f17b1804b1-4a18e3ee8f9mr441048005e9.0.1792143791185; Fri, 16 Oct 2026 02:43:11 -0700 (PDT) X-Received: by 2002:a05:600c:6388:b0:4a1:6f78:8419 with SMTP id 5b1f17b1804b1-4a18e3ee8f9mr441047565e9.0.1792143790656; Fri, 16 Oct 2026 02:43:10 -0700 (PDT) Received: from redhat.com ([2a0d:6fc0:3fd7:5300:3d6b:52a4:a23f:9d0b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48dfd4c5957sm3899658f8f.9.2026.10.16.02.43.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Oct 2026 02:43:09 -0700 (PDT) Date: Fri, 16 Oct 2026 05:43:06 -0400 From: "Michael S. Tsirkin" To: Johannes Berg Cc: linux-kernel@vger.kernel.org, Willem de Bruijn , Jason Wang , Eugenio =?iso-8859-1?Q?P=E9rez?= , Xuan Zhuo , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, virtualization@lists.linux.dev, Rusty Russell , Max Krasnyansky , Richard Weinberger , Anton Ivanov , linux-um@lists.infradead.org Subject: Re: [PATCH net-next v2 2/7] um: vector: honor virtio net hdr conversion failures Message-ID: <20261016054142-mutt-send-email-mst@kernel.org> References: <6716834884238de0ab1ab313004044122aa2adbf.1792067836.git.mst@redhat.com> <8420ba1fe84fc7d105825026802d4ad10d44af71.camel@sipsolutions.net> <20261015085119-mutt-send-email-mst@kernel.org> <64ee40b97fc447bbf3abb80250ad0d9f3cf3c6fa.camel@sipsolutions.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <64ee40b97fc447bbf3abb80250ad0d9f3cf3c6fa.camel@sipsolutions.net> On Thu, Oct 15, 2026 at 02:55:23PM +0200, Johannes Berg wrote: > On Thu, 2026-10-15 at 08:52 -0400, Michael S. Tsirkin wrote: > > On Thu, Oct 15, 2026 at 02:47:01PM +0200, Johannes Berg wrote: > > > On Thu, 2026-10-15 at 08:41 -0400, Michael S. Tsirkin wrote: > > > > virtio_net_hdr_to_skb() refuses packets whose checksum metadata > > > > it cannot make sense of, but the vector raw transport ignored > > > > its return value: rejected packets went on into the stack with > > > > their metadata unvalidated. > > > > > > > > Propagate the failure. > > > > > > > > Assisted-by: LLM > > > > Signed-off-by: Michael S. Tsirkin > > > > --- > > > > arch/um/drivers/vector_transports.c | 4 +++- > > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/arch/um/drivers/vector_transports.c b/arch/um/drivers/vector_transports.c > > > > index e1fb2a76fdff..8b7548458663 100644 > > > > --- a/arch/um/drivers/vector_transports.c > > > > +++ b/arch/um/drivers/vector_transports.c > > > > @@ -210,7 +210,9 @@ static int raw_verify_header( > > > > return 1; > > > > > > > > skb_set_network_header(skb, ETH_HLEN); > > > > - virtio_net_hdr_to_skb(skb, vheader, virtio_legacy_is_little_endian()); > > > > + if (virtio_net_hdr_to_skb(skb, vheader, > > > > + virtio_legacy_is_little_endian()) < 0) > > > > + return -1; > > > > return 0; > > > > > > > > > > Seems it'd be simpler to just > > > > > > return virtio_net_hdr_to_skb(...); > > > > > > As far as I can tell, the function only returns -EINVAL or 0 (never a > > > positive value), and the caller only cares about negative (error) or > > > positive (no checksum needed), so that'd be equivalent? > > > > > > johannes > > > > if raw_verify_header can safely return any errno - i did not want to > > audit it. > > You already used an LLM and still didn't want to? ;-) > > I checked briefly (by hand) and it seems fine, it's assigned to the > function pointer, which only has two callers on the _kern.c side. > > johannes header_check = vp->verify_header( mmsg_vector->msg_hdr.msg_iov->iov_base, skb, vp ); if (header_check < 0) { /* Overlay header failed to verify - discard. * We can actually keep this skb and reuse it, * but that will make the prep logic too * complex. */ dev_kfree_skb_irq(skb); vp->estats.rx_encaps_errors++; (*skbuff_vector) = NULL; mmsg_vector++; skbuff_vector++; continue; } if (header_check > 0) { vp->estats.rx_csum_offload_good++; skb->ip_summed = CHECKSUM_UNNECESSARY; } so any negative is fine, but if we return 1 then it will force to CHECKSUM_UNNECESSARY which I am not sure is what was intended? -- MST