From: Adrian Ambrozewicz <aambrozewicz@nvidia.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Bartosz Golaszewski <brgl@kernel.org>,
Linus Walleij <linusw@kernel.org>,
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
Kent Gibson <warthog618@gmail.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
Herve Codina <herve.codina@bootlin.com>,
Jia Jia <physicalmtea@gmail.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH 4/6] gpiolib: cdev: don't sleep in the SRCU read section in read()
Date: Fri, 16 Oct 2026 10:46:52 +0300 [thread overview]
Message-ID: <20261016074704.1860749-5-aambrozewicz@nvidia.com> (raw)
In-Reply-To: <as5SyJjLd24B8jde@ashevche-desk.local>
On Tue, Oct 13, 2026 at 06:48:24PM +0300, Andy Shevchenko wrote:
> It's duplicated a few times, perhaps you can make a static helper?
Yes, v2 adds one for the three read() paths.
> Caveat: not an SRCU expert, so it might be actually wrong from run-time
> behaviour perspective.
It is fine: the read section of the guard() in the helper ends when the
helper returns, and that is what the patch needs, as read() must not
stay in it while it sleeps. The callers do not use the chip after the
check.
Adrian
next prev parent reply other threads:[~2026-10-16 7:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 13:49 [PATCH 0/6] gpiolib: fix chip removal with lines still requested from user space Adrian Ambrozewicz
2026-10-12 13:49 ` [PATCH 1/6] gpiolib: wait for pending label frees before cleaning up desc_srcu Adrian Ambrozewicz
2026-10-12 15:46 ` Paul E. McKenney
2026-10-16 7:46 ` Adrian Ambrozewicz
2026-10-12 20:42 ` Andy Shevchenko
2026-10-16 7:46 ` Adrian Ambrozewicz
2026-10-12 13:49 ` [PATCH 2/6] gpiolib: free the label of lines released after their chip was removed Adrian Ambrozewicz
2026-10-13 15:38 ` Andy Shevchenko
2026-10-16 7:46 ` Adrian Ambrozewicz
2026-10-12 13:49 ` [PATCH 3/6] gpiolib: cdev: do not free line IRQs again after the chip is removed Adrian Ambrozewicz
2026-10-13 15:44 ` Andy Shevchenko
2026-10-16 7:46 ` Adrian Ambrozewicz
2026-10-12 13:49 ` [PATCH 4/6] gpiolib: cdev: don't sleep in the SRCU read section in read() Adrian Ambrozewicz
2026-10-13 15:48 ` Andy Shevchenko
2026-10-16 7:46 ` Adrian Ambrozewicz [this message]
2026-10-12 13:49 ` [PATCH 5/6] gpiolib: cdev: don't leak the IRQ name when the chip is removed Adrian Ambrozewicz
2026-10-13 15:59 ` Andy Shevchenko
2026-10-16 7:46 ` Adrian Ambrozewicz
2026-10-12 13:50 ` [PATCH 6/6] gpiolib: let the character device free its IRQs first on chip removal Adrian Ambrozewicz
2026-10-13 16:05 ` Andy Shevchenko
2026-10-16 7:46 ` Adrian Ambrozewicz
2026-10-15 12:57 ` [PATCH 0/6] gpiolib: fix chip removal with lines still requested from user space Bartosz Golaszewski
2026-10-16 7:46 ` Adrian Ambrozewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261016074704.1860749-5-aambrozewicz@nvidia.com \
--to=aambrozewicz@nvidia.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=herve.codina@bootlin.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=physicalmtea@gmail.com \
--cc=stable@vger.kernel.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®