From: Adrian Ambrozewicz <aambrozewicz@nvidia.com>
To: Kent Gibson <warthog618@gmail.com>
Cc: Bartosz Golaszewski <brgl@kernel.org>,
Linus Walleij <linusw@kernel.org>,
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] gpiolib: cdev: don't record a line direction the driver refused
Date: Fri, 16 Oct 2026 10:46:55 +0300 [thread overview]
Message-ID: <20261016074704.1860749-8-aambrozewicz@nvidia.com> (raw)
In-Reply-To: <20261014045624.GB13991@rigel>
On Wed, Oct 14, 2026 at 12:56:24PM +0800, Kent Gibson wrote:
> I would change the subject to "don't set GPIOD_FLAG_IS_OUT" as cdev
> doesn't interact directly with the driver - gpiolib does, and the change
> here is unconditional.
Agreed, v2 will be "gpiolib: cdev: don't set GPIOD_FLAG_IS_OUT".
> Not a fan of comments describing why code that should not be here is not
> here.
Fair, I'll drop it.
> Having gpiolib manage GPIOD_FLAG_IS_OUT to keep it consistent with the
> driver state makes sense, so no problem with the code change itself.
Thanks for the review. v2 follows with those two changes.
Adrian
prev parent reply other threads:[~2026-10-16 7:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 13:49 Adrian Ambrozewicz
2026-10-14 4:56 ` Kent Gibson
2026-10-16 7:46 ` Adrian Ambrozewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261016074704.1860749-8-aambrozewicz@nvidia.com \
--to=aambrozewicz@nvidia.com \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®