From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7CBC4749CB for ; Fri, 16 Oct 2026 10:06:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792145188; cv=none; b=R6/YYd3xSoPm6KV1f0hMVZ7ZTT0cU5asog2BykXM1XvVptA5avZGWzzTjaJ1i7Efcc0LuaH/Bk6/fZQNJdhwLQVi1CRijEuiHiC2gMdJcFh4Xnx9z9SbQLsQRyN+JMVGaXHqR/mOIygNd53dcfhzVMwwqe2KeTPVpLKcUwPBI98= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792145188; c=relaxed/simple; bh=HDb6dEAlQfqZ6w+pZ27i4VhJh9De9UuXiV4QYl9+3Es=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lzbcnF/iqxFOqIZQBMk6IUGuywoPKC5IpkhLWm2J5ST/Gt3oRDkmhKc8pwkS7Rt8LvJaclpLuC0u2iq3RaCFB9F3wRZII9qkAFpkLhZeVrlsuZn9Ch//+8x6JyUYDLHV54FEMZtMc3rNPnL/nC1ifwMn14FraUgj1g1RzWKEHQk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BkE1d+lk; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BkE1d+lk" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-49ff680331aso32810695e9.3 for ; Fri, 16 Oct 2026 03:06:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792145184; x=1792749984; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=kZIV8SpDryJCkEdmLv3viRxRvmm/nGJEMBGvh6BKJRw=; b=BkE1d+lkOibyPPHKbYu/5LrI+PtWmFW1AKMnN+2+MCphdNXLUaU8P40SJRDLrVB1KL fJjrtvB4K+WVH/gqkuOqcsJU/thpSJhGO4FVFY9gglVmAD8Io9lBcfSgmvemZqfsnApx +CbBsf18hP0ctq5IhlRU0nXbp/7gbZ+eYLfvJblsG/8DeCuvhps0Z3TXtBfg/tvXjYli Yto8Xrb/0Ro7RUZhQpaQP7vkPfMa9dnI42YmAw/6aVwhy9cjNiKL8nFfVAgqnu4lRVgF 3wWa4RXAGQI3TAbJXJaMwmuqCiiskCKzGnhpqTrzkvv7M7yyXzjQh0ik5h+r78XmmORD 71og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792145184; x=1792749984; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=kZIV8SpDryJCkEdmLv3viRxRvmm/nGJEMBGvh6BKJRw=; b=WGNhzjqk+pv+d5CyMYUhlqVpvjHAHw12O9SpOvD2kymziaRWyib7MJjD2Jwjhdqs97 q6sMnPV7H+wEZuSJCE20KU7xz8jyt7qXWEOZa8q+o35rzjM74indc5BzZkJ8EpzwtDsH Cc5fgbVBPDGSPwWiUkIP2I3Ta8A3+Ju/7ahBNBM6S2aprJcF2zaQRw/CvMCDgSrYLekh mLrCMHmGrVDCYMEUSNNvqUg+rmak+j04HgAclMzO4BDGrmGflhMBDM8QLAwyR2QtMZvP u+W5nDy5LYHTFbvSdSd9uP6Xtu9Xh0HClqg34N8AGvNXW6O4OQK0PAnJHXYXA8IbUEih SJjg== X-Forwarded-Encrypted: i=1; AKwUvBylCdvwCt8BpK7wAbpGYidkoqewiVZXYLGmjlXKIYi6+ALY94YV1OoAnA164HUSDQAQzs0YTO9f5gUuBV4=@vger.kernel.org X-Gm-Message-State: AFq9FYKHpm5UzWGJntSJ/s1bmga0u7JgzPFMldVPoFcCcmv62PiGdHOD ic01eJAQ7iUnJKqOQsPdE357ADNDO3cS+stdYqARMfhgEaIc/cVClklM X-Gm-Gg: AYBFou1Xr1XO++EfFk0YazFVOatLPktdPGUlmB+ZNNQSKnKznhT6xXHDCtC9XrigQYX WMy1v5C5RDa1IH42iNIxLJKxv1/5lmADg8b4lT6MBaGfib4XsdtKFND2oOa093umwyMv3n+gZ6E FiUTVdkU6B2P9/ZW7ZJcBQE3cEa1S3HfzN5PKtNDgHOmRExrjjLpLvJfXzrUtY61L50VkeOSWnA EOUxTm5B1aIy9AvOpScPABTd/G44ZDRMKsB7BPUGuzAK1upQb4ncS16Z0d8U8ZyNsc2oi3ZeiVK nCrHwEYIKhk3e/2iauCPw6Z0j3737lXrnuyZBR7MP55E0ufMKZqw+OW+1vJxkBg8oiSeaXTvtSU QWRCwiihE1PIW0b65ijHyt/aa7gPqSy+m0P4mRn2QnSfT9I7LwmgkwgBRPo4FShhPYPMcRDJpEg ktD2IWDuQz997cc8505e2+PYaAp4h+o2ARlf+m56Zg7IcRnMF5GwrSEwMC6INrM8UXBmEGyGd/4 P4/ZoQi9dL7vz2pSoENimA7Y3GJhkNw2zCbSIOrvnKOwrvbDa2beuncgq2eRFFHMSNtCiv49Mmd h1rehqo= X-Received: by 2002:a05:600c:8208:b0:4a0:1b14:d00c with SMTP id 5b1f17b1804b1-4a18e446f55mr452412475e9.3.1792145183665; Fri, 16 Oct 2026 03:06:23 -0700 (PDT) Received: from SP11X1e.cable.virginm.net (cpc99340-croy26-2-0-cust244.19-2.cable.virginm.net. [80.193.62.245]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a1c8de7230sm45403835e9.14.2026.10.16.03.06.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Oct 2026 03:06:23 -0700 (PDT) From: George Neacsu To: Bryan O'Donoghue Cc: Vinod Koul , David Heidelberg , Neil Armstrong , Vladimir Zapolskiy , Loic Poulain , Mauro Carvalho Chehab , Manivannan Sadhasivam , linux-phy@lists.infradead.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC 2/4] phy: qcom-mipi-csi2: Add C-PHY support for X1E80100 Date: Fri, 16 Oct 2026 11:06:21 +0100 Message-ID: <20261016100621.427612-1-geocausa@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <7aed254e-18c5-481b-a77f-576944fff1d4@kernel.org> References: <20261015-x1e-cphy-rfc-v1-0-1f3fa9af940a@gmail.com> <20261015-x1e-cphy-rfc-v1-2-1f3fa9af940a@gmail.com> <7aed254e-18c5-481b-a77f-576944fff1d4@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Bryan, Thanks for the reviews, and thanks to Loic as well. The series is on next-20261015. There, phy-qcom-mipi-csi2-3ph-dphy.c is blob 966d79c98, the same as on the media-committers next branch, so I think your tree has a different revision of the CSI2 PHY driver. 3/4 and 4/4 also sit on top of David's "C-PHY configuration on Qualcomm platforms" v9 [1], for phy_sel and the C-PHY link frequency, which is not in -next yet. Which base would you like v2 on? If your branch is public I will rebase onto it. Otherwise I will use -next plus David's series and spell the dependency out in the cover letter. For v2 I have: - 1/4: lanes -> trios, and a PHY-layer helper for the C-PHY symbol rate, the analogue of phy_mipi_dphy_get_default_config_for_hsclk() - 2/4: dphy_/cphy_ naming for the init sequences, if/else instead of the ternaries, the D-PHY and C-PHY lane setup split into helpers instead of the goto, and the helper in configure() - 3/4: FIELD_PREP() with a mask for the PHY type select - 4/4: the helper, and an enum phy_mode variable passed straight to phy_set_mode() [1] https://lore.kernel.org/all/20260617-qcom-cphy-v9-0-83da8a8e4e44@ixit.cz/ Thanks, George