From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 831F7471402 for ; Fri, 16 Oct 2026 10:30:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792146608; cv=none; b=saITM5SAQqxCC/XnQn5lLQCCRj20K6Pifv7QEwBUFgv1auG54xt76L8wsi8rF9jLdW610kK7tPsjDA6v5zsSMwpqQLGDjvgL/5FQ+kDK9yu4V/jjJKCpeyTHOnv/qfmUm3cvLDCCfQfyueKay4iS8ZRd+H5hEZF+5hq15aGofC8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792146608; c=relaxed/simple; bh=Dyk6VmNF0evOKGHfPQBJNWA0dzJ9kMffqwLc1fanMmk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VYFqyzOwfVU95j4FKlyODy4zE1QBEvMv/CvbiVBmBZiJi4sNucpUDrNbiN+czSXLTuJ4XOt5L3tIlUmC/mdl63nGrmnDXG7KPwbPW6yFVMCq6VQDKuJKG8QlipKPGaoiLOBStkX/JuctF4vsi+U9LCswV0ogBsYfE3RPgEGVfWY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=WouJ4DXO; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="WouJ4DXO" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id C094D4E41255; Fri, 16 Oct 2026 10:30:05 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 94CD36075D; Fri, 16 Oct 2026 10:30:05 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id DB69E10328113; Fri, 16 Oct 2026 12:30:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1792146604; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding:in-reply-to:references; bh=yIWRmoxTuioRnT0BgpV9XyWpmHQpmK8B4yOZV8/ES+4=; b=WouJ4DXOihUK5Knhq9ROF4byLdA2KK2rWQsC03eqnZ25Liu1GMUVzXgPEX+JzydUMRWniV L8vw4ahVvfms4Ntcdr342oJDD8hzpJXtQ9I7LKFskn7S9uz2ccqQ0IUcFLB8Eh5HJ1jH5q sQPQlZWJvXB1Ct6/nGIRIXleQArMx3RmOJRlb1vo8I4DBchDx919osqjUYBz918PR7Lmol dmsnR6jMa4Nq2sZl+BUeO1jCetBSZTBqz6d+cBzxFExiwsSTNelzUlSFUQTY4o3oLkE+NG zRPgkc+og3fIB+GLPnAgE5y9+8QBJntx1ZaFxHhgLfeqjSFaq3fO5yb8IqotLA== From: Paul Cercueil To: Pratyush Yadav , Michael Walle , Takahiro Kuwano , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Mark Brown Cc: Kees Cook , Tony Luck , "Guilherme G . Piccoli" , Thomas Petazzoni , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Bharat Bhushan , Sunil Kovvuri Goutham , Tanmay Jagdale , stable@vger.kernel.org, Paul Cercueil Subject: [PATCH v4 4/7] spi: cadence-xspi: Clear "SDMA ready" IRQ flag after polling Date: Fri, 16 Oct 2026 12:29:14 +0200 Message-ID: <20261016102917.171095-5-paul.cercueil@bootlin.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261016102917.171095-1-paul.cercueil@bootlin.com> References: <20261016102917.171095-1-paul.cercueil@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 From: Tanmay Jagdale When polling for the "SDMA ready" event, once the corresponding bit is set in the CDNS_XSPI_SDMA_TRIGGER we should reset it to zero. Otherwise, any subsequent call to cdns_xspi_is_sdma_ready() will just return early. Fixes: 931e389ded0f ("spi: cadence: Add Marvell xfer operation support") Cc: stable@vger.kernel.org Signed-off-by: Tanmay Jagdale Co-developed-by: Paul Cercueil Signed-off-by: Paul Cercueil --- Notes: v2: New patch v3-v4: No change drivers/spi/spi-cadence-xspi.c | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers/spi/spi-cadence-xspi.c b/drivers/spi/spi-cadence-xspi.c index 39c868a5b171..095bf640b379 100644 --- a/drivers/spi/spi-cadence-xspi.c +++ b/drivers/spi/spi-cadence-xspi.c @@ -1068,12 +1068,20 @@ static bool cdns_xspi_is_sdma_ready(struct cdns_xspi_dev *cdns_xspi, bool sleep) { u32 ctrl_stat; - return !readl_relaxed_poll_timeout - (cdns_xspi->iobase + CDNS_XSPI_INTR_STATUS_REG, - ctrl_stat, - (ctrl_stat & CDNS_XSPI_SDMA_TRIGGER), - sleep ? MRVL_XSPI_POLL_DELAY_US : 0, - sleep ? MRVL_XSPI_POLL_TIMEOUT_US : 0); + if (readl_relaxed_poll_timeout + (cdns_xspi->iobase + CDNS_XSPI_INTR_STATUS_REG, + ctrl_stat, + (ctrl_stat & CDNS_XSPI_SDMA_TRIGGER), + sleep ? MRVL_XSPI_POLL_DELAY_US : 0, + sleep ? MRVL_XSPI_POLL_TIMEOUT_US : 0)) { + return false; + } + + /* Clear the flag */ + writel(CDNS_XSPI_SDMA_TRIGGER, + cdns_xspi->iobase + CDNS_XSPI_INTR_STATUS_REG); + + return true; } static int cdns_xspi_transfer_one_message_b0(struct spi_controller *controller, -- 2.47.3