From: Navon John Lukose <navonjohnlukose@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Lee Jones" <lee@kernel.org>,
mfd@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] mfd: intel-lpss: Set d3hot_delay to 0
Date: Fri, 16 Oct 2026 19:03:21 +0530 [thread overview]
Message-ID: <20261016133321.49288-1-navonjohnlukose@gmail.com> (raw)
In-Reply-To: <atIjpJn1Y0GPmQbP@ashevche-desk.local>
On Fri, Oct 16, 2026 at 04:16:20PM +0300, Andy Shevchenko wrote:
> So, do you state that this patch fixes some bad touchpad behaviour? If so,
> please, provide some logs.
No, nothing misbehaves without it, so this is only an optimisation. It
shortens the first touchpad report after the controller has autosuspended.
I went after it because the driver already clears d3cold_delay and the
D3hot one looked like it had been missed.
I timed the i2c-hid threaded IRQ handler for the touchpad (CIRQ1080 behind
00:15.0) with bpftrace, switching d3hot_delay at runtime:
d3hot_delay=10 d3hot_delay=0
controller already awake ~1.1 ms ~1.1 ms
controller resumed in handler 12.6-14.4 ms 1.1-1.9 ms
There were no I2C errors with either value. That is about 12 ms saved once
per idle period, which is not much. If nobody can vouch for the older
generations, limiting it to newer IDs or dropping it is fine with me.
prev parent reply other threads:[~2026-10-16 13:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 11:43 Navon John Lukose
2026-10-16 13:16 ` Andy Shevchenko
2026-10-16 13:33 ` Navon John Lukose [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261016133321.49288-1-navonjohnlukose@gmail.com \
--to=navonjohnlukose@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mfd@lists.linux.dev \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®