From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF6134DE728 for ; Fri, 16 Oct 2026 16:16:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792167389; cv=none; b=WUtSXZiWTIJOkIeII73zD+eO9OUPhCAlEzCpxGubdcsHAiptJ5FQY2bgxf2z3/6PhwIz1BqhhpK1MBPk8kWSKIwBGzYK63eGKAukbYJJdOWoVDydaHRWYSJQd4Thr4JJhx1pcyE/SQxgV0hlhbpl59PHUG64GOqAhe9EL9jElBg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792167389; c=relaxed/simple; bh=7DHGCZatwX7FLNpiqx6l6zSz1iIXAE0Gsx9JKxioU1k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pBQnHP84Z+8VuQVBGdmM9LGsxVFsiO0rzrZNdMPPOwUBivRV38ki3KmrBGfPwGSfk4Wa+aNsIS43/uAWXvySQgT66VLlVjCQ5g0/+NYbIrA9EzCO95Fpx7tFxwBopNZ3Yilk29Tq2x8lwxVP/UvSyILa7KeVsCrFQDpExz6/7I4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ceTiwjUX; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ceTiwjUX" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-49fbb2acc90so1250755e9.2 for ; Fri, 16 Oct 2026 09:16:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792167381; x=1792772181; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7DHGCZatwX7FLNpiqx6l6zSz1iIXAE0Gsx9JKxioU1k=; b=ceTiwjUXQ8TOjcRuS1jy7GEudy2wieSR+3fN8U5c4uDIeK/skbgVstU1CHOSoeoGh3 Y9Q72hY3UtxRukdGjUlFbJSPZqciwPFSfZxmUEXm5umscXZX0vNN+2Q/uz2aQ57WmzUv OlKZvzdzytjNZhtOncAmZeoPeOtXmm/QhO+dpEryUmgefRQ8SSLrupe0uGFSDXZErQTd CP1jaHNQ2iHz6CNSq5rLgb5akpDSYxvF+HPH/o8hStyq2j87ghOf0HTc3hF6JeDivAPV NQK/AuD+Vqy8soXfzt6MFA9C54JVdVXD7U0RYDxM5loBnsAE+nEOFTYc7zq0Xg+ViyYx XhAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792167381; x=1792772181; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=7DHGCZatwX7FLNpiqx6l6zSz1iIXAE0Gsx9JKxioU1k=; b=jTivlKSy8+1NGwuI/m9e0lgxMryNXTWrsiSIIEcvh65SDjC4SsHjxLQww9Kto5x5JW 9X73N5mX5PlMbx68rvFxWyDkfcpVg/A4xcw5jXMG/bgBmyFn4HxSHRY37lu8Krq8eRmy LdI27Ktf/pRJiTLaMnKXuLfBX1nB39Bbx/FPR/UPsRb10RvmtKkIp3ncsc+vPSJd6vuS iBGRCQzAt4AKuFrBPBqy2ihzzRUBXM4GXGX9mTxI/Hg0c8si8hSWnBrHWk1OCqlac1jn wLVVJ/UV3G3+C81wZxHTqksMBuZT4mRVSk8sN0b2n1QX5ps6uAwk4v7xHpAQRS9QAg/B TgzA== X-Forwarded-Encrypted: i=1; AKwUvBwV1DIref8LZSmUE9PFfKdhbOVOtz7KYtA4oQ5RelvqxDbDfvPc5cPe6DGqwR4d4MJnx0AoHRFQejp63RE=@vger.kernel.org X-Gm-Message-State: AFq9FYIJ0PqRii/r8FQ+pAYH+6HuEpJ3sew3OsWwTtdX0yOQOSPbTdjT xA30pzvP44GvWjwipRxu6GKh2iVKjKqN/GOJWHG1nZbJTnyQ6uj/CN8ob69bRRa0 X-Gm-Gg: AYBFou1DqX408bslrAhCfAoOmi8wbzc9jiGInsY6DIRjEOdc7Vl252bg1QMib0yS7Xb QJatus2jso82CNCtV4uNYGwwDqLQI/xTiXPgE/GQNlsGS5qVqsVYb1ADajR8VIU1fa2aTFw3Wds 4M/fAyQOd1LFbcMdd8y+SGZdNP79IlQbYHSVo/q3NXcbgj4zjlV8inF2LVd9ZfUqcZWd27C/aka uU7YdJqtTQk8GwEvna/X8w1t7RD/OGgRz7NQUgfb4JnJvLEKS32jgwEKb+DFV7J/GgenkYYfPQj ym7ZCz7YsMMaZZsCQwUxd44BUQHOCMMvQBCfu5quUs80HV1ej8c5Umy9d6u4zW0Hv8uE0FB/H3w eey3i1il0tG0zMh/uavyRZvgsVnk6oJA3HhAzn/u7UIlWgL4sJt32AeCE0KBj4ZooF4Y05RgmT4 0VcJCkcQuuQJlNGIeNl2OnEaYI3YCOWAb8TMYD8jabhSqo7u5Ov5Z5MyRTWy3bg23tCDsImzLan UWbvTTP7hJ/bv29JfvpVwaTejgqLsRTydSl6DUCD5ey7/JAEYPXY3zUNVCTBQU1r6IJjNyx X-Received: by 2002:a05:600c:1c07:b0:4a1:8d46:6228 with SMTP id 5b1f17b1804b1-4a1d7613a0emr6883345e9.14.1792167380631; Fri, 16 Oct 2026 09:16:20 -0700 (PDT) Received: from SP11X1e.cable.virginm.net (cpc99340-croy26-2-0-cust244.19-2.cable.virginm.net. [80.193.62.245]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a1d3e2e602sm32622125e9.5.2026.10.16.09.16.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Oct 2026 09:16:20 -0700 (PDT) From: George Neacsu To: Bryan O'Donoghue Cc: Sakari Ailus , Sergey Lebedev , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , German Pablo Lindo , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] media: i2c: ov13858: Add device tree support Date: Fri, 16 Oct 2026 17:16:18 +0100 Message-ID: <20261016161618.209290-1-geocausa@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <19662dcc-4a25-4d18-a3bc-6b277bd676a6@kernel.org> References: <20261015-ov13858-x1e-v1-0-acdd918f4fb6@gmail.com> <20261015-ov13858-x1e-v1-2-acdd918f4fb6@gmail.com> <19662dcc-4a25-4d18-a3bc-6b277bd676a6@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Bryan, On 16/10/2026 17:06, Bryan O'Donoghue wrote: > You describe regulators, clocks and resets in the yaml file which then > don't appear to be supported in this result code ? > > - regulator_bulk_; > - clock_bulk_ > - reset gpio optional > > I don't think this driver would survive suspend/resume. The power handling comes from a prerequisite: this series applies on top of Sergey's "media: i2c: ov13858: add regulator, clock and reset GPIO handling" v3, as the cover letter says, but that is easy to miss from 2/2 alone: https://lore.kernel.org/all/20260831130312.26296-1-lsa.uz@pm.me/ With it, the driver gets the three supplies with devm_regulator_bulk_get(), enables and disables the clock it already takes with devm_v4l2_sensor_clk_get(), and takes an optional reset GPIO. Power on and power off are the runtime PM callbacks through DEFINE_RUNTIME_DEV_PM_OPS(), which also routes system sleep through pm_runtime_force_suspend() and pm_runtime_force_resume(). So the binding describes what the driver handles once both are applied. On its own, 2/2 only adds the OF match and the endpoint checks. I cannot claim it survives system suspend on the Snapdragon model, though. System suspend is still an open problem on the Surface Pro 11 under Linux and has not been validated, so I cannot exercise that path here yet. What I can test is the runtime PM path, which is where the supplies, clock and reset are switched: the sensor powering off between sessions and back on for the next stream. I will run repeated open, stream, close cycles and report the result. Sergey, if suspend works on the Intel model, a suspend and resume test there would cover the rest. To make the dependency visible, I can carry Sergey's patch as 1/3 of the next version, with his authorship. Sergey, would that be all right with you, or would you rather post v4 yourself? Thanks, George