From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f198.google.com (mail-dy1-f198.google.com [74.125.82.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FA3B502565 for ; Fri, 16 Oct 2026 17:31:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.198 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792171876; cv=none; b=dGa40yETnOJi5e/eqXQIMbnLec5ydSi3lx/65bLAu1ur9LPmvT4sIOetkevXIPwRpPcjWdopkxLVwlXYfqlHza+pef58xhcZtb8Js4ATmt6ZWkcXxGxjuVxkssvbhwIIkTviqln2GvCMSHs/uCyeEsQRFSPveDLVj59PDT+5HFg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792171876; c=relaxed/simple; bh=CFQ5jrx/u6vw66XOyYC58LB1oD8ERnPk3m8rwkYRKZ0=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=V7SIhtAnRJVWlxHpkDUoTvDbT+tc1AR3ls0DJQoj9JZt28lfKX77vbpuG/yEN8aXx27hJLZ4S6DAi5i64fs2++O6TO07yLHv7mxNa/KFjaCh+/ZNBzCWS3LAamHBn0CyOR5wSSAsGY2dmgnOAG+2eJIAAdeZk+L/8lbBZB6APdk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Lfxug5bW; arc=none smtp.client-ip=74.125.82.198 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Lfxug5bW" Received: by mail-dy1-f198.google.com with SMTP id 5a478bee46e88-3580c07911eso264734eec.0 for ; Fri, 16 Oct 2026 10:31:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1792171873; x=1792776673; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=NA++Fw4E9Z7IMDY/xneFvYBRbHMUxJ8a3G6LvbVZpwA=; b=Lfxug5bWVCBpRTM0ViJrbFv9HccQedMttBeqzLpOcmBKeBgkXISq9QB/Y8Sl/kotVu 1lpSbcryvO+9+iqK//wBhvTdImg4lQ/lTZ1G9LAne/cr+8yqrjJiBUft6ClTaZIecUSc GQH9uVIxEe++fdLnlk6v/YrKvwN0thawYcFzHBDxCY28uJeviM4Nnv5xCtvXqGmPUuPD ZDKonf7hHO/tRebfNXTBB/mFECJ2PIQ4Pm81gAy5lveo211RRwaPLpADHz3qN7oQCElA 7FbNhrpUJlbSfqWTF2hMc2FYUh7tGZn9CmHz9VE9NSNr1At2yFEFp0CIjCT5NC5r2kbK 85Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792171873; x=1792776673; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=NA++Fw4E9Z7IMDY/xneFvYBRbHMUxJ8a3G6LvbVZpwA=; b=jGsze64ubfDcLc4Pg3UFXpjAQaAPHDi86bZ2KZQ34wfCWaINxcO5qVV3CycZkDXDOc bHpUwiGkRkD/zs/dIdEw0xZC58xI/6NhaZPrawQFkCHtO/LB0NgbdoRpoBxA9yHbYZTc GR32BH+MiFXpCSk8BkGuHi0nPwxnGQM7M3gkZnk6slGGWEKrMmDMt4kEempACL/j6UMm L7K6lPoNl81Cqu21Z4WIQUCaFTEdp+BLY9yGl1tMjlRnZ3NcDuePdyL0n+YX/Yw16ZW0 m4AbsuNxcKCT6M0V30tbw1Ea/8RbbMdgOxWNkkiUTLki3vlHgl4edJLxnzaHgQjSZlrv 5AJQ== X-Forwarded-Encrypted: i=1; AKwUvBz2yKGQY3yiO2PX9QLgMtzllxO7cKeT2/veWW0x3eDYycrVf5FblYhK+Tl0+2HdzxOkAFsE2MSmI9u8sAg=@vger.kernel.org X-Gm-Message-State: AFq9FYKa+XTZj4mKiSFDW2rtJgR6g1EK4iaqMIcLAprqYE1HtUMk6szK AZjN7iXj2Su4P4DbbMOnyagfmvP7vBeVKD95KSwRdYBM7B84u9oAExMpsCM8/AlU8x4dEti4aFa /UqiKeQD6IA== X-Received: from dlbqc13.prod.google.com ([2002:a05:7023:a8d:b0:161:df69:3983]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7022:170d:b0:149:cfa4:9b3b with SMTP id a92af1059eb24-1850cda6f5cmr781129c88.3.1792171870846; Fri, 16 Oct 2026 10:31:10 -0700 (PDT) Date: Fri, 16 Oct 2026 10:30:49 -0700 In-Reply-To: <20261013222622.1822619-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20261013222622.1822619-1-irogers@google.com> X-Mailer: git-send-email 2.56.0.212.g129ede20d9-goog Message-ID: <20261016173106.679725-1-irogers@google.com> Subject: [PATCH v3 00/17] tools/perf: Adopt kernel compiler-context-analysis.h annotations From: Ian Rogers To: irogers@google.com, acme@kernel.org, elver@google.com, namhyung@kernel.org Cc: adrian.hunter@intel.com, james.clark@linaro.org, jolsa@kernel.org, justinstitt@google.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, ljs@kernel.org, llvm@lists.linux.dev, mingo@redhat.com, morbo@google.com, nathan@kernel.org, ndesaulniers@google.com, peterz@infradead.org Content-Type: text/plain; charset="UTF-8" The perf tool previously added Clang thread-safety annotations in tools/perf/util/mutex.h (GUARDED_BY, LOCKABLE, EXCLUSIVE_LOCK_FUNCTION, UNLOCK_FUNCTION, etc.). Since then, the Linux kernel has adopted a unified set of static context analysis macros and attributes in include/linux/compiler-context-analysis.h (context_lock_struct, __guarded_by, __acquires, __releases, __must_hold, etc.). This series makes tools/include/linux/compiler-context-analysis.h functional by synchronizing it and the required compiler_types.h helpers with the kernel headers, converts tools/perf from its custom mutex.h macros to the kernel-style compiler-context-analysis.h annotations, and expands context analysis coverage across comm, dso/dsos, thread/threads, config, intel-tpebs, env, and maps. Along the way, separate preparatory patches fix an unlocked __dsos__add() call and TOCTOU race in __machine__addnew_vdso(), avoid dropping _dso__data_open_lock in dso__list_del() under REFCNT_CHECKING, switch dso__data_open_lock and tpebs_mtx to DEFINE_MUTEX(), add a read-lock fast path to dsos__findnew_id(), fix an unlocked read of tpebs_reader_thread and double-close of tpebs_cmd.out in intel-tpebs, and avoid a potential read-to-write deadlock in maps__load_first() and out-of-bounds access in __maps__remove(). This series was developed and reviewed with assistance from an AI coding agent (Gemini 3.1 Pro) and reviewed with Sashiko. v3: - Rebase onto perf-tools-next (converting the newly added dso__find_binary_type() lock annotations in util/dso.c). - Separate bug fixes, DEFINE_MUTEX() cleanups, and improvements (vdso, dso_data, dso__data_open_lock, dsos__findnew_id, intel-tpebs, tpebs_mtx, maps) from the annotation patches. - Move AI coding assistant attribution to the cover letter and drop per-commit Assisted-by tags per linux-next Documentation/process/coding-assistants.rst. - Add Marco Elver's Reviewed-by to patch 1. - Define __diag_clang_23() and Clang ASM_INPUT_G/ASM_INPUT_RM/ ASM_OUTPUT_RM overrides in tools/include/linux/compiler-gcc.h (patch 2). - Probe for -Wthread-safety-pointer/-Wthread-safety-beta in Makefile.config (patch 5). - Pass write_locked to __dsos__find() (patch 7). - Pass struct dso_data * to close_data_fd() and dso__list_del() to remove the REFCNT_CHECKING dso pointer from struct dso_data and avoid dropping dso__data_open_lock in dso__list_del(), and include in util/dso.c (patch 8). - Re-validate DSO lookup under the write lock in dsos__findnew_id() via __dsos__findnew_id(), and handle NULL dso_id in dso__needs_improve_id(), __dso__improve_id(), and dso_id__cmp() (patch 10). - Reset tpebs_cmd.out = -1 if start_command() fails and include , , , and in util/intel-tpebs.c (patch 13). - Bounds-check the index in __maps__remove() (freeing maps_by_name if out of bounds) (patch 16). v2: - Use -c rather than -E when probing for -fexperimental-late-parse-attributes in Makefile.config to avoid -Werror,-Wunused-command-line-argument. - Acquire machine->dsos.lock in write mode across duplicate checking, dso__set_long_name(), and __dsos__add() in __machine__addnew_vdso(). - Avoid dropping dso__data_open_lock in dso__list_del() under REFCNT_CHECKING. - Pass tpebs_cmd.out directly to __sample_reader() and set tpebs_cmd.out = -1 in evsel__tpebs_open() to avoid a double-close in tpebs_stop(), and clarify the config_set_mutex comment. - Drop maps__lock before calling map__load() in maps__load_first() to avoid a read-to-write self-deadlock when loading kernel maps inserts additional trampoline maps. Ian Rogers (17): compiler-context-analysis: Avoid unused parameter warning in _context_unsafe_alias() tools headers compiler: Synchronize compiler_types.h with the kernel sources tools headers: Synchronize linux/compiler-context-analysis.h with the kernel sources perf mutex: Use kernel style compiler-context-analysis.h annotations perf build: Enable additional Clang thread-safety flags perf comm: Add __guarded_by annotations to struct comm_strs perf vdso: Fix unlocked __dsos__add() and race in __machine__addnew_vdso() perf dso: Pass dso_data to close_data_fd() and dso__list_del() perf dso: Use DEFINE_MUTEX for dso__data_open_lock perf dsos: Use read lock fast path in dsos__findnew_id() perf dso: Expand context analysis annotations perf thread: Expand context analysis annotations to threads and namespaces_lock perf intel-tpebs: Fix race in tpebs_stop() and tpebs_cmd.out fd handling perf intel-tpebs: Use DEFINE_MUTEX for tpebs_mtx perf config, intel-tpebs, env: Add __guarded_by and __must_hold annotations perf maps: Fix lock inversion in maps__load_first() and bounds check in __maps__remove() perf maps: Add context analysis annotations include/linux/compiler-context-analysis.h | 2 +- .../include/linux/compiler-context-analysis.h | 518 ++++++++++++++++-- tools/include/linux/compiler-gcc.h | 72 ++- tools/include/linux/compiler.h | 50 +- tools/include/linux/compiler_types.h | 206 ++++++- tools/perf/Makefile.config | 8 +- tools/perf/builtin-sched.c | 16 +- tools/perf/builtin-top.c | 4 +- tools/perf/check-headers.sh | 1 + tools/perf/tests/dso-data.c | 4 + tools/perf/util/annotate.c | 4 +- tools/perf/util/annotate.h | 8 +- tools/perf/util/bpf-event.h | 5 +- tools/perf/util/comm.c | 10 +- tools/perf/util/config.c | 43 +- tools/perf/util/dso.c | 140 +++-- tools/perf/util/dso.h | 15 +- tools/perf/util/dsos.c | 31 +- tools/perf/util/dsos.h | 12 +- tools/perf/util/env.c | 1 + tools/perf/util/env.h | 19 +- tools/perf/util/intel-tpebs.c | 104 ++-- tools/perf/util/libbfd.c | 4 +- tools/perf/util/maps.c | 147 +++-- tools/perf/util/mutex.c | 4 +- tools/perf/util/mutex.h | 90 +-- tools/perf/util/rwsem.c | 8 +- tools/perf/util/rwsem.h | 10 +- tools/perf/util/thread.c | 10 +- tools/perf/util/thread.h | 30 +- tools/perf/util/threads.c | 4 + tools/perf/util/threads.h | 6 +- tools/perf/util/vdso.c | 17 +- 33 files changed, 1144 insertions(+), 459 deletions(-) -- 2.56.0.212.g129ede20d9-goog