From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 73A755A0AB4; Fri, 16 Oct 2026 18:27:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792175265; cv=none; b=ZvMBSIm1Z2KiaQG36ndTWuqupSVLgRWWeIIQ5IoIlfRQWg8BwFO2inbQs7AK5bFors559K4m0V+MyVUu4m7pqbMdcAMh3MgnV6Ehwrz6aUe+sXudFsX1tPTSNQfaxSmhaNACv/bDZzCAXd08SjS69PJD5e3eO5TiQDLFrVS35H8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792175265; c=relaxed/simple; bh=vU8cAQb+W+3Jz4MqGi0aLi6f8A4ixtLOHyc/TKPt4lE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uOLao6/Y+yaO2Y7qlB2xKdMvyARbJahziJJcYKgS+/dsWUmoOrSsyVpfnqc/bvM9qwOYWNGSlvEOhoDmaLnwoLzLM6JTS7dYplN8kXxoxuRBJcyK7IGVCrqlOQOSC5JuYCtrWDsi0kRDqOWNG3ghFY16v8Z2eXOAoMRFv/7ugO4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=XjCqaDUr; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="XjCqaDUr" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A9D961516; Fri, 16 Oct 2026 11:27:37 -0700 (PDT) Received: from e142021.manchester.arm.com (e142021.arm.com [10.33.8.90]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3A22F3F7B4; Fri, 16 Oct 2026 11:27:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1792175260; bh=vU8cAQb+W+3Jz4MqGi0aLi6f8A4ixtLOHyc/TKPt4lE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XjCqaDUrx03DsD4Eo952vbHEv0pFtmmYdmBXhh+87pRBGGmhDrXsiim7w2J4k4zw9 fEcH2W5r4y1IBn1KpGLs02fdNcZRQ66HEUla2veIZxWKIe/HuWv5R3OAlsfN/YDqRJ XcGnourEvMpc2Gw3fbBoSiAKObRLc8BWGuNvVTdI= From: Andre Przywara To: Mark Rutland , Lorenzo Pieralisi , Sudeep Holla Cc: Salman Nabi , Vedashree Vidwans , Trilok Soni , Nirmoy Das , vsethi@nvidia.com, Varun Wadekar , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org Subject: [PATCH v5 6/8] firmware: smccc: lfa: Add auto_activate sysfs file Date: Fri, 16 Oct 2026 19:27:10 +0100 Message-ID: <20261016182714.1835813-7-andre.przywara@arm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261016182714.1835813-1-andre.przywara@arm.com> References: <20261016182714.1835813-1-andre.przywara@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The Arm LFA spec places control over the actual activation process in the hands of the non-secure host OS. An platform initiated interrupt or notification signals the availability of an updateable firmware image, but does not necessarily need to trigger it automatically. Add a sysfs control file that guards such automatic activation. If an administrator wants to allow automatic platform initiated updates, they can activate that by echoing a "1" into the auto_activate file in the respective sysfs directory. Any incoming notification would then result in the activation triggered. Signed-off-by: Andre Przywara --- drivers/firmware/smccc/lfa_fw.c | 41 +++++++++++++++++++++++++++------ 1 file changed, 34 insertions(+), 7 deletions(-) diff --git a/drivers/firmware/smccc/lfa_fw.c b/drivers/firmware/smccc/lfa_fw.c index 4b4daf79611bb..65f28ffc9d108 100644 --- a/drivers/firmware/smccc/lfa_fw.c +++ b/drivers/firmware/smccc/lfa_fw.c @@ -148,6 +148,7 @@ enum component_attr_names { LFA_ATTR_FORCE_CPU_RENDEZVOUS, LFA_ATTR_ACTIVATE, LFA_ATTR_CANCEL, + LFA_ATTR_AUTO_ACTIVATE, LFA_ATTR_NR_IMAGES }; @@ -162,6 +163,7 @@ struct fw_component { bool cpu_rendezvous; bool cpu_rendezvous_forced; bool use_cpu_rendezvous; + bool auto_activate; struct kobj_attribute comp_attrs[LFA_ATTR_NR_IMAGES]; }; @@ -306,6 +308,7 @@ static int update_fw_components_node(char *fw_uuid, int seq_id, comp->kobj.kset = lfa_kset; comp->cpu_rendezvous_forced = true; + comp->auto_activate = false; set_component_flags(comp, seq_id, comp_flags, reg_current_ver, reg_pending_ver); if (kobject_init_and_add(&comp->kobj, &component_ktype, NULL, @@ -718,6 +721,28 @@ static ssize_t cancel_store(struct kobject *kobj, struct kobj_attribute *attr, return count; } +static ssize_t auto_activate_store(struct kobject *kobj, + struct kobj_attribute *attr, + const char *buf, size_t count) +{ + struct fw_component *comp = kobj_to_fw_component(kobj); + int ret; + + ret = kstrtobool(buf, &comp->auto_activate); + if (ret) + return ret; + + return count; +} + +static ssize_t auto_activate_show(struct kobject *kobj, + struct kobj_attribute *attr, char *buf) +{ + struct fw_component *comp = kobj_to_fw_component(kobj); + + return sysfs_emit(buf, "%d\n", comp->auto_activate); +} + static struct kobj_attribute comp_attrs_group[LFA_ATTR_NR_IMAGES] = { [LFA_ATTR_CURRENT_VERSION] = __ATTR_RO(current_version), [LFA_ATTR_PENDING_VERSION] = __ATTR_RO(pending_version), @@ -727,7 +752,8 @@ static struct kobj_attribute comp_attrs_group[LFA_ATTR_NR_IMAGES] = { [LFA_ATTR_CPU_RENDEZVOUS] = __ATTR_RO(cpu_rendezvous), [LFA_ATTR_FORCE_CPU_RENDEZVOUS] = __ATTR_RW(force_cpu_rendezvous), [LFA_ATTR_ACTIVATE] = __ATTR_WO(activate), - [LFA_ATTR_CANCEL] = __ATTR_WO(cancel) + [LFA_ATTR_CANCEL] = __ATTR_WO(cancel), + [LFA_ATTR_AUTO_ACTIVATE] = __ATTR_RW(auto_activate), }; static void init_component_default_attrs(void) @@ -759,11 +785,11 @@ static void clean_fw_components_tree(void) /* * Iterate over all FW components and trigger activation of all activatible and - * pending components. - * Since we would need to re-enumerate the list of all components after a - * successful activation, and this could trigger infinite loops if a firmware - * component still appears as pending, we create an array of update candidates - * first, then activate each one of them. + * pending components, but only if automatic activation for that component is + * allowed. Since we would need to re-enumerate the list of all components + * after a successful activation, and this could trigger infinite loops if a + * firmware component still appears as pending, we create an array of update + * candidates first, then activate each one of them. */ static void activate_pending_components(void) { @@ -791,7 +817,8 @@ static void activate_pending_components(void) continue; /* Invalid FW component */ _update_fw_component_pending(comp); - if (comp->activation_capable && comp->activation_pending) { + if (comp->activation_capable && comp->activation_pending && + comp->auto_activate) { kobject_get(&comp->kobj); all_comps[nr_comps++] = comp; } -- 2.43.0