From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94FD53E40F9; Fri, 16 Oct 2026 21:21:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792185674; cv=none; b=L3HFFIy5C1/LT29pO5RusoSXyfYg6PuuWD/Te3fp4hXjyS30oHrXMz0O59M0JOeDY9PIiVq+k5RIEpTpGZyw6Himekxpv9Iia6/78dRcAHAol/yln0ja5q7rKUT/LWdN3v7IGhn2nPIfUI3Z386k0a4vL/RXX8kG41LcqIP+eHI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792185674; c=relaxed/simple; bh=SmxGbot7TR9HDni/Elet4vrkv/9q2gIcEau2siebyHQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SFYOBQRqVCx7zZwxm2MID8PMs3AmSOyGK0+xO0O6GBoFLMzGg/1hqNhhutJ+jrgdqgpseolB2ib0aqaA+l3kygp9xhUf4A/1YwTUXrJmZUYnWTz+5BECUcAKQ/GmEMu3AldR9dVe2KYZxszAO2PvTmrS+5Kh/NWFULY2K8Y0pjA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CXU5NJ7e; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CXU5NJ7e" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 895801F000C5; Fri, 16 Oct 2026 21:21:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792185673; bh=w5/BfkC1OceS3dX0jV7eo4MrwK7mpfm5mPAWRCk6F7M=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=CXU5NJ7e2UpLW+4H0A3CdXDroG4byDNrd3d0cbXhkx5GswNFYwf+G+NpvRA9W6eCA CvPR1SjKb6dbnRjFGbvd5HWqostjuJ0/1S3zF/jJACKssuBRV5TQ0+ZNcae3Z+M1iT TYtSDiGgdLych+DxrCXIVKopVQB8gbUbLuB2mwGtcKFvh6ASmhvdgHZfsgqwv3fm6w ffCTJS/PsuQGjI1JU7u0lAIJZZEOwWbA6OOw3/80jugay6yaSoJood4IPAlg2itfDL 8lAhxHXDqiUgo9EDFNthi9P6lyFW6x62ndtZCe1naE4DH96YGD95KuT8SRknuDAjGX lffmUSxqf0v7A== From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ingo Molnar , Thomas Gleixner , James Clark , Jiri Olsa , Ian Rogers , Adrian Hunter , Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo Subject: [PATCH v4 01/21] perf test attr: Fix record dwarf sample_type expectation Date: Fri, 16 Oct 2026 18:20:42 -0300 Message-ID: <20261016212102.76550-2-acme@kernel.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261016212102.76550-1-acme@kernel.org> References: <20261016212102.76550-1-acme@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Arnaldo Carvalho de Melo Since commit bdd051e24914 ("perf record: Split --data-mmap option"), record_opts__parse_callchain() sets record_data_mmap instead of record->sample_address for the DWARF unwind mode, so -d/--data and its implied PERF_SAMPLE_DATA_SRC are not enabled implicitly anymore. As a result, --call-graph dwarf no longer sets PERF_SAMPLE_ADDR and PERF_SAMPLE_DATA_SRC, making the test fail: expected sample_type=45359, got 12583 where 45359 (0xb12f) is: IP|TID|TIME|ADDR|CALLCHAIN|PERIOD|REGS_USER|STACK_USER|DATA_SRC and 12583 (0x3127) is: IP|TID|TIME|CALLCHAIN|PERIOD|REGS_USER|STACK_USER i.e. the values differ exactly by PERF_SAMPLE_ADDR (0x8) and PERF_SAMPLE_DATA_SRC (0x8000). The mmap_data=1 expectation is still correct as DWARF now enables record_data_mmap. This went unnoticed until tests/attr.sh stopped ignoring attr.py's return value. Fixes: bdd051e249141c79 ("perf record: Split --data-mmap option") Assisted-by: LLM Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/tests/shell/attr/test-record-graph-dwarf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/tests/shell/attr/test-record-graph-dwarf b/tools/perf/tests/shell/attr/test-record-graph-dwarf index ae92061d611ded68..fbe0faa8cdb6a8f4 100644 --- a/tools/perf/tests/shell/attr/test-record-graph-dwarf +++ b/tools/perf/tests/shell/attr/test-record-graph-dwarf @@ -4,7 +4,7 @@ args = --no-bpf-event --call-graph dwarf -- kill >/dev/null 2>&1 ret = 1 [event:base-record] -sample_type=45359 +sample_type=12583 exclude_callchain_user=1 sample_stack_user=8192 # TODO different for each arch, no support for that now -- 2.55.0