From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67D24394797 for ; Sat, 17 Oct 2026 03:25:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792207546; cv=none; b=e9AnAgKE4c8ZuQTd4Kg7V1fiPsNelQ7yqmdSIwLF6On4ZlyfRPl1OOUP+3h2irx2eeTzo09YwvfaAGRsvVnToSkYvMyeXFLN/6pdyqg5FZh+rLtVIUxO764dZqLbK2kO88iTBMsE9J6pAoazRUl52P0HtTgTWchqkkNUKfxh0CU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792207546; c=relaxed/simple; bh=7xhhEFhc5FWmoihtNUDA25SO/91fb9nkW+B+vD2NgtU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=bH3v+duz2TYcFba1Qqp/rvpS0y2nzOL8E+eVF0qVF9c5olI2aqP2lvYIIReSyiDsDHNXp1z9/eqVzPStCXpV19sBGhRLKkW4CvDxWdl5IrAQgnxfc+49vsn06AEcbE5SAqvaXyP0yzHUQ7zPb83L4554CBCNKD227/ZZ1JCsWEI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=H3/k3i5D; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=aExotiJA; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="H3/k3i5D"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="aExotiJA" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69H30lEX351066 for ; Sat, 17 Oct 2026 03:25:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=u02s+P4ghOqE3a7TA/QqWu rrs+yx0It5QXRpILne/H8=; b=H3/k3i5Dxk2csuDZKNrdZv1eK5DHAZsBS0LAeN NtHWYq7vOqYYfG7qkInCu6cL9m0jUZFCowProXkeuWdz8vRRRLxOqVOiJ0iuxGlO Q9U3J4a7KVgVu7z5dJyUjkolTLMMiSHMFm6GoD04Mb+u0Kmp9uGlcqUBi3/tuCAU adk6JWlWsL19X821YD/XBxTVAepnxwD4kDnmV2my11f17hDmpTVuzQHjdr61OQ6p QU3qJ5LpZfaJ8N+9pOD29UUV8aJg9/DoV1g0ZwweHPI1+RdEOYc0z3ahSfrSbfoc CAmoYOCPi43uxnl+T0bVg9eNWpH4Y4wQGUJLckkkl5V4F1pw== Received: from mail-dy1-f198.google.com (mail-dy1-f198.google.com [74.125.82.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hc016g3xu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 17 Oct 2026 03:25:44 +0000 (GMT) Received: by mail-dy1-f198.google.com with SMTP id 5a478bee46e88-35a4d2e39acso2503360eec.1 for ; Fri, 16 Oct 2026 20:25:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1792207543; x=1792812343; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=u02s+P4ghOqE3a7TA/QqWurrs+yx0It5QXRpILne/H8=; b=aExotiJALFDY3Kj6ECIEeQOzUQROdhOXEqOVpG9qpgQbEY7HwWWty4ty1bZNECQQm7 BnQ+TI6Q6TxnGcjAiURGFZJUZALrCHVBSin1fV+aHSsxxRyZR//mMHytnWMhqe6qgnVr 3/qJ+lf//XIgBaB7/xl3IBnVIZfL13t0ttaFoGoaVfs1gC1iP/PHRdajG2mTwY+/AnBN ATp1J9tcNk9UaRxOC6fcgTmyJHBf977Sq0psVyqJP+9mImhJD7kVhgeV15GCItoQbnWz s2qo4SkJH1jqL4SqVe8apHyWxFLoAJvfEq4eV/ccPO9Z2MlWUWgBlGpidB/qzY4NWcVK 0eOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792207543; x=1792812343; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=u02s+P4ghOqE3a7TA/QqWurrs+yx0It5QXRpILne/H8=; b=zH1fPaITHCk9vCeRzb1HVhMxZV3NvvOhqnQSsSWQ4sETrS3BjQur/lduWg47Cwmlnb qU0epREmvxkjyqIK2q3RdgG+YT9a6Df3XiGrkP7CmDdKPDCB2jvsW5B+DbAbdROcgPlE qXEWATshTa1titwHU3adxtOyn5Q4HJyioMIHklxIBGa+KhoksMNAzv1KS8j/Ir5Vdy2Q A35exceTT07kdLfAObpFOCXMuUysSHXPFCivoWmCgdXF3rju3GOwfVFgklp+BnhT6b6q qDuYvHkkoKCk51drv1HnAu5uETuP6Ir49Z/VPbFvVmEMzu8jZM8p9Plcqb0d5XCtYcdT JjPA== X-Forwarded-Encrypted: i=1; AKwUvBypRFOwRXlzjJXEtdHm2zFBIIjmTB3cvowXpRpoPcd6SUzF12WkxLmeG5405QrAeWHsB0HxKosV+zTY2qw=@vger.kernel.org X-Gm-Message-State: AFq9FYKkqs+Tp3JeD1D0kYQVJtLpUglaIg86nsIydqXrv7YakOcLbC5M WJcdmFhVp+YBWrU4sXDI3+7Nlp3tp17xMwpLTVmBiABZhSR481r3cLvaouurkLfFik2Mqh3voYM 0XzzmyxQbIWL/5NWCWQioZYy4s40e9/n2BJfdJknRsMAgy0l8+LKobdXPPMI2GH86BN8= X-Gm-Gg: AYBFou19fZR4uOKdeP8u5q3kcvv/8CHJfGGf6oAvnqmAMpEvxSaPLY9CwZeEL5D1yL8 KV36oTeLEOnGSVpnYCeCpgOepQHxRFFGTG2zjlER9xarOqhI51jv5tfWJttXQtXH2iaSRUehSOP 9NZG+y1Nv3HowAZwcAQUphaILvLcNtphI8ovVYgtF4sshYly5EDuQxUu0JBvVh6HSLdFZvkG5LJ 5psqS9zORuNM6KIRKLUR5AA4Q7TMdxi2YjB/GcMtnCam2lA7dKJoBNwfBOmoq9c9xwLjtJQjjdB h/7gJKvZ8+0VnbDVXfv9qczIK9Ty5vm06yrZV74hSGclRO+Mu7VbWOCVur6uvuo6xDAQV5qyl+x pSq2Mt3Fv3dX5Dd5+uqSKv5mWOhSnN+hq4w== X-Received: by 2002:a05:7300:d10:b0:35a:84cc:d941 with SMTP id 5a478bee46e88-361a341c8e6mr3151668eec.37.1792207543169; Fri, 16 Oct 2026 20:25:43 -0700 (PDT) X-Received: by 2002:a05:7300:d10:b0:35a:84cc:d941 with SMTP id 5a478bee46e88-361a341c8e6mr3151628eec.37.1792207542597; Fri, 16 Oct 2026 20:25:42 -0700 (PDT) Received: from hu-bvisredd-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-36082a7b33bsm19471422eec.24.2026.10.16.20.25.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Oct 2026 20:25:41 -0700 (PDT) From: Vishnu Reddy Date: Sat, 17 Oct 2026 08:55:04 +0530 Subject: [PATCH] media: iris: Fix out-of-bounds read in timestamp metadata fallback Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261017-fix-oob-tss-v1-1-fb86f4cabf65@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIAI/q0moC/yXM0QpAQBCF4VfRXJvaWUV5FblgdzAurHaQkne3u Pw6nf8C5SisUGcXRD5EJSwJlGfgpm4ZGcUngzW2JEMFDnJiCD1uqlj5gipfknWDgfRYI6f5qzX tb937md32JuC+H7iOGupvAAAA X-Change-ID: 20261013-fix-oob-tss-7d317d612cf0 To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Vishnu Reddy X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1792207538; l=1952; i=busanna.reddy@oss.qualcomm.com; s=20260216; h=from:subject:message-id; bh=7xhhEFhc5FWmoihtNUDA25SO/91fb9nkW+B+vD2NgtU=; b=LawpIaPxZ27QVFYN1j/PsdMUYUkUeHcxEYZbhURka8kqTxRctzFKAWtptPpfe4EX8OKt5hOXs ET0PEj6Z96bBvC4eXFG2cwmtERy0NzJyjlMDG/9euQp9JG5mBlGyiGT X-Developer-Key: i=busanna.reddy@oss.qualcomm.com; a=ed25519; pk=9vmy9HahBKVAa+GBFj1yHVbz0ey/ucIs1hrlfx+qtok= X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE3MDAxMiBTYWx0ZWRfX+VK3sbhsnPcw ua5bgRAWyauQ5HiKlDLWQH72tUAjg+6vExAlJuMk0E2DDTViGY4YWBMXa0tLPpq2xTKVbybZPFp vIVNX7so590p2oOG78UfJpy3dCHi7FQ= X-Proofpoint-GUID: 6myKPvlK4GDDIkpOydjlfqLR2sPyeIky X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE3MDAxMiBTYWx0ZWRfX68r1UcC4N76E nEFhbW1avBflCrV0KDX0b93DKBLwXSjqQEQWeT/go09hNX5MCDTlIIV5lx/f14XCl9jT/1lJx7T CdDEhVqP/aug1cd40XrCzJkZ02N+scbDahFt1jK8NfM/wLdBY0lQCIqfytPrYfVx3qKBlng5lWy JA/Oxlh4nL42P4dDVeOMbhpXDZVno3bM5spouzV3Iob62jmcHoRHaIVTpM3dpM1c0y7AZp5Sv/K 3mmMUZ0NGEMS6OuKLIOfbkbcADK0/NqoKjOtJ86ZGStG0/zSl3/0M+bdFtJ3LJWDgSM1y9tEtb0 2QFrKxaWRMR+vYvn6b5H7EXqWMlmxI29T0QkGdqaOQJeO4PtNLzakoEXAYu6xGXqO9/ozKksk+g 0t2Z8wVFDXCfbe4u8WpApkjEB3kuWsFuPk+jjsx+f4rK3o0V8vBMAbFuJuvVw94JE1hC/4W0wgZ 5Vane7gVmOw5V3NntCQ== X-Authority-Analysis: v=2.4 cv=COm/zhrD c=1 sm=1 tr=0 ts=6ad2eab8 cx=c_pps a=wEP8DlPgTf/vqF+yE6f9lg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=wraWorUZ4TRzSvnLzhcA:9 a=QEXdDO2ut3YA:10 a=bBxd6f-gb0O0v-kibOvt:22 X-Proofpoint-ORIG-GUID: 6myKPvlK4GDDIkpOydjlfqLR2sPyeIky X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-17_01,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 phishscore=0 bulkscore=0 spamscore=0 malwarescore=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610080000 definitions=main-2610170012 inst->tss[] has VIDEO_MAX_FRAME (32) entries, so valid indexes are 0 through 31. iris_set_ts_metadata() writes at metadata_idx and then increments it. After the 32nd input buffer, metadata_idx is 32 until the next input buffer is queued. If iris_get_ts_metadata() finds no matching timestamp in that window, its fallback reads inst->tss[32], one entry past the end of the array. UBSAN (Undefined Behavior Sanity Checker) reports this as an array-index-out-of-bounds error. Use the last written entry, metadata_idx - 1, in the fallback instead. Fall back to slot 0 if nothing has been written yet. Even if stream off and stream on happen multiple times on the same session, the fallback always uses the latest metadata received. Fixes: 17f2a485ca67 ("media: iris: implement vb2 ops for buf_queue and firmware response") Cc: stable@vger.kernel.org Signed-off-by: Vishnu Reddy --- drivers/media/platform/qcom/iris/iris_buffer.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/qcom/iris/iris_buffer.c b/drivers/media/platform/qcom/iris/iris_buffer.c index eb8de60c1177f..31cba99a665c1 100644 --- a/drivers/media/platform/qcom/iris/iris_buffer.c +++ b/drivers/media/platform/qcom/iris/iris_buffer.c @@ -865,9 +865,11 @@ static void iris_get_ts_metadata(struct iris_inst *inst, u64 timestamp_ns, return; } + i = inst->metadata_idx ? inst->metadata_idx - 1 : 0; + vbuf->flags &= ~mask; - vbuf->flags |= inst->tss[inst->metadata_idx].flags; - vbuf->timecode = inst->tss[inst->metadata_idx].tc; + vbuf->flags |= inst->tss[i].flags; + vbuf->timecode = inst->tss[i].tc; } int iris_vb2_buffer_done(struct iris_inst *inst, struct iris_buffer *buf) --- base-commit: 2efb7a11f1aa4d2dc285fe2680cca22cb9f72f64 change-id: 20261013-fix-oob-tss-7d317d612cf0 Best regards, -- Vishnu Reddy