From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C39853D47C3 for ; Sat, 17 Oct 2026 03:17:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792207032; cv=none; b=Bnjro9IRDrahEdZxzKbxdtoqb20wQf/1LNm8TXAdBCQy7ZEOE9LqxelSXTkVcYJD2dVUElvt84+ogf2j3XcVYOwL2zhODVUG7rftzSOrwfwlZlk/p15/HYQioYAhZUH+5PKE2Io1WuhjSCazS0j/CBBW1aMsw8S6Umr/LHDB2gc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792207032; c=relaxed/simple; bh=hVspXbe0sCkaXoj1fe7zHKMem3/ix0mWkb/2R8o/yYA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=tSq8+GPKBYi+Z07pCEDlZ/8PNWpmrTyv6b1NCVPVU66ROiwW1kXK0a21yEG6Jb3hPTj6mGPZzVbpztHvYaJRx4OIywzJZAT4HEB/v6uJ3nPSU8KHGvnDQ+1g93OqAaj0ZnUEqT0j50SBJ8qN+sttNBpNXWwF1GWpGeIvl4k+2nU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Bc3bPlBr; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ajmV5Y/A; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Bc3bPlBr"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ajmV5Y/A" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69H30dUM350944 for ; Sat, 17 Oct 2026 03:17:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= WeN0lmGHanzlBT6I4estf/cTW+4Gl4FJbWILgGaJfb0=; b=Bc3bPlBruErJq5pZ ytbBCffRYXKrvyZZcKBAMIrg1FH/dhBTal+A9LXmRXDcD3GgAq8dkaZ3xN5i5CZD 6M6/l+xbesCflMIGzFEvwbTLzbD+RGxFqSFJ9oqrAcpx54UP9TOkxxJ+m18KM7gM ywQopcPYTI/0lIv8AsShnXoiM4W+3zwRJeL6kamV2kWfW1U0FuRWO1BetOsHqReR ouLLaR0iM+o19LLDWcPLWrGbmIlBORvUj6clCJfwKEk0xHjmF8awRe25GePv5+sG ySvZ1lHl6WSgd/Fm4FY2boCTwu6VPO2otyU4Bd43iHGuwHnCsFp8jm958vjLfro9 +TK8uA== Received: from mail-dy1-f197.google.com (mail-dy1-f197.google.com [74.125.82.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hc016g3fn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 17 Oct 2026 03:17:05 +0000 (GMT) Received: by mail-dy1-f197.google.com with SMTP id 5a478bee46e88-30bcb065bfdso815986eec.0 for ; Fri, 16 Oct 2026 20:17:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1792207025; x=1792811825; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=WeN0lmGHanzlBT6I4estf/cTW+4Gl4FJbWILgGaJfb0=; b=ajmV5Y/AmsunrUTyCsKVNrtT5sQ2s6Zr0SBn6Cy0QK9vrIkC2FIYklabwQU9j1vSM1 qvxqi+px1wlAer1Wkdm/zOhmvDxw2aIHHSt7ZSWtuhnyY1VLhei8Z0NBNDYIQkjjKZss UL8sC74AfVbiRTfb6Qi4LE1Wdq8Kjn4RmREZD3ZOble+xnIfEc7PXyPyvkgxMQ1uXXgd urkdoyjU5xoIJk3AdpqbA+KDtbBmdaLeBXoRpWKvA2ldu0FHUHYizeyQKremOQZTjaze vTMGjkIQ9ZnrO4n0RGPlfs+7WzmqMID801xgQ5dgCgPZZjoPawRfb04sfpvlWqUbTbpp aYYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792207025; x=1792811825; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=WeN0lmGHanzlBT6I4estf/cTW+4Gl4FJbWILgGaJfb0=; b=yLvperYl2IWl0JQwaHZS8QZUPCMnAhW7nWPnusBtGp5y9PFn8yhuyhxbnzbJvu0JTB wVKvQTDsIFxolC4uRvraQ3xjSnD1Xtn4rGw5q+Hx8LciwUNoftWpPjRxfzpIqhjYstMR jxlwanh1hrE6rhxLPFFhQGFiYtyGQnDLiJXEgc7TMqPIACDbFdC/Sk/6bjyIMTPvMjyZ LcLyB3y6x9/iEy6k9aNSZuLoWJTIafbF7l75FZkC4CsPai8IfI3luN+A0+qisO4LyxRl bk+pwTXGw3z5b+BgPqsvoA1MkYBsQTTpOHDK+WUxejQe6n48UBTMIVoB92ptZwhlG36S tCfg== X-Forwarded-Encrypted: i=1; AKwUvBz3ZmoQ9u9Hr/Q8AJbBva5WzSRfIpMDj4aNNpV7NJPz9FEYtL0f7URanCh/FfC6nddjaekPRhA1KZB6N5w=@vger.kernel.org X-Gm-Message-State: AFq9FYJlA7cxkWhq2GLpQ0AKG7LqFgJxKuvyFHQi0eKl4rPa6SotSjQi K98aB1Gk8Wdj0zD12NyePKy0ZPhBWU7ntTwd+zgvUUj3iKjsmJ6IN2HlsopAbGlvoBbn1QaDIWG /nTJnabE9jhnhlXbVKHbN4UMjdXZ86GZBuORTl3snUrtdbpw1wtAjcSbevLozuCwh48c= X-Gm-Gg: AYBFou0Ed+b5f4dKZoxtjJsLWzHF/vvIwTBeiwz/kOSat+wmjh+7NyTDhEcRtmJ4Lt+ ShUTobOCWcSoIuFvWNmwizS2+IyRZ+vU0owJkAfgQRdzqaPYDZcS4fPF8iHNoNxukoYR11yksRm VBS3/wv08YArMNJlCuTqHK2x601wVKBEdTKn67W8BMvZJ0kXVWPb/NLve/cdRv2HreM7fpLU90B W9OdXnylNK08wVs56gTpsDMspcWHMT+0xvTltHz4aUpbByuq3GZ5jOnNxe0+RKexuCPxBndWtw2 S3Vdc23ChK1Uc1MnxFG6RH31g/A7UGLYAeu+2QX95wajzsj9Ima5DlCAxGhvIccszYMPfu03Dre HPU4SLdyHAAmVzlCkZCQpjrCPGGONj2PH2Q== X-Received: by 2002:a05:7300:7aa3:b0:35d:74f7:3b9 with SMTP id 5a478bee46e88-361a224ccf0mr2068934eec.33.1792207024593; Fri, 16 Oct 2026 20:17:04 -0700 (PDT) X-Received: by 2002:a05:7300:7aa3:b0:35d:74f7:3b9 with SMTP id 5a478bee46e88-361a224ccf0mr2068892eec.33.1792207023810; Fri, 16 Oct 2026 20:17:03 -0700 (PDT) Received: from hu-bvisredd-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3607ee0d391sm10969995eec.4.2026.10.16.20.16.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Oct 2026 20:17:03 -0700 (PDT) From: Vishnu Reddy Date: Sat, 17 Oct 2026 08:46:18 +0530 Subject: [PATCH 2/3] media: iris: Disable the system error work on removal Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261017-iris-handle-unbind-v1-2-7809148eb90f@oss.qualcomm.com> References: <20261017-iris-handle-unbind-v1-0-7809148eb90f@oss.qualcomm.com> In-Reply-To: <20261017-iris-handle-unbind-v1-0-7809148eb90f@oss.qualcomm.com> To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Stefan Schmidt , Hans Verkuil , Dmitry Baryshkov , Hungyu Lin Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Vishnu Reddy , stable@vger.kernel.org X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1792207006; l=1330; i=busanna.reddy@oss.qualcomm.com; s=20260216; h=from:subject:message-id; bh=hVspXbe0sCkaXoj1fe7zHKMem3/ix0mWkb/2R8o/yYA=; b=MzOE2vjbeiHAD8eMD5zXsT56tnSTVTzlFXQQT1BOO+Zx3e+Z8ZyDeIfKEqnB3r0LbyHgD0v2r kF4egV4YjHiAUS5MEQKXGec4ziYkcrP/dT30+2UTEOjfeCdrEsbEeHp X-Developer-Key: i=busanna.reddy@oss.qualcomm.com; a=ed25519; pk=9vmy9HahBKVAa+GBFj1yHVbz0ey/ucIs1hrlfx+qtok= X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE3MDAxMiBTYWx0ZWRfXx1gDWguNsNFb z5ES62aY7J64RQ1nVk9V0N2T/AxpFpp9YCiXinWjde+NYQtm83V9DD0w0LbsnFAO7ew9sB784N+ KriZopbwf6itbldyBgOz2tgfocXYZ3E= X-Proofpoint-GUID: WgiJ-7E6cvOslrUxXVNUWasr1MQ1xFOD X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE3MDAxMiBTYWx0ZWRfX9j/wUX3CcPPU n9fuia50L6qihKtCTrk48eh6NKEX8VLleRpMSGTDcpt7SRtVq10glPmSKkRn5Bq52F5FJEctmOO dtn/8MnjvlC9Ujxftis8UC/Dicg7aKYNs7BiY08jj43evXYZbgMY1RCKG5eloCazbqd/GwKYCMz gTeG/3nPFDACkFJYPjeTa/OTJrUnZTZhFx6Ruut+EtAyzxcIYwXLzE5cr6VTFu7ExZzrytVxTqa IaGcGgNsUsSXqZRMb7PiXHS7tZUfV0nl5JjRwBQoUbsd+TLInBQiJDlrsrS3VVq+exlsdNGl/5g Px7al07gzCBHED/87+CR+J5BhyQQ7HwTtu9L2tB53PfHSJA1cjvJrkNjkyZkFruHVIzJrw+kNZd QYyiWWiBz9RmbMxypTRWo7AAS4vaF6z4kWLN5ooE3Y1I5QqUH3tEp4pfnmL/PP7YzkLmxNZ7WKP cG6NuaE6U1qSVyYfDJA== X-Authority-Analysis: v=2.4 cv=COm/zhrD c=1 sm=1 tr=0 ts=6ad2e8b1 cx=c_pps a=Uww141gWH0fZj/3QKPojxA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=bZa8m19-NPAJ73ByzVcA:9 a=QEXdDO2ut3YA:10 a=PxkB5W3o20Ba91AHUih5:22 X-Proofpoint-ORIG-GUID: WgiJ-7E6cvOslrUxXVNUWasr1MQ1xFOD X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-17_01,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 phishscore=0 bulkscore=0 spamscore=0 malwarescore=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610080000 definitions=main-2610170012 iris_remove() calls cancel_delayed_work_sync() to stop the system error work. This cancels a pending work and waits for a running one. It does not stop the work from being queued again afterwards. A system error interrupt can still arrive after that call. The interrupt handler queues the work again. The work then runs after the removal and uses resources that are already freed. Use disable_delayed_work_sync() instead. Once it returns no new work can be queued. The work cannot run again during or after the removal. Fixes: 452480931648 ("media: iris: cancel sys error work on driver removal") Cc: stable@vger.kernel.org Signed-off-by: Vishnu Reddy --- drivers/media/platform/qcom/iris/iris_probe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/iris/iris_probe.c b/drivers/media/platform/qcom/iris/iris_probe.c index 41dec90f3e2b..4cb678bd56f0 100644 --- a/drivers/media/platform/qcom/iris/iris_probe.c +++ b/drivers/media/platform/qcom/iris/iris_probe.c @@ -251,7 +251,7 @@ static void iris_remove(struct platform_device *pdev) if (!core) return; - cancel_delayed_work_sync(&core->sys_error_handler); + disable_delayed_work_sync(&core->sys_error_handler); iris_core_deinit(core); -- 2.34.1