From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1DBF3BBFDE for ; Sat, 17 Oct 2026 05:19:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792214386; cv=none; b=GHXEHOrTGNqT5dwikT/q+t505hxamRGVCBL/dXNTh4cKkAka4UPe6Nw80mIGN0njoYwWp9CouwMfIM3mZFaNUh8U21NrL0MMUisKOoWjaVBN9FC80L0aBds3ghmttIaoX8XQ7ipwYXymg8O+oYHPVGedQFIbaw/ytioX2NF5aT0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792214386; c=relaxed/simple; bh=gXw+7TLfwGKFNKp/KJZijwrd5UKSHlNDKFQXo0yS+uM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Y1bvI0gCApoQ8A18tu9Eg6lX8yNz8TBCQNFnN0J5NnDIdewAEL9R1+ZQvzX/9dpVtLwFZ+z9gycOkuNwElobqUv2hPiNPBSEmk0UsK+CIyjV7DeUaq8i9oO8vKXlZojO1XiUve3L7P7seHXwOFCk3g6YgWLTDNZIuDeX/YOjV5Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FX9WQObf; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FX9WQObf" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-49d0da752ffso4173625e9.3 for ; Fri, 16 Oct 2026 22:19:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792214383; x=1792819183; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7LHcXjNkmsuk5TeKHntdBtjC9h0fmxosoVJ6Kahrwto=; b=FX9WQObfhOmxAA2cvIjLLoUklxaCKX/HIYaincyp8wlWq/t0jXptO+s8CFJxOAu5yD SpgjwF+G/isbSOTi+RO/Trzyn/rWbP4HBx6CektOst/cdt/NE8GaB3nV24MWH6GOy2Bt +FXRFjcBEt3Pbl2QtD8bUAfhGUSv3UQuMLYttYWrftfELF+CBCgagOJdCzoaQ9GdHX/U kSJNuT2xg8iQnd2fMYeLpIC0RVCtrSjlnptUD2QXw3dfl205VRszu9kAtZIcPhyw0yNT 8aV+U4H94kFxfdCSUyUamCZOFOko8ZsCz0WRVbcJIpwL7etzU5q3RP7kkqhkndsv4qBz CgVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792214383; x=1792819183; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7LHcXjNkmsuk5TeKHntdBtjC9h0fmxosoVJ6Kahrwto=; b=olsBAVfJmoHT6xFIoDnIhXG+LuiMRFWhmtoQGRBEQ3wo1tDYBIBHJ7u/olnKjjgUuL jvOPlLp2S5Y4nTAaE5q5Khs3UW7u+igkW6C9rqPO1yf0DGX3BndFzlnoHgOcmkvT9m39 YrEZBBntbK3OiEz4FCAaJcGqF0ewASVjf1pjQZPv+go+1fd3/9jrbF9v8wNOZiIeA3hv WTa0y61oMuwwbbfAu/gNnm0vNSbz7CXcxjC/yKesrr4IzRiodYewwe29fe/VY7Y/wHis F3MknXavAVdm0cNiH4fGv8DuXRFrtZtCVsOZaeBWUbcm0YnSsdH/tvi3taTUotuYeWAx wemg== X-Forwarded-Encrypted: i=1; AKwUvByApvunO2v0gPe1sUv/S78bgmyL+DCE56U9CDfqxPzE3l1g9nJURQVa8ED3q+Twb0LAa8XLfozPpKhYBFs=@vger.kernel.org X-Gm-Message-State: AFq9FYLLxH854EChBO2T03MWsupSgoBJdqvtp/6ylrVAkfjCLtFjTFQN SBHNa8j/eglAjRVq1ss44TbURi823g1uZqhSUYURloPBKKP62HuoX8Rg X-Gm-Gg: AYBFou2678IPmL/zQvpe/YsmO0F6ZAk7vKrCzGU56P5pcj07jNYlBD2n6+1o7hQl0rp ZcDhyfNY3Vy2kHKndkMszebYJ3FUxSvH2avbsiwZg0KKD+HyFRvols83Impw11W04bWJQG3hzMd 9KM6gw2SPASWvlkvovq0GhoPsIpKWyRa/imBigh2+WdeXfrXNHEBS2wA/2UAZou+Zp+AEU5aKjC PljjIK4Mm+uyxcHzdNXly6xxf3fPA3M4RFXvFOivxBiPIK9e9NgIr/aG3UzWZ01V0tLDKiwAbxP zuOBD/NGTV6DTWDIXNyIaaB+QvCGfHfY3JX+mXF1c5SVSbHZ85Wolpam3aSv+qsw9mxG0Wlut6M 6eeZLllygx0Cjb/JDuvWC92BeMhnXA3IR2zT7goERBOuYLEB7PLJO5KN2nvIe6SegoWrlVYQJwu zVPEUrQMzgtzLTpM7VfWYHmENIcBq72ij7LTST0+qK68W/Ht3HfQ/a3JWAv5PSfOkBoMhjpdtED 5xomR9C+dko0yEKKRvQkO96CcdyM2th/H4SNqKOm0hAUbsucxwfRk1b1ivHDknhVXyhyaSxZ0yM dRUnOfXsXs2yGaWfmPak9Ql4MZx8wbS/CbSpUhdlKJ2d9CqOtzp9cTfD/wd7agbqBhdvBrBL/An lIhZenTm3qLZVOpvyJemQ8GznVoYmaAi0yX7AypJN6iPU3cpW3WoE1FqPDMnNfojzzlw1Oj3k X-Received: by 2002:a05:600c:4e50:b0:4a1:76c9:5408 with SMTP id 5b1f17b1804b1-4a1d7600190mr43042945e9.11.1792214383002; Fri, 16 Oct 2026 22:19:43 -0700 (PDT) Received: from [10.200.7.52] (109-81-110-105.rct.o2.cz. [109.81.110.105]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a1dc952d63sm16432585e9.2.2026.10.16.22.19.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Oct 2026 22:19:42 -0700 (PDT) From: Joshua Crofts Date: Sat, 17 Oct 2026 07:19:20 +0200 Subject: [PATCH v3 1/2] iio: gyro: mpu3050: fail probe() on trigger registration failure Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20261017-mpu3050-fix-v3-1-d6f29f335a2b@gmail.com> References: <20261017-mpu3050-fix-v3-0-d6f29f335a2b@gmail.com> In-Reply-To: <20261017-mpu3050-fix-v3-0-d6f29f335a2b@gmail.com> To: Linus Walleij , Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Joshua Crofts , stable@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1792214381; l=1394; i=joshua.crofts1@gmail.com; s=20261015; h=from:subject:message-id; bh=gXw+7TLfwGKFNKp/KJZijwrd5UKSHlNDKFQXo0yS+uM=; b=mHpAFkWrfA2yHnFAXyecRF0dHDXXg+N36a08VbYhPaR87pLuFUd+4j7PO9AkSaIrj6R/h/CJR 6dxR+T2totYAKjlGrKSnwj7gvYY0lmuQosTz6vmzPr+n0wT0ZBdEO0O X-Developer-Key: i=joshua.crofts1@gmail.com; a=ed25519; pk=RTDOoVwgeL4oFdASj9U+cxJuIjXuXk73zkjnGOJKbEo= The current implementation lets mpu3050_common_probe() continue on trigger registration failure, causing the device to operate in an odd polling mode and making resource management harder. Jump to the error handling logic if the trigger failed to register. Suggested-by: Nuno Sá Fixes: 3904b28efb2c ("iio: gyro: Add driver for the MPU-3050 gyroscope") Cc: Signed-off-by: Joshua Crofts --- drivers/iio/gyro/mpu3050-core.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/iio/gyro/mpu3050-core.c b/drivers/iio/gyro/mpu3050-core.c index 07c0f9011c63..879caf3b729c 100644 --- a/drivers/iio/gyro/mpu3050-core.c +++ b/drivers/iio/gyro/mpu3050-core.c @@ -1231,8 +1231,10 @@ int mpu3050_common_probe(struct device *dev, /* Check if we have an assigned IRQ to use as trigger */ if (irq) { ret = mpu3050_trigger_probe(indio_dev, irq); - if (ret) + if (ret) { dev_err(dev, "failed to register trigger\n"); + goto err_cleanup_buffer; + } } /* Enable runtime PM */ @@ -1262,6 +1264,7 @@ int mpu3050_common_probe(struct device *dev, pm_runtime_disable(dev); if (irq) free_irq(mpu3050->irq, mpu3050->trig); +err_cleanup_buffer: iio_triggered_buffer_cleanup(indio_dev); err_power_down: mpu3050_power_down(mpu3050); -- 2.56.0