From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ishu Brar <patches@brar.si>
Cc: Bjorn Andersson <andersson@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Manivannan Sadhasivam <mani@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] remoteproc: qcom: pas: Add SM7250 ADSP support
Date: Sat, 17 Oct 2026 19:08:13 +0200 [thread overview]
Message-ID: <20261017-powerful-succinct-gorilla-d0f4b1@quoll> (raw)
In-Reply-To: <20261016-adsp-sm7250-v1-2-2f39ac1f0496@brar.si>
On Fri, Oct 16, 2026 at 01:50:19PM +0530, Ishu Brar wrote:
> The SM7250 ADSP uses the same PAS ID, crash reason SMEM item, SSR/sysmon
> names and proxy power domains as the SM6350 one, so reuse its resource.
>
> Signed-off-by: Ishu Brar <patches@brar.si>
> ---
> drivers/remoteproc/qcom_q6v5_pas.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
> index 2e1e39826..365f4fa5b 100644
> --- a/drivers/remoteproc/qcom_q6v5_pas.c
> +++ b/drivers/remoteproc/qcom_q6v5_pas.c
> @@ -2046,6 +2046,7 @@ static const struct of_device_id qcom_pas_of_match[] = {
> { .compatible = "qcom,sm6375-adsp-pas", .data = &sm6350_adsp_resource },
> { .compatible = "qcom,sm6375-cdsp-pas", .data = &sm8150_cdsp_resource },
> { .compatible = "qcom,sm6375-mpss-pas", .data = &sm6375_mpss_resource },
> + { .compatible = "qcom,sm7250-adsp-pas", .data = &sm6350_adsp_resource },
This actually suggests devices are compatible, so should be expressed
with fallback and this is not necessary.
Best regards,
Krzysztof
prev parent reply other threads:[~2026-10-17 17:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 8:20 [PATCH 0/2] remoteproc: qcom: pas: Add SM7250 ADSP Ishu Brar via B4 Relay
2026-10-16 8:20 ` [PATCH 1/2] dt-bindings: remoteproc: qcom,sm6350-pas: Document " Ishu Brar via B4 Relay
2026-10-17 17:07 ` Krzysztof Kozlowski
2026-10-16 8:20 ` [PATCH 2/2] remoteproc: qcom: pas: Add SM7250 ADSP support Ishu Brar via B4 Relay
2026-10-17 17:08 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261017-powerful-succinct-gorilla-d0f4b1@quoll \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=patches@brar.si \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®