From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D20A3DDB0E for ; Sat, 17 Oct 2026 09:45:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792230339; cv=none; b=Noy2qoOMG5p9KLcm3v8sAKOYjRwShg6dQknoOIVofIToOGZn6ZdusxvzQyPbK6eOuFuYTikFzsh0L02QjgGh9CpPuYOXA5JRFPs2Si9IQjHv6DKnFXmruKZNvhjSJkk452O6LbrxGd0kU3/cMwMKMO8/ITgrVGBZH7Uj+f8c2C8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792230339; c=relaxed/simple; bh=IYXfTVPMCK/el0CMUANPRO8OaG4Oym+gcs0IAqN8PEE=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=Ydj4qtKpcMdDVSWH0KrP+5zri7ceNNx+h3Nm2QfiuxZPeAcORv1dWQlfMo0VhteaEWi/3Hp17FkMzkI4azI2BPz0K1voa6/tQ5VhJJ7c4QwGC9X7YQiT7L5qmkSVnpRpN0bBer7iqIEqdd4UUsIN5LmNDHP0AMJ/YyNTRd6NBN4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=J7Bbt3X2; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=CttGRT6n; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="J7Bbt3X2"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="CttGRT6n" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69H6o1Dx1402762 for ; Sat, 17 Oct 2026 09:45:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=XMZcfz/11DnDHLN5NSRKwY jq0JKQ8gstJmfqFEICHQ0=; b=J7Bbt3X2LT9eYAy3C3H4CKUnK/KXG0ARnRqhbv DQ5QLIJ/y5x7/sniek3WAP9y+SBY8a78JAPBFcnGWLtVAuKBDKnfSd/HBweSEtz0 UGoBQle51wScUN7pcRtresLvxTU/AdQUPHlqjlLcNjN+93JhKPTCBJPLr38+mqcr GjpuqczOD1XkhibkFA90XbC9/wre29B2QX/w2uXw/KIWEOYKVLORIQ71EuVGu1Si sSCJnhFgisbgyMnsEDKd4m/xm9YxaPQXCqC4C+WoBJXDonUCXEdbAQroN4tEifc3 +vKsPREHgG19SZ/zUsrzDa93BiMd1lsoKJmOQC5m6eVQRPzA== Received: from mail-dy1-f200.google.com (mail-dy1-f200.google.com [74.125.82.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hbyys0s93-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 17 Oct 2026 09:45:35 +0000 (GMT) Received: by mail-dy1-f200.google.com with SMTP id 5a478bee46e88-35a4d2e39acso3740522eec.1 for ; Sat, 17 Oct 2026 02:45:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1792230334; x=1792835134; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:content-type:mime-version :message-id:date:subject:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=XMZcfz/11DnDHLN5NSRKwYjq0JKQ8gstJmfqFEICHQ0=; b=CttGRT6nvRVqTV0ldnqiPZSvbeeowIaJC5n3PqHRrFVZM7km+3Uf/7DZK9N2bbrlrZ VobkMTkB7U/k6rZNVsSO2iNvsCztQ5iX9dgXcDd0r/2y0JTEfVLa4/TvJ0GSpq1CT35N fDZlFPw5ff259yixnFqmEQpHCqn+Z4VyFVCuudcEZhjlzBUmAtOQUYW2d/+9zoDpeIyo DW6hLa/e3mjrg/fxM05ZzuOB4AAhzZJ3zu3dLKJPy2YiPCov/gd7r4F56fP4lw9vTaXO s4XQvfJfqKiBWpCurr4QGDunBzk/rodmMulIZGsLXBkDvFA2omGElmHuRLj65bhFmNSa 4KOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792230334; x=1792835134; h=cc:to:content-transfer-encoding:content-type:mime-version :message-id:date:subject:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=XMZcfz/11DnDHLN5NSRKwYjq0JKQ8gstJmfqFEICHQ0=; b=QFAcjZaNjKFYds+0asf6tSXzyMivf+NPlgq7nYdOxHEX+8vQRuiSndu7lF6ciDIHr9 T3qFbYe/8HXSJhaEigx9pd+hPkz3kcHE6pwB1SmIMwvYstz67pFeevOCKsQKQFh8itYQ ap/WAhuhhOZwrA+LEGX+k1rihhi7NB0dc3ic38W0A82TM2giuYu5xPh3+iX7KL+vMQOu 3pu3HsVUMUVsMXCnJdWYkITh9yydm7dxai8OMC8UQbfd6RRdsdOyG5eoKoziq/+l3g1q ZI184aWcnfEav/N1OH8r6nMiJ25rkAlxuYPh84n9n73Euu0/J64vRRCTVy3S/+iUsIoM Y1nw== X-Forwarded-Encrypted: i=1; AKwUvBwPzZg0fk8xz/byIUMmHS7qUGQ45qhvaX1qUr7J5zNQzsNZ0bA1z4klFxJz/TVNCjRTkR+a+X3+LyGW1rA=@vger.kernel.org X-Gm-Message-State: AFq9FYJ/ezS4GqmxE0R4YvEbGXKDwWTwekUt7W7IGzOCqVvBdXFGAE0Z SpOdp0G2CMiubEqdQWvCheC1/ZUkY9alkDIvO+bqqhU5mKtJzRd7JauMCHEkAWggDkerAnvsptD ZicFtrFkcFIv7UZLv4za2bqQ8zUe8rdgwjIrktlpQn9SHM5CTJ+eU2FYOthdV8/q4u/U= X-Gm-Gg: AYBFou08egsKqfznS4tiU/3JBr/+L+IK2syryOc7LzXuCiWmT6drrB19a+8qknGIqT0 1TODs9eIxWeOd3Qs8y7Imw8+KgLL+CumnOilSPBf8Ap46GlJbY72Aj7Wwux/fXFpp9H2oue87WL H2aQH/Tn4V4nkGSB5IS/G1NRiek+w7FYr/HbRwYkA5HvQRELKAWIMZ9HR8S4MKc+ypEftYIFDc7 5ukRY/0dO9OtBXs8wpvl3lkAccGIElS5eOAh3R/+pE3RkMGyeDkBIVGLlBdip1JLeXA7/u2brnP 3dzppfSGc5QS5VWFsr39cm4kW8DSGCo/fLEW4BNoV9WOlc+VAyq/2WrgCpP8kJukPYJwBRLi7vT /hBTWuwkEc6PhiAYyY+zGbOYUia6hDg== X-Received: by 2002:a05:7022:ea44:b0:181:83c:5df8 with SMTP id a92af1059eb24-1851238b3e7mr3256401c88.11.1792230334191; Sat, 17 Oct 2026 02:45:34 -0700 (PDT) X-Received: by 2002:a05:7022:ea44:b0:181:83c:5df8 with SMTP id a92af1059eb24-1851238b3e7mr3256364c88.11.1792230333493; Sat, 17 Oct 2026 02:45:33 -0700 (PDT) Received: from hu-mohdayaa-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1831a6f58c2sm19450327c88.11.2026.10.17.02.45.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Oct 2026 02:45:32 -0700 (PDT) From: Mohd Ayaan Anwar Subject: [PATCH net-next v3 0/9] net: stmmac: qcom-ethqos: add Shikra EMAC support Date: Sat, 17 Oct 2026 15:15:11 +0530 Message-Id: <20261017-shikra_ethernet-v3-0-26a8beb44b8f@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAKdD02oC/23NQQ7CIBAF0KsY1tJQKLR15T2MMbQdhWhBAUlN0 7uLxIVJ3Uzy82fezMiD0+DRbjMjB1F7bU0KbLtBvZLmAlgPKSNKqCAtYdgrfXXyBEGBMxCwhLo D4NCQClC6ujs46ymLB/RZMDAFdEyN0j5Y98qvYpn7r1qt1FhigiUnteBtKwjje+t98XjKW2/Hs Ugjk5H+Ms2aoYnpOmCsaQciOP3DLMvyBuIZ4qoGAQAA X-Change-ID: 20260903-shikra_ethernet-ae7bee5e804e To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Davis , Andrew Lunn , Heiner Kallweit , Russell King , Richard Cochran , Bjorn Andersson , Konrad Dybcio , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Maxime Chevallier , Maxime Coquelin , Lorenzo Bianconi Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Mohd Ayaan Anwar X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1792230324; l=5696; i=mohd.anwar@oss.qualcomm.com; s=20250907; h=from:subject:message-id; bh=IYXfTVPMCK/el0CMUANPRO8OaG4Oym+gcs0IAqN8PEE=; b=ioR6csnsJjP5p1t3JOpR3QmMOEtM7iEG5xSslMTKkeP1bLZ2CK60dEg9coNaeJ0xD92rmPXMv Bsujezmf7QABhibFvmlczlo6A6SR9z8A0OYYj6Z1ef5kUZQ2Q9TPvMB X-Developer-Key: i=mohd.anwar@oss.qualcomm.com; a=ed25519; pk=7JNY72mz7r6hQstsamPYlUbLhQ5+W64pY4LgfSh9DJU= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE3MDAzOCBTYWx0ZWRfX9L2R/bSeIRfj ghhI0kzi8/7ADtbCSKG0rILp5pLcjRumeDwbx3hk3yd0i9swXk6GkLyPA8yLORL4fpnxDrqMkmm EG9vfXAwbonp8MQaOM0T1ef2Hophc5Ft/UD8jd0aLiOWtzHCUdQMU7tOvRfGQipW6g3C+osbgj9 rIQanUBpdla12yYfA107W/F9Q36/M+XPWDSikHKSL+UBfjNep4nrgatoEtBZAYHOHBhvhlbqCR9 ZVxRuKe5f6IXLUkQlhgNGvlYduuKG/JVN5QGvHiW5QczI8kn7REFcXfKtUKlvIjtjjeq/kjC/m+ A295g0xwBvTCtqn0B8yfjf6ppw1jdL/ALsglh1j+Bevrh1zkJMqeQMA8r7k69f0k1G5ObcbuLls 1qfHHOrCc6ib/i1d7xdLnaJ3sViqpp+WVs6jIWLhLGvYcXD0vt+aaex3U39aw/dKkcUCOmTJBH4 hTQPO8rEcm/GuD8Ujnw== X-Authority-Analysis: v=2.4 cv=W4WtxhWk c=1 sm=1 tr=0 ts=6ad343bf cx=c_pps a=PfFC4Oe2JQzmKTvty2cRDw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=VwQbUJbxAAAA:8 a=ee_2aqc6AAAA:8 a=EUspDBNiAAAA:8 a=oTwP7VKmK1vJnwN5z0oA:9 a=QEXdDO2ut3YA:10 a=6Ab_bkdmUrQuMsNx7PHu:22 a=VOpmJXOdbJOWo2YY3GeN:22 X-Proofpoint-ORIG-GUID: JQIc0pkHabdtZVA0vG1JZRnJQt18A2K9 X-Proofpoint-GUID: JQIc0pkHabdtZVA0vG1JZRnJQt18A2K9 X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE3MDAzOCBTYWx0ZWRfXwjgMesFlAsiJ eeteDH+rimblp3LGhilGf0JdgnT95XShiXBjvCyGKFTI1udH0wOOLdzj0sqNbyioiLJG6jdhsKL xo7d5ZHjyfoRlt0J1BOCU/gFJXbEVV0= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-17_02,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 malwarescore=0 phishscore=0 adultscore=0 priorityscore=1501 suspectscore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610080000 definitions=main-2610170038 This series incorporates feedback from the RFC and adds the dt-bindings and driver changes required to enable Gigabit Ethernet support on the Qualcomm Shikra SoC. DTS changes will be sent out separately. The series has grown from the RFC and can be broadly divided into three areas: PHY power supply management, proper support for RGMII ID mode in the Qualcomm ETHQOS driver, and Shikra specific clock dependencies required for NOC access. 1. Shikra EVK boards use a GPIO-gated regulator for the DP83867 PHY power supply. Patches 1 and 2 add supply management to the DP83867 driver so the PHY driver holds the regulator vote at probe. These changes are largely inspired by similar work done for the QCA8081 PHY: https://lore.kernel.org/netdev/20261015143849.483339-1-elder@riscstar.com/ 2. The generic RGMII fixes from the RFC remain. As suggested, an additional patch now emits a warning (patch 6) when the legacy "rgmii" or "rgmii-txid" modes are detected. A new change (patch 7) now initialises the RGMII link clock at SPEED_10 on probe instead of SPEED_1000, dropping the unnecessary 250 MHz source before link up. 3. NOC clock voting (patch 9) now uses dev_pm_opp_set_opp() so the required VDD_CX performance state can be propagated through the clock controller. The Shikra binding (patch 3) is updated accordingly: an if/else block constrains Shikra to exactly six clocks and requires operating-points-v2. Testing: The following boards have been tested with this new (proper) handling for RGMII ID: - Shikra CQ/IQ variants (with the TI DP83867 PHY) - QCS615 Ride (with the Micrel KSZ9031 PHY) - Talos EVK (again with the Micrel KSZ9031 PHY) - Talos Lyra EVK (TI DP83867 PHY, this board also has a GPIO-gated regulator for the PHY power supply) Changes in v3: - Remove #ifdef CONFIG_OF from the dp83867_power_on() function. This is a result of the recent discussion regarding similar handling in the qca808x driver: https://lore.kernel.org/netdev/atCSWZQAyqvz62_K@aspen.lan/ - Clean up the -ENODEV handling in dp83867_power_on() and use a boolean to identify if supplies are provided -- Lorenzo. - Patch 7's commit message now says set_clk_tx_rate instead of fix_mac_speed -- Sashiko. - Add a new patch to abstract away the common dwma4_addrs for different versions of ethqos rather than duplicating them -- Lorenzo. - Use OPP table to set both the required clock rates and power state, update ethqos bindings accordingly to specify how the clock rates are described in DTS -- Konrad, Lorenzo. - Link to v2: https://lore.kernel.org/r/20260908-shikra_ethernet-v2-0-bbe3389d0652@oss.qualcomm.com Changes in v2: - Collected Maxime's Reviewed-by tags. - Updated Patch 9's commit message to explain the double enable vote on the "stmmaceth" clock. Open to discussion on how best to handle this. - Wrapped regulator vote for dp83867 inside an #ifdef CONFIG_OF check to avoid adding an unnecessary 200 ms delay on systems where devm_regulator_get_enable_optional() would return 0. The change now mirrors the QCA8081 patch -- Sashiko. - Fixed ethqos_set_clk_tx_rate() to double the rate for all PHY modes other than RGMII-ID -- Sashiko. - Moved warning about the use of non RGMII-ID mode to probe instead of fix_mac_speed to avoid spamming during each link up event -- Sashiko. - Fixed error unwind drops OPP before stopping link_clk -- Sashiko. - Fixed OPP vote set in probe not cleaned up on error -- Sashiko. - Link to v1: https://lore.kernel.org/netdev/20260904-shikra_ethernet-v1-0-a50765996035@oss.qualcomm.com/#t Changes since RFC: - Two new patches add supply management for the DP83867, replacing the gpio-hog approach for PHY power -- Konrad, Andrew. - Use dev_pm_opp_set_rate() for the NOC AXI clock and require operating-points-v2 for Shikra -- Konrad. - Warn on legacy "rgmii"/"rgmii-txid" to encourage DTB migration -- Andrew, Maxime. - Updated binding document for qcom,ethqos and snps,dwmac. - Drop the duplicate "axi" clock from Shikra's DT; use "axi-noc" and "pcie-tile-axi-noc" as the only additional clock-names. - Initialise RGMII link clock at SPEED_10 rather than SPEED_1000 on probe. - Link to RFC: https://lore.kernel.org/netdev/20260612-shikra_ethernet-v1-0-f0f4a1d19929@oss.qualcomm.com/ Signed-off-by: Mohd Ayaan Anwar --- Mohd Ayaan Anwar (9): net: phy: dp83867: add regulator supply management dt-bindings: net: qcom,ethqos: add qcom,shikra-ethqos compatible net: stmmac: qcom-ethqos: convert ethqos_rgmii_macro_init() to void net: stmmac: qcom-ethqos: fix RGMII_ID mode to use DLL bypass net: stmmac: qcom-ethqos: warn about legacy RGMII PHY modes net: stmmac: qcom-ethqos: set initial RGMII link clock to lowest speed net: stmmac: qcom-ethqos: share common GMAC4 address table net: stmmac: qcom-ethqos: add per-platform NOC clock voting net: stmmac: qcom-ethqos: add Shikra EMAC support .../devicetree/bindings/net/qcom,ethqos.yaml | 55 ++++- .../devicetree/bindings/net/snps,dwmac.yaml | 2 + drivers/net/ethernet/stmicro/stmmac/Kconfig | 1 + .../ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 259 +++++++++++++++++---- drivers/net/phy/dp83867.c | 32 +++ 5 files changed, 297 insertions(+), 52 deletions(-) --- base-commit: 8b71f1f5a28347cefb1a4711c4eeb492d5c619fb change-id: 20260903-shikra_ethernet-ae7bee5e804e Best regards, -- Mohd Ayaan Anwar