From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F367215161 for ; Sat, 17 Oct 2026 09:45:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792230347; cv=none; b=FdBsxmBKIA+I3fjBPYDbbQWmfEjJsmllYe0t0un5s1S/C8MYK++bAfMar/g6DX0+izf1QD3Gw2lPDv7aGmPuYp1BaP996nBF4CXmWKJo0GJalbbl4SKYlYB+OoU7P8j6xAO8Ixue5jHumDvyMo0fZACReza2xARStzzity25R5A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792230347; c=relaxed/simple; bh=WVSHBlAoKrJDFHjSHgKUOHwT3ILmdd9Bv1++uwfX2CM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=E/p2ez7/jqc9e5eGXe/eTvtDalcn0yQLaH3iO3W7UzTBSE5x7hMVEm0X+ZMwXhhphPk8TSxoWO9CY306jbfduJ+2d/FOonWKvpHWha3omuqq3s7TPbeaF93w7nmz8hK+YFkMPwDqKgvEWhBMCADGoEtSstmMZkewLZhgMSPoWvs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=is91o+ea; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RgGFWfrg; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="is91o+ea"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RgGFWfrg" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69H6o2ML352078 for ; Sat, 17 Oct 2026 09:45:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jzE/Q16vHCGMwmevYtx35ZN8QzUMpEh2gX+wjYeXZXI=; b=is91o+eakQSvu+YA 41mkYzQVs3UllcmUPE4QHpGVa5esOKREV7CLOZPkeeChuCtbLE3qqAg3Yu687bac UWV9ZbyDMMVKkI7z37vW94ZYuDCqc2v5jDC8bb40/DUXa0wSfc5P49314X0T1Bl4 I/kvJppeQ/ic+wEFefBC2//GJVsmQDvgjTvyYJAUWSw0AbhqqGgZfAPCn1AcrsoF dXsmUYW6/E7AMC3K/ha9dzBgsBSwSYrzJYnXnwfuPctCyRKlWEI7yWw49JjRoyGp 1sQDttekEU8l9euXMadYPIE+17QXZ530cnEfC2CioXnpcgqty00HN+dzq9pK20Zi KgY2nA== Received: from mail-dl1-f70.google.com (mail-dl1-f70.google.com [74.125.82.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hc13urmn2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 17 Oct 2026 09:45:44 +0000 (GMT) Received: by mail-dl1-f70.google.com with SMTP id a92af1059eb24-152d1363a29so2688092c88.1 for ; Sat, 17 Oct 2026 02:45:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1792230344; x=1792835144; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jzE/Q16vHCGMwmevYtx35ZN8QzUMpEh2gX+wjYeXZXI=; b=RgGFWfrgIZjlrHhsZmaTCX5NDiJxmQb34abYSEpRI7U2y1k0Q2RcxUY8nJyAzjA19c yM3QA+nzzborSTV3m/LNynOycRatGwrzFmcJfpwguiNMKAg9y0OZ+JyV4XvDAACr24iQ nMvYAEhRziH2SnYXOHGBu3CAt2GogfTQig6WD7Wh1qYZE6gvVed8Xgo7I2bHhf/jv20z MSZ//XtaGfhP0bToke/0bu0/pfSFCT0rmCOEH0xhdtKqL3koTBQ8hTgvChlupNxbjAmG Yo5BgY7aBg8AU5x8VVutklilSfl3+zqyAnMcz4sBLqcHehGu5ckWuk7CySOZV7LnHHy/ RPjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792230344; x=1792835144; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=jzE/Q16vHCGMwmevYtx35ZN8QzUMpEh2gX+wjYeXZXI=; b=CD4ocrTMzQPVgllDDQ3afmb8GGwtw5s/uHfRGEIFf8aW9wSrsu0Cnya0ff2Yq7h16T rrFHhxUfdrBAHXBOH6hZqGHHSpnc8NpGuTAVEBdH4jZlHTKiSVa2E/mIy+1lFJ34Tfna iQGZ050gLLd3XFrWpgST+Rx1ru8A/tr+jbLqeVgjfSHFspZIKCldT1tY/fOYpm5orgty iM1hNS746p0f9qBEsXvzayDaFnMSP8XFP2UXEQGPpPGVtaCVGOB8WdN6ps2zGLJRTTIe 6UkOnssr2oMETw3/T6OcC862YYg1FC4SE1/oIHCgVUha2U5KWDGg0PgUn6fWhFxRgEDr ypuQ== X-Forwarded-Encrypted: i=1; AKwUvBxdLFCv6LZgBeO6MUR3yWHO/iyDXxyUYT/3LSY6/ntftbcaOQ61OHMzqchLSn0fK42lk75j6+AVkSYVF4s=@vger.kernel.org X-Gm-Message-State: AFq9FYIGOwh4MefaUOu0CrQ9YkXJFaRsZv37hNlyVegabFyMp0JdeIKl Bwy0+xEdVAdfv3rUrDi1t62X98jTOT+mCru42dJFuQuCf31SILER2/LpW1fJ28jBX1jcagxJ5D9 Hwb2fnNH8Zjj05NKpWC5o8i/6B1XklSYyBOM605qp+fA638knGrZ2TMiSZ7PScEsGGJ4= X-Gm-Gg: AYBFou1cS5gtOf3GEiw1/UwlE8BsyP9vyw1GdUQnI6OvGePAXbp3/1Uv1CT9B69Sw53 yiR/zTZESAIO0Sfowdhg/SitYOZomcHb37PNmn+Qb9Ty6Wct88zfZb7tXfrJ8Se63+AVoM6ouZy uzo+gzU6RyWno3SDQAcjMMqtOB3IqJ/bhxVSAv5W2zBpxJN6TdaH/GVRcnCdL1sDQBFQK0D2t85 QVyMBkc0PGzoEd+C3oI7H8rfpDD45em3yRSgtEzD/gfzjq5XDu3JDxdn/JqmfpWBdJ5Hex4bAaj 4my1wJcYmGADL+Ium6yLXi1nb5nqfO5T6r9yztfLp1z2u9EA8oFrzjeSieukCQ3HoqFEQ27jttR o0Pm9/a/0tvpcpE6sPkQglFkMFrniSQ== X-Received: by 2002:a05:701b:204a:20b0:14e:cc3a:9f32 with SMTP id a92af1059eb24-18511ad88f3mr3460874c88.7.1792230343736; Sat, 17 Oct 2026 02:45:43 -0700 (PDT) X-Received: by 2002:a05:701b:204a:20b0:14e:cc3a:9f32 with SMTP id a92af1059eb24-18511ad88f3mr3460812c88.7.1792230343061; Sat, 17 Oct 2026 02:45:43 -0700 (PDT) Received: from hu-mohdayaa-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1831a6f58c2sm19450327c88.11.2026.10.17.02.45.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Oct 2026 02:45:42 -0700 (PDT) From: Mohd Ayaan Anwar Date: Sat, 17 Oct 2026 15:15:12 +0530 Subject: [PATCH net-next v3 1/9] net: phy: dp83867: add regulator supply management Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261017-shikra_ethernet-v3-1-26a8beb44b8f@oss.qualcomm.com> References: <20261017-shikra_ethernet-v3-0-26a8beb44b8f@oss.qualcomm.com> In-Reply-To: <20261017-shikra_ethernet-v3-0-26a8beb44b8f@oss.qualcomm.com> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Davis , Andrew Lunn , Heiner Kallweit , Russell King , Richard Cochran , Bjorn Andersson , Konrad Dybcio , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Maxime Chevallier , Maxime Coquelin , Lorenzo Bianconi Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Mohd Ayaan Anwar X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1792230324; l=2447; i=mohd.anwar@oss.qualcomm.com; s=20250907; h=from:subject:message-id; bh=WVSHBlAoKrJDFHjSHgKUOHwT3ILmdd9Bv1++uwfX2CM=; b=UQBsoFxKJfv5tbLctgXh4QAgGFocXPnjAeq6p48mkcMMGBNr5pjE5YFrDHwIxZnoEKYFdwpl/ C2zcyKxXDyeC2ggJgEVgQUe783OQ7JesLTnG1GO4YI46rkrkIm9ShMT X-Developer-Key: i=mohd.anwar@oss.qualcomm.com; a=ed25519; pk=7JNY72mz7r6hQstsamPYlUbLhQ5+W64pY4LgfSh9DJU= X-Proofpoint-GUID: bBpeAZinWXli530F33kMHoXRK17kv5J0 X-Proofpoint-ORIG-GUID: bBpeAZinWXli530F33kMHoXRK17kv5J0 X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE3MDAzOCBTYWx0ZWRfX6MM8s9n9nNWU Jt5ekUOj9rHCS8vrEXujfOG6rz+mLYgT9pni5zcf4EIoGwU0ONqnLxDtPfJXENj5fsibgOkNDq6 msc/nwatiLj9+8jz3DOaDypXJwfDpbA= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE3MDAzOCBTYWx0ZWRfX+FNiF3QB0Lyr mOX/jIdRJJTZKNgV0pSenP34ziqci5TmW7vJVGydhIk0RF+B4U9+LbaLdLONZ3Gy9HlEo8PseA+ RPwhgqWiUlODH6HqyaoGLWuKToR0RJRh2Wh9jvyub+sJbdPJY+og80XFreWfCNp2fk2B99Dy9o8 eDArFocFjZfftqbbf6Qo4aPwPD2p+JpCMXnnHdNgiuyAZK+uq/4NkFtn3J9aI36yjI6a8zluxK8 7vSoY0x1Oq5bReFtxj9l18rIe8MAasKbBmMaO6C8wZO+du8blcK8JnExHDxFI6jFMu2UV07FYxS qs8oh/Lq04iceSmHnV9S4g7TRsjqGmOnCgsiaoH3xvBpqEhJ/Yk/1sXCN5d/MxI2x/10Gr/sn/y a/UbNdKgv/XSuGaFCSscfHKz9wqT1euwWN8G6naZCxcJZWBfMFljVTLJJupKqgVTpAQUSgcPxAx TTPa0kidCKYlhBo24/g== X-Authority-Analysis: v=2.4 cv=SKzXx+vH c=1 sm=1 tr=0 ts=6ad343c8 cx=c_pps a=SvEPeNj+VMjHSW//kvnxuw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=sozttTNsAAAA:8 a=uuhe7hOpKvpPPjRdXc0A:9 a=QEXdDO2ut3YA:10 a=Kq8ClHjjuc5pcCNDwlU0:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-17_02,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 impostorscore=0 spamscore=0 suspectscore=0 phishscore=0 priorityscore=1501 bulkscore=0 malwarescore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610080000 definitions=main-2610170038 Some embedded board designs use GPIO-controlled regulators for the DP83867 power rails. Add dp83867_power_on() to enable all four supply domains at probe time. Absent supplies are silently skipped, so boards that do not describe them are unaffected. When any supply is newly enabled the driver sleeps for 200 ms before returning. This satisfies the post power-up stabilisation requirement mentioned in section 6.6 of the DP83867E/IS/CS datasheet. Acked-by: Lorenzo Bianconi Acked-by: Andrew Davis Signed-off-by: Mohd Ayaan Anwar --- I have kept the Acked-by's since the overall premise of the change remains the same between v2 and v3, please let me know if you would like me to remove them. --- drivers/net/phy/dp83867.c | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c index a3cd5cb11ea0ac108219e05d990b378483b67d7a..092bc68bb9bc6561e2457f596206453dd84e56fc 100644 --- a/drivers/net/phy/dp83867.c +++ b/drivers/net/phy/dp83867.c @@ -16,6 +16,7 @@ #include #include #include +#include #include @@ -730,11 +731,42 @@ static int dp83867_resume(struct phy_device *phydev) return 0; } +static int dp83867_power_on(struct phy_device *phydev) +{ + static const char * const supply_names[] = { + "vdda-2p5", "vdd-1p0", "vdda-1p8", "vddio", + }; + struct device *dev = &phydev->mdio.dev; + bool supplies_enabled = false; + int i, ret; + + for (i = 0; i < ARRAY_SIZE(supply_names); i++) { + ret = devm_regulator_get_enable_optional(dev, supply_names[i]); + if (ret == -ENODEV) + continue; + if (ret) + return dev_err_probe(dev, ret, + "failed to enable %s supply\n", + supply_names[i]); + supplies_enabled = true; + } + + /* Datasheet section 6.6 suggests a 200ms post power-up stabilization */ + if (supplies_enabled) + fsleep(200000); + + return 0; +} + static int dp83867_probe(struct phy_device *phydev) { struct dp83867_private *dp83867; int ret; + ret = dp83867_power_on(phydev); + if (ret) + return ret; + dp83867 = devm_kzalloc(&phydev->mdio.dev, sizeof(*dp83867), GFP_KERNEL); if (!dp83867) -- 2.34.1