Re: [PATCH v2] iio: afe: rescale: always expose offset

[Jonathan Cameron <jic23@kernel.org>]

On Fri, 16 Oct 2026 13:00:20 +0200
Andrea Amer via B4 Relay <devnull+and.amer.gmail.com@kernel.org> wrote:

> From: Andrea Amer <and.amer@gmail.com>
> 
> A rescale channel advertises IIO_CHAN_INFO_OFFSET only when its own
> offset is non-zero. A child rescale therefore hides a source offset,
> and consumers apply raw * scale and drop it. rescale_read_raw() already
> folds the source offset in, so expose the attribute in every case.

Hi Andrea,

Why not check if there is either an offset in the rescaler or the underlying
device? iio_channel_has_info(schan, IIO_CHAN_INFO_OFFSET) is used just above
an should tell us that.

If neither are present I think we can continue to not present that attribute.

Thanks,

Jonathan


> 
> Fixes: a29c3283653b ("iio: afe: rescale: add offset support")
> Signed-off-by: Andrea Amer <and.amer@gmail.com>
> ---
> Changes in v2:
> - Keep the IIO_CHAN_INFO_SCALE line unchanged (Andy Shevchenko)
> - Link to v1: https://lore.kernel.org/r/20261012-iio-rescale-offset-v1-1-14ed15979ff2@gmail.com
> ---
>  drivers/iio/afe/iio-rescale.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/afe/iio-rescale.c b/drivers/iio/afe/iio-rescale.c
> index 3a6a09ffa5267ddfd5131fbd04a5df928836589d..4639a67ea462bf5c29603783a6f230d769fb02b0 100644
> --- a/drivers/iio/afe/iio-rescale.c
> +++ b/drivers/iio/afe/iio-rescale.c
> @@ -301,11 +301,9 @@ static int rescale_configure_channel(struct device *dev,
>  	}
>  
>  	chan->info_mask_separate = BIT(IIO_CHAN_INFO_RAW) |
> +		BIT(IIO_CHAN_INFO_OFFSET) |
>  		BIT(IIO_CHAN_INFO_SCALE);
>  
> -	if (rescale->offset)
> -		chan->info_mask_separate |= BIT(IIO_CHAN_INFO_OFFSET);
> -
>  	/*
>  	 * Using .read_avail() is fringe to begin with and makes no sense
>  	 * whatsoever for processed channels, so we make sure that this cannot
> 
> ---
> base-commit: a3b3580713f3ac5a32dc2874ee546828977a1d68
> change-id: 20261012-iio-rescale-offset-41254a33b6d6
> 
> Best regards,