mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Amirmohammad Eftekhar <amirmohammad.eftekhar@cispa.de>
To: <seanjc@google.com>
Cc: <pbonzini@redhat.com>, <kvm@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [BUG] KVM: x86: Hyper-V VP-assist page reuses the KVM PV-EOI gfn_to_hva_cache, so enabling both WARNs and fails KVM_RUN
Date: Sat, 17 Oct 2026 18:33:52 +0200	[thread overview]
Message-ID: <20261017163352.4006-1-amirmohammad.eftekhar@cispa.de> (raw)
In-Reply-To: <20261017093016.32348-7-amirmohammad.eftekhar@cispa.de>

Agreed, the stopgap looks right. Gating kvm_hv_get_assist_page() on
vcpu->arch.pv_eoi.data.len >= sizeof(struct hv_vp_assist_page) avoids the WARN
cleanly: when the shared cache is set up for PV EOI's single byte, the
VP-assist read is treated as inaccessible, with no need to untangle the shared
pv_eoi.data storage. And I agree making both features work at different GPAs
isn't worth chasing.

Would you like me to send this as a formal patch, with your Suggested-by,
tested against the reproducer (both features enabled at different GPAs,
confirming the WARN is gone and a well-formed VP-assist still reads back)?

Thanks,
Amirmohammad

      parent reply	other threads:[~2026-10-17 16:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-17  9:30 Amirmohammad Eftekhar
2026-10-17 14:06 ` Sean Christopherson
2026-10-17 16:33 ` Amirmohammad Eftekhar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261017163352.4006-1-amirmohammad.eftekhar@cispa.de \
    --to=amirmohammad.eftekhar@cispa.de \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®