From: Jonathan Cameron <jic23@kernel.org>
To: Joshua Crofts <joshua.crofts1@gmail.com>
Cc: "Linus Walleij" <linusw@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, Dingisoul <dingiso.kernel@gmail.com>
Subject: Re: [PATCH v3 0/2] iio: gyro: mpu3050: add missing trigger cleanup
Date: Sat, 17 Oct 2026 19:21:51 +0100 [thread overview]
Message-ID: <20261017192151.15986386@jic23-hlaptop> (raw)
In-Reply-To: <20261017-mpu3050-fix-v3-0-d6f29f335a2b@gmail.com>
On Sat, 17 Oct 2026 07:19:19 +0200
Joshua Crofts <joshua.crofts1@gmail.com> wrote:
> This series fixes an ignored error return value that causes the device
> to behave in a weird polling state and a subsequent use-after-free bug
> reported by Dingisoul.
>
> Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
Not sure where signing off on cover letters came from. There is no need
as they don't form part of the permanent git record so DCO doesn't apply.
Series looks fine to me but given others have been actively responding
to previous versions I'll leave it a while to pick up some tags.
Thanks,
Jonathan
> ---
> Changes in v3:
> - Add a separate patch addressing the missing goto on trigger register
> failure
> - Link to v2: https://lore.kernel.org/r/20261015-mpu3050-fix-v2-1-53f73581e62c@gmail.com
>
> Changes in v2:
> - Add a local struct iio_trigger and assign it to the data struct only
> after a successful IRQ request to prevent a null pointer deref as
> pointed out by Sashiko
> - Link to v1: https://lore.kernel.org/r/20261011-mpu3050-fix-v1-1-f55b0d138be4@gmail.com
>
> ---
> Joshua Crofts (2):
> iio: gyro: mpu3050: fail probe() on trigger registration failure
> iio: gyro: mpu3050: add missing trigger cleanup on remove()
>
> drivers/iio/gyro/mpu3050-core.c | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
> ---
> base-commit: a3b3580713f3ac5a32dc2874ee546828977a1d68
> change-id: 20261011-mpu3050-fix-145a77d5229b
>
> Best regards,
next prev parent reply other threads:[~2026-10-17 18:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-17 5:19 Joshua Crofts
2026-10-17 5:19 ` [PATCH v3 1/2] iio: gyro: mpu3050: fail probe() on trigger registration failure Joshua Crofts
2026-10-17 5:19 ` [PATCH v3 2/2] iio: gyro: mpu3050: add missing trigger cleanup on remove() Joshua Crofts
2026-10-17 18:21 ` Jonathan Cameron [this message]
2026-10-17 20:20 ` [PATCH v3 0/2] iio: gyro: mpu3050: add missing trigger cleanup Joshua Crofts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261017192151.15986386@jic23-hlaptop \
--to=jic23@kernel.org \
--cc=andy@kernel.org \
--cc=dingiso.kernel@gmail.com \
--cc=dlechner@baylibre.com \
--cc=joshua.crofts1@gmail.com \
--cc=linusw@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®