From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65FC0255F28 for ; Sat, 17 Oct 2026 20:40:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792269603; cv=none; b=o5a8vIgh6N9NPLrimWVKTvDmer3qtpQ97w43imMKcyOI5w7ILZw3u/6Z5Rb6hty1VpwweC4L/oNIQunTYZIcr5KYG16mmDHfzf3lWLYMoHrH4s4kZenZ2slnYD+jzZTtdVYkhetX0nsDuGqcRqjQ0KRUuEcRiDJXqqF6k1b9Uw4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792269603; c=relaxed/simple; bh=q7CwHGyeeVgqKz8YQAKoM8SMMJHmzZPnQKS04vZWW5w=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QFnPqFbWOEaVcBHd8Dy6gDIhr+Bu5AMwXTtGPwT0TAGMY3Z7c7eke6Py5eKKSSkmLUPHEJZ33yhliy4jJ5A7ZvuhtoA6Uv5NsC7oy3eGtv9ZVE4/H4dEwkerIpTs7eC4eeaRaXUzbntLN5N8b0kxemC7LLvqWng1fhbWcAhGSS4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ApWI0Koj; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Sbl/eQpd; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ApWI0Koj"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Sbl/eQpd" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69HJ0AGr2882995 for ; Sat, 17 Oct 2026 20:40:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= zr2FtfRs6QhbM03KAXMoqNBJH4R4akb06Udb+D1B0Dc=; b=ApWI0KojAvUBiQ11 83UigDg+OfMWg1EymhELEx/O7puwtlrbsOdnQ+BP7TGzDbjeFV0/Ph/AQv57zxEo X8vpk8+5f9z833O9O9iHFnT91WJOoikgtIDcbSkqlS+T20Ui5LWtniv5r6u0vFVc 9TA9hv7Z2VawH6BrDJMQii9xvp+GNc513CdvxXu/sX+uYuidQXZJs8mxG8dH4gQr FnkGCFN+Cft2IN0ogPqszHshz6HqQq+eWYKHK+CIBNrm+8qbnYoaO8k/024cCXKD sF0AY8FZP0oKulIyk9Sp3ZppE7lcLcbLhTLi2dkYKgwhw1CGeVaR1eEVhFltmYNQ et4KbQ== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hbyys1w6d-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 17 Oct 2026 20:40:01 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-cd61df4951cso995582a12.0 for ; Sat, 17 Oct 2026 13:40:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1792269601; x=1792874401; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:organization :references:in-reply-to:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=zr2FtfRs6QhbM03KAXMoqNBJH4R4akb06Udb+D1B0Dc=; b=Sbl/eQpddy2NfLJ7vwbLtrj5e+emYk/AMhK9XOcQxXBZVHClEUoE3amq8+GtIaVk7Y btTTi0Nd368MqLrjr+XZuxIRNDp54MVwdKyHJUTx6yDbZNT7cuHsT0PxQzWjzvqDn8TB PnsZyvwzB8tl5BiqFuUFdjQRoyacWrd37XGgnHlFMlAI9oUBHK6gYyDGA6rwl2E1dPWu B+XT/CxMk+OvCO6VhxA9wkOdDtcmzXMSIqhyQt6zGuXupvuXbWhmgdS9wOm7J3/BV9FM zSMVn0r/g3jc2WT/CYpF/aGYHN+OWU0eutadEQjNroy1E2yDmo2+P/9pugvzY5UNc1Jc 2qmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792269601; x=1792874401; h=content-transfer-encoding:content-type:mime-version:organization :references:in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=zr2FtfRs6QhbM03KAXMoqNBJH4R4akb06Udb+D1B0Dc=; b=gkhetityKImCfGD6HNE4MR2Z5+iveCd/c+RG1rbqttcKXuXCHF07ZCqYGaSRtuSLUR +PUDx0LWCndfV7s1CqwlNZn7/zrBN1SZVcg51belRu5HJcM4YpGLOXBsU7Y9Z/P6NLWS QmhTGfJHD9o4+DIWg5Zzm4IVlH3jfwF0T01RX2AHeK9f+IPimRHUF4o0UFEE8y4l8nR3 5ib3OqwtvmR8SZBncqL0xgX8FV5EVwl+MsZFVCoOqU+SJe3VVXqkEXYQtc1YDCjXnLgi 7aDHhv28025TWbpqus62aFyLY71L1mBb7csu33pFQ1dvL5YO/9zYakpVJ2nzLh8s/tb7 XQ0g== X-Forwarded-Encrypted: i=1; AKwUvBxJTvGhmr5zbbUXSHYZHGWlZI34fl1/TgkNCBj/PH5CIqGEbtbUI1m+8+7GQAM1CcFocOMg4HqPnD1uirY=@vger.kernel.org X-Gm-Message-State: AFq9FYJyxGAB/PpRep9MelEg6Y/hezkKlm+jS9CCA8Ravj8uFzIGucRZ v7Lg7T0lYOpCTSMZOzuMfCyYPc9ofpbXeTuuP2xPQIxUwOiVRbQmH7h42n8xFqlyeqWqhNePJX8 8wdg9YwRjl1rKcyKp/CjJV+KCASjyg6Gj5+xJ3AsyXxU5pSS4RBjfUNnL1lcqZPTBclzf3We/0k Y= X-Gm-Gg: AYBFou1HutHrPjJ7jgtC12TfEkT66X+0uRiLptCRJxPhMgqK2rK8Uj9zqrbShL+hZbv QmzOnLW50Ak7fcyt93O2yNrvNodeSkCMw0eb2rmVGc+6LoIXwbfoDI8d9VMW30mKCIuwXttO2MQ 9a7B8r2IwCqDVrjI/opDdCjWB2iDspFXBsqw0b4qFR4NKaBV7idRF/TtZaWqSO3rVKsUdkdfBVS OZt5afMZL/V4eKUkF0/X1ohF4s3Rr0Lj2LmRA3yZ81FhJHxCoJvW1FaZKgGXFrpI0TirFYv4X5y 6TmKHDszzjgykFu6WvHNGyfvqgyYPfecin9caGPuUeCZg8Uell70OAu7aF5GLQExNunu9M30hzz N16u3N0nPUbITHjqRbw== X-Received: by 2002:a05:6a21:4903:b0:3e2:d8f:600f with SMTP id adf61e73a8af0-3e22613d7e1mr2777476637.72.1792269601031; Sat, 17 Oct 2026 13:40:01 -0700 (PDT) X-Received: by 2002:a05:6a21:4903:b0:3e2:d8f:600f with SMTP id adf61e73a8af0-3e22613d7e1mr2777448637.72.1792269600528; Sat, 17 Oct 2026 13:40:00 -0700 (PDT) Received: from jic23-hlaptop ([50.35.44.179]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8a05e2e9c4dsm250356b3a.19.2026.10.17.13.39.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Oct 2026 13:39:58 -0700 (PDT) Date: Sat, 17 Oct 2026 21:39:51 +0100 From: Jonathan Cameron To: Rodrigo Alencar via B4 Relay Cc: rodrigo.alencar@analog.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux@analog.com, devicetree@vger.kernel.org, linux-pwm@vger.kernel.org, linux-doc@vger.kernel.org, Olivier Moysan , Jonathan Cameron , David Lechner , Andy Shevchenko , Michael Hennerich , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= , Jonathan Corbet , Shuah Khan , Randy Dunlap Subject: Re: [PATCH 08/10] iio: frequency: ad9910: support iio backend Message-ID: <20261017213951.2e62db95@jic23-hlaptop> In-Reply-To: <20261015-ad9910-backend-support-v1-8-3c21648c8e26@analog.com> References: <20261015-ad9910-backend-support-v1-0-3c21648c8e26@analog.com> <20261015-ad9910-backend-support-v1-8-3c21648c8e26@analog.com> Organization: Qualcomm X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE3MDA4MiBTYWx0ZWRfX7PoRplypWN57 k9WuGzvC0e2bC896gfhs1bVclGcWiTRlFfiunFyveLsLrwF+212vYxUU1JBq7TZ5B4GYdnIbEVo yEPelrl5cc4O+1CW5+JL9gIyGlH1RG0neGrN+RanYpQdMJ8uzNsAeie+oBiusUNME0rYBwgLLMj 5yycghbK7PDpxoQpk3XzC8lz+gE9hamHltpPOGk/ADywAVTeQZZX4mAb3qZj6d4CZoDvLzYABAs ySo5DJchovRPgsbrgomKJo2OgdZnhTYkKTcZdF37Srl1XbvSCSOyTcrXesVjbQDmigOuvT8Ow8m 29HZf+8suKlDxWBwRo98BEdgjabsk6u4XH2VUp2tmwxOLUDp0zVDBL00eyVFo/70qvPpdB/qv7R oPHh6QfVyhE51FKVpt7HAK/X96cg/8EImfWyBfhkpsWcL6EmlkoamEVCsPOCqyB+tG7lDOEmrre mI3hijIX1t5ugHa0Aow== X-Authority-Analysis: v=2.4 cv=W4WtxhWk c=1 sm=1 tr=0 ts=6ad3dd21 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=aNnz9XPx1a4JIXSYt2cE/A==:17 a=kj9zAlcOel0A:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=VwQbUJbxAAAA:8 a=gAnH3GRIAAAA:8 a=bvUjbommzZRmoEgeiV8A:9 a=CjuIK1q_8ugA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-ORIG-GUID: zo4Zy2czTdxpmptn7EmYjdUBS9spX64W X-Proofpoint-GUID: zo4Zy2czTdxpmptn7EmYjdUBS9spX64W X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE3MDA4MiBTYWx0ZWRfX4SG4THrlNT67 bIXjbSqB79X2NJbVTaXhJ2awiVcc3nws2yftW/FiyHPBSHhsa3hyC0c49jG5NbMJhDmRUnhvFvp SoiaqUPD99dECuFTOpTmja656yIpgyQ= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-17_06,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 malwarescore=0 phishscore=0 adultscore=0 priorityscore=1501 suspectscore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610080000 definitions=main-2610170082 On Thu, 15 Oct 2026 13:49:48 -0300 Rodrigo Alencar via B4 Relay wrote: > From: Rodrigo Alencar > > The AD9910 parallel data port allows modulation of the DDS core parameters > at up to the PDCLK rate, which requires a high-speed data source. Add > support for an optional IIO backend that provides such interface, with > data streamed into the device through an output buffer. > > The parallel port channels get scan indexes and scan types according to > the data destination: 14-bit amplitude, 16-bit phase, 16-bit frequency, > or the 8-bit amplitude and phase pair for polar modulation. As only one > destination can be active at a time, this is enforced by the available > scan masks. On buffer enable, the destination is configured in the > backend and the parallel data port is enabled. The sampling_frequency > attribute of the parallel port channels controls the backend data rate. > > The backend is also notified about profile changes, as it may drive the > PROFILE[2:0] pins, and the debugfs source attributes now consider the > parallel data port when reporting which channel controls each DDS core > parameter. > > Signed-off-by: Rodrigo Alencar > diff --git a/drivers/iio/frequency/ad9910.c b/drivers/iio/frequency/ad9910.c > index 3d517879dee3..39d65dafd5a1 100644 > --- a/drivers/iio/frequency/ad9910.c > +++ b/drivers/iio/frequency/ad9910.c > @@ -1075,7 +1122,15 @@ static const struct iio_chan_spec ad9910_channels[] = { > .output = 1, > .channel = AD9910_CHANNEL_PARALLEL_POLAR, > .address = AD9910_CHAN_IDX_PARALLEL_POLAR_AMP, > - .info_mask_separate = BIT(IIO_CHAN_INFO_OFFSET) | > + .scan_index = AD9910_SCAN_IDX_POLAR_AMP, > + .scan_type = { > + .sign = 'u', > + .realbits = 8, > + .storagebits = 8, > + .shift = 0, Really small thing but we tend to drop setting shift when it takes the default of 0. Particularly makes sense here given no room to shift with 8 bits in 8 bits. > + }, > + .info_mask_separate = BIT(IIO_CHAN_INFO_SAMP_FREQ) | > + BIT(IIO_CHAN_INFO_OFFSET) | > BIT(IIO_CHAN_INFO_SCALE), > .parent = &ad9910_channels[AD9910_CHAN_IDX_PHY], > }, > @@ -1085,7 +1140,15 @@ static const struct iio_chan_spec ad9910_channels[] = { > .output = 1, > .channel = AD9910_CHANNEL_PARALLEL_POLAR, > .address = AD9910_CHAN_IDX_PARALLEL_POLAR_PHASE, > - .info_mask_separate = BIT(IIO_CHAN_INFO_OFFSET) | > + .scan_index = AD9910_SCAN_IDX_POLAR_PHASE, > + .scan_type = { > + .sign = 'u', > + .realbits = 8, > + .storagebits = 8, > + .shift = 0, > + }, > + .info_mask_separate = BIT(IIO_CHAN_INFO_SAMP_FREQ) | > + BIT(IIO_CHAN_INFO_OFFSET) | > BIT(IIO_CHAN_INFO_SCALE), > .parent = &ad9910_channels[AD9910_CHAN_IDX_PHY], > },